Linux wireless drivers development
 help / color / mirror / Atom feed
* libertas warnings in upstream
@ 2007-06-13  7:25 Meelis Roos
  2007-06-13  7:53 ` Holger Schurig
  0 siblings, 1 reply; 4+ messages in thread
From: Meelis Roos @ 2007-06-13  7:25 UTC (permalink / raw)
  To: linux-wireless

Tried to test-compile libertas on a 64-bit platform. Are these better in 
2.6.23 material?

  CC [M]  drivers/net/wireless/libertas/cmd.o
drivers/net/wireless/libertas/cmd.c: In function 'wlan_cmd_802_11_set_wep':
drivers/net/wireless/libertas/cmd.c:189: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/libertas/cmd.c:195: warning: large integer implicitly truncated to unsigned type
  CC [M]  drivers/net/wireless/libertas/cmdresp.o
  CC [M]  drivers/net/wireless/libertas/scan.o
drivers/net/wireless/libertas/scan.c: In function 'wlan_scan_process_results':
drivers/net/wireless/libertas/scan.c:235: warning: unused variable 'i'
  CC [M]  drivers/net/wireless/libertas/join.o
  CC [M]  drivers/net/wireless/libertas/11d.o
  CC [M]  drivers/net/wireless/libertas/ioctl.o
  CC [M]  drivers/net/wireless/libertas/debugfs.o
drivers/net/wireless/libertas/debugfs.c: In function 'libertas_getscantable':
drivers/net/wireless/libertas/debugfs.c:85: warning: format '%08llx' expects type 'long long unsigned int', but argument 4 has type 'u64'
drivers/net/wireless/libertas/debugfs.c:85: warning: format '%08llx' expects type 'long long unsigned int', but argument 4 has type 'u64'

-- 
Meelis Roos (mroos@linux.ee)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libertas warnings in upstream
  2007-06-13  7:25 libertas warnings in upstream Meelis Roos
@ 2007-06-13  7:53 ` Holger Schurig
  2007-06-13  8:06   ` David Miller
  2007-06-13  9:26   ` Meelis Roos
  0 siblings, 2 replies; 4+ messages in thread
From: Holger Schurig @ 2007-06-13  7:53 UTC (permalink / raw)
  To: linux-wireless

Hi !

> Tried to test-compile libertas on a 64-bit platform.

I don't have a 64 bit machine and can't therefore say anything
about those 64 issues. However, sparse doesn't moan about
anything, not sure if sparse checks 64bit issues on a 32bit
machine.


But for this warning:

>   CC [M]  drivers/net/wireless/libertas/scan.o
> drivers/net/wireless/libertas/scan.c: In function
> 'wlan_scan_process_results':
> drivers/net/wireless/libertas/scan.c:235: warning: unused
> variable 'i' 

I can assure you that it's already fixed in the libertas-2.6
tree, as of 30 May 2007. Here's a reference:

http://git.infradead.org/?p=libertas-2.6.git;a=commitdiff;h=403eb874fd36c3b8af952e3ff4e6ea2af16c8cf5


In the shortlog in this tree I also see various mentions of 64
fixes, maybe your other issues are handled as well.


Fancy trying this tree with your current kernel?

   git clone --reference /usr/src/linux-git git://git.infradead.org/libertas-2.6
   make -C /usr/src/linux-git modules SUBDIRS=libertas-2.6/drivers/net/wireless/libertas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libertas warnings in upstream
  2007-06-13  7:53 ` Holger Schurig
@ 2007-06-13  8:06   ` David Miller
  2007-06-13  9:26   ` Meelis Roos
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-06-13  8:06 UTC (permalink / raw)
  To: hs4233; +Cc: linux-wireless

From: Holger Schurig <hs4233@mail.mn-solutions.de>
Date: Wed, 13 Jun 2007 09:53:57 +0200

> > Tried to test-compile libertas on a 64-bit platform.
> 
> I don't have a 64 bit machine and can't therefore say anything
> about those 64 issues. However, sparse doesn't moan about
> anything, not sure if sparse checks 64bit issues on a 32bit
> machine.

You don't need 64-bit hardware, don't use this as a reason,
it's invalid.

There are lots of cross-build setups available out there, precompiled
and everything.

sparse can do 64-bit checking if you build using it for a 64-bit
target.  So if you have a cross compile setup, sparse will also do the
right thing.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: libertas warnings in upstream
  2007-06-13  7:53 ` Holger Schurig
  2007-06-13  8:06   ` David Miller
@ 2007-06-13  9:26   ` Meelis Roos
  1 sibling, 0 replies; 4+ messages in thread
From: Meelis Roos @ 2007-06-13  9:26 UTC (permalink / raw)
  To: hs4233, linux-wireless

HS> Fancy trying this tree with your current kernel?
HS> 
HS>    git clone --reference /usr/src/linux-git git://git.infradead.org/libertas-2.6
HS>    make -C /usr/src/linux-git modules SUBDIRS=libertas-2.6/drivers/net/wireless/libertas

These are still present on sparc64, gcc 4.1.2:

  CC [M]  /home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/cmd.o
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/cmd.c: In function 'wlan_cmd_802_11_set_wep':
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/cmd.c:189: warning: large integer implicitly truncated to unsigned type
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/cmd.c:195: warning: large integer implicitly truncated to unsigned type

  CC [M]  /home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/debugfs.o
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/debugfs.c: In function 'libertas_getscantable':
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/debugfs.c:85: warning: format '%08llx' expects type 'long long unsigned int', but argument 4 has type 'u64'
/home/mroos/compile/libertas-2.6/drivers/net/wireless/libertas/debugfs.c:85: warning: format '%08llx' expects type 'long long unsigned int', but argument 4 has type 'u64'

%08zx or something similar here?

-- 
Meelis Roos

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-06-13  9:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-13  7:25 libertas warnings in upstream Meelis Roos
2007-06-13  7:53 ` Holger Schurig
2007-06-13  8:06   ` David Miller
2007-06-13  9:26   ` Meelis Roos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox