* [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
@ 2022-09-15 14:13 Dan Carpenter
2022-09-16 0:24 ` Ping-Ke Shih
2022-09-19 10:09 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-09-15 14:13 UTC (permalink / raw)
To: Ping-Ke Shih, Zong-Zhe Yang
Cc: Kalle Valo, Zong-Zhe Yang, linux-wireless, kernel-janitors
If request_partial_firmware_into_buf() fails then "firmware" is not
initialized and the release_firmware(firmware) will crash.
Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/realtek/rtw89/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
index 8e4d0e18fa71..2be70b907762 100644
--- a/drivers/net/wireless/realtek/rtw89/fw.c
+++ b/drivers/net/wireless/realtek/rtw89/fw.c
@@ -268,7 +268,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
device, &buf, sizeof(buf), 0);
if (ret) {
dev_err(device, "failed to early request firmware: %d\n", ret);
- goto out;
+ return;
}
ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
2022-09-15 14:13 [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize() Dan Carpenter
@ 2022-09-16 0:24 ` Ping-Ke Shih
2022-09-19 10:09 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2022-09-16 0:24 UTC (permalink / raw)
To: Dan Carpenter, Kevin Yang
Cc: Kalle Valo, Kevin Yang, linux-wireless@vger.kernel.org,
kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Thursday, September 15, 2022 10:14 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; Kevin Yang <kevin_yang@realtek.com>
> Cc: Kalle Valo <kvalo@kernel.org>; Kevin Yang <kevin_yang@realtek.com>; linux-wireless@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
>
> If request_partial_firmware_into_buf() fails then "firmware" is not
> initialized and the release_firmware(firmware) will crash.
>
> Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Thank you.
> ---
> drivers/net/wireless/realtek/rtw89/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c
> index 8e4d0e18fa71..2be70b907762 100644
> --- a/drivers/net/wireless/realtek/rtw89/fw.c
> +++ b/drivers/net/wireless/realtek/rtw89/fw.c
> @@ -268,7 +268,7 @@ void rtw89_early_fw_feature_recognize(struct device *device,
> device, &buf, sizeof(buf), 0);
> if (ret) {
> dev_err(device, "failed to early request firmware: %d\n", ret);
> - goto out;
> + return;
> }
>
> ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ?
> --
> 2.35.1
>
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
2022-09-15 14:13 [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize() Dan Carpenter
2022-09-16 0:24 ` Ping-Ke Shih
@ 2022-09-19 10:09 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-09-19 10:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Ping-Ke Shih, Zong-Zhe Yang, Zong-Zhe Yang, linux-wireless,
kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If request_partial_firmware_into_buf() fails then "firmware" is not
> initialized and the release_firmware(firmware) will crash.
>
> Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
4c3140f4cea6 wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
--
https://patchwork.kernel.org/project/linux-wireless/patch/YyMzDtX/3fUBnonC@kili/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-19 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15 14:13 [PATCH] wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize() Dan Carpenter
2022-09-16 0:24 ` Ping-Ke Shih
2022-09-19 10:09 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox