[PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Ernest Van Hoecke]

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

qcom,calibration-variant selects board-specific calibration data for
systems where the bus and device IDs are not unique.

This is not specific to WSI-capable QCN9274 devices. The WSI binding
already allows the property, so allow it in the WCN7850 PCI binding too.

Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
---
Document qcom,calibration-variant in the WCN7850 PCI binding. The
generic property is already documented for ath12k WSI devices in
qcom,ath12k-wsi.yaml, and selecting board-specific calibration data is
not specific to WSI-capable QCN9274 designs.

This complements Andrew LaMarche's ath12k driver series, which adds
driver support for reading qcom,calibration-variant from the device tree
and drops the deprecated qcom,ath12k-calibration-variant from the WSI
binding:

https://lore.kernel.org/ath12k/20260630133001.1426824-1-andrewjlamarche@gmail.com/T/#t

That series makes the generic property effective in the driver while
this patch closes the schema gap for WCN7850 devices.
---
 Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
index dc68dd59988f..cf3e1fd99c12 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k.yaml
@@ -54,6 +54,12 @@ properties:
   vddpcie1p8-supply:
     description: VDD_PCIE_1P8 supply regulator handle
 
+  qcom,calibration-variant:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      String to uniquely identify variant of the calibration data for designs
+      with colliding bus and device ids
+
 required:
   - compatible
   - reg

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260701-ath12k-calibration-variant-b7850f7ffd7c

Best regards,
-- 
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

Re: [PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Krzysztof Kozlowski]

On Wed, Jul 01, 2026 at 05:42:24PM +0200, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> qcom,calibration-variant selects board-specific calibration data for
> systems where the bus and device IDs are not unique.
> 
> This is not specific to WSI-capable QCN9274 devices. The WSI binding
> already allows the property, so allow it in the WCN7850 PCI binding too.

Why? You need to provide reasons WHY do we want this.

> 
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

Where is any user of this?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Krzysztof Kozlowski]

On 02/07/2026 10:27, Krzysztof Kozlowski wrote:
> On Wed, Jul 01, 2026 at 05:42:24PM +0200, Ernest Van Hoecke wrote:
>> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>>
>> qcom,calibration-variant selects board-specific calibration data for
>> systems where the bus and device IDs are not unique.
>>
>> This is not specific to WSI-capable QCN9274 devices. The WSI binding
>> already allows the property, so allow it in the WCN7850 PCI binding too.
> 
> Why? You need to provide reasons WHY do we want this.
> 
>>
>> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> Where is any user of this?
> 

Actually I missed your link in changelog section. I still however do not
understand why these are separate. Separate means they are completely
independent and thus my question about the user stays.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Ernest Van Hoecke]

On Thu, Jul 02, 2026 at 10:29:51AM +0200, Krzysztof Kozlowski wrote:
> On 02/07/2026 10:27, Krzysztof Kozlowski wrote:
> > On Wed, Jul 01, 2026 at 05:42:24PM +0200, Ernest Van Hoecke wrote:
> >> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> >>
> >> qcom,calibration-variant selects board-specific calibration data for
> >> systems where the bus and device IDs are not unique.
> >>
> >> This is not specific to WSI-capable QCN9274 devices. The WSI binding
> >> already allows the property, so allow it in the WCN7850 PCI binding too.
> > 
> > Why? You need to provide reasons WHY do we want this.
> > 

We (Toradex) have SoMs with the SX-PCEBE from Silex, which uses the
WCN7850. Silex provided multiple board files for this to deal with
separate regulatory regions. Thus, we need a mechanism to select which
one to use even though the PCI ID and machines are the same.

> >>
> >> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > 
> > Where is any user of this?
> > 
> 
> Actually I missed your link in changelog section. I still however do not
> understand why these are separate. Separate means they are completely
> independent and thus my question about the user stays.
> 
> Best regards,
> Krzysztof

I agree that they could be one patchset and considered replying there,
but felt it easier to discuss this with the relevant patch already
attached. As the other binding already validates this property there is
no real dependency or ordering problem, and I thought this would ease
review.

Kind regards,
Ernest

Re: [PATCH] dt-bindings: wireless: ath12k: allow calibration variant for WCN7850

[Krzysztof Kozlowski]

On 02/07/2026 11:00, Ernest Van Hoecke wrote:
> On Thu, Jul 02, 2026 at 10:29:51AM +0200, Krzysztof Kozlowski wrote:
>> On 02/07/2026 10:27, Krzysztof Kozlowski wrote:
>>> On Wed, Jul 01, 2026 at 05:42:24PM +0200, Ernest Van Hoecke wrote:
>>>> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>>>>
>>>> qcom,calibration-variant selects board-specific calibration data for
>>>> systems where the bus and device IDs are not unique.
>>>>
>>>> This is not specific to WSI-capable QCN9274 devices. The WSI binding
>>>> already allows the property, so allow it in the WCN7850 PCI binding too.
>>>
>>> Why? You need to provide reasons WHY do we want this.
>>>
> 
> We (Toradex) have SoMs with the SX-PCEBE from Silex, which uses the
> WCN7850. Silex provided multiple board files for this to deal with
> separate regulatory regions. Thus, we need a mechanism to select which
> one to use even though the PCI ID and machines are the same.
> 
>>>>
>>>> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
>>>
>>> Where is any user of this?
>>>
>>
>> Actually I missed your link in changelog section. I still however do not
>> understand why these are separate. Separate means they are completely
>> independent and thus my question about the user stays.
>>
>> Best regards,
>> Krzysztof
> 
> I agree that they could be one patchset and considered replying there,
> but felt it easier to discuss this with the relevant patch already
> attached. As the other binding already validates this property there is
> no real dependency or ordering problem, and I thought this would ease
> review.

If you do not have user in this patchset then your commit msg must
explain why you are adding this, otherwise it just looks like you are
adding unused ABI.

Best regards,
Krzysztof