please use tree tags in patches

please use tree tags in patches

[Johannes Berg]

Hi,

I couldn't (yet?) figure out how to make the nipa bot stuff run
properly, so please start using

  [PATCH wireless] wifi: xyz

or

  [PATCH wireless-next] wifi: xyz

for the subject line. This way the automation can pick it up, see e.g.

https://patchwork.kernel.org/project/linux-wireless/list/?series=936374

I'll need to fix some username stuff etc.

I likely also need to add more trees to it - please reply with your
subject tags, trees and branches to use, e.g.

wireless: main
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/

wireless-next: main
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/

but perhaps we want to have

rtw-next: rtw-next
https://github.com/pkshih/rtw

or so? Not sure if you maintain a fixes branch there too?


Anyway, good luck to me, and please don't try to attack it ;-) I spent
all day setting it up, and haven't pulled out everything yet.

johannes

Re: please use tree tags in patches

[Jeff Johnson]

On 2/21/2025 4:17 AM, Johannes Berg wrote:
> Hi,
> 
> I couldn't (yet?) figure out how to make the nipa bot stuff run
> properly, so please start using
> 
>   [PATCH wireless] wifi: xyz
> 
> or
> 
>   [PATCH wireless-next] wifi: xyz
> 
> for the subject line. This way the automation can pick it up, see e.g.
> 
> https://patchwork.kernel.org/project/linux-wireless/list/?series=936374
> 
> I'll need to fix some username stuff etc.
> 
> I likely also need to add more trees to it - please reply with your
> subject tags, trees and branches to use, e.g.
> 
> wireless: main
> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/
> 
> wireless-next: main
> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/
> 
> but perhaps we want to have
> 
> rtw-next: rtw-next
> https://github.com/pkshih/rtw
> 
> or so? Not sure if you maintain a fixes branch there too?
> 
> 
> Anyway, good luck to me, and please don't try to attack it ;-) I spent
> all day setting it up, and haven't pulled out everything yet.

First of all, thank you for adding any automation which improves the lives of
the maintainers. Aditya has been working on that for the ath.git tree as well.

ath.git contains both ath-current and ath-next branches in the same tree:
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath-current
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath-next

So we can use:
	[PATCH ath] for current (this branch gets little use)
	[PATCH ath-next] for next
if that helps your automation.

And for Qualcomm contributions we've been asking the developers to always
supply a base: hash to also denote the basis of a patchset.

/jeff

Re: please use tree tags in patches

[Johannes Berg]

On Fri, 2025-02-21 at 10:27 -0800, Jeff Johnson wrote:
> First of all, thank you for adding any automation which improves the lives of
> the maintainers. Aditya has been working on that for the ath.git tree as well.

Cool. Do you have additional tests that should feed back to patchwork?

> ath.git contains both ath-current and ath-next branches in the same tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath-current
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/log/?h=ath-next
> 
> So we can use:
> 	[PATCH ath] for current (this branch gets little use)
> 	[PATCH ath-next] for next
> if that helps your automation.

Yes please. I've picked up those trees in my config/workspace now, so it
ought to work and report back, but we'll see when patches are posted.

As I just said to Ping-Ke, we can hopefully also improve the auto-detect
logic, but I didn't get there yet.

johannes

RE: please use tree tags in patches

[Ping-Ke Shih]

Johannes Berg <johannes@sipsolutions.net> wrote:
> Hi,
> 
> I couldn't (yet?) figure out how to make the nipa bot stuff run
> properly, so please start using
> 
>   [PATCH wireless] wifi: xyz
> 
> or
> 
>   [PATCH wireless-next] wifi: xyz
> 
> for the subject line. This way the automation can pick it up, see e.g.
> 
> https://patchwork.kernel.org/project/linux-wireless/list/?series=936374
> 
> I'll need to fix some username stuff etc.
> 
> I likely also need to add more trees to it - please reply with your
> subject tags, trees and branches to use, e.g.
> 
> wireless: main
> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git/
> 
> wireless-next: main
> https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/
> 
> but perhaps we want to have
> 
> rtw-next: rtw-next
> https://github.com/pkshih/rtw
> 
> or so? Not sure if you maintain a fixes branch there too?
> 
> 
> Anyway, good luck to me, and please don't try to attack it ;-) I spent
> all day setting it up, and haven't pulled out everything yet.
> 

Thanks for the automation. I think it will be very useful for me to detect
patch errors earlier, so submitters can fix problems earlier before I'm
trying to merge. 

I have created rtw branch as the fixes branch, so

[PATCH rtw-next]
https://github.com/pkshih/rtw rtw-next
(clone from wirless-next/main; this is for regular development)

[PATCH rtw]
https://github.com/pkshih/rtw rtw
(clone from wireless/main; this is for urgent fixes)

Ping-Ke

Re: please use tree tags in patches

[Johannes Berg]

On Mon, 2025-02-24 at 01:18 +0000, Ping-Ke Shih wrote:
> 
> 
> Thanks for the automation. I think it will be very useful for me to detect
> patch errors earlier, so submitters can fix problems earlier before I'm
> trying to merge. 

Hopefully. Right now we still need to get the [PATCH rtw] tags into the
patches before. Perhaps we can auto-detect somehow later.

> I have created rtw branch as the fixes branch, so
> 
> [PATCH rtw-next]
> https://github.com/pkshih/rtw rtw-next
> (clone from wirless-next/main; this is for regular development)
> 
> [PATCH rtw]
> https://github.com/pkshih/rtw rtw
> (clone from wireless/main; this is for urgent fixes)

Added both, I hope :)

johannes

Re: please use tree tags in patches

[Johannes Berg]

On Mon, 2025-02-24 at 10:33 +0100, Johannes Berg wrote:
> On Mon, 2025-02-24 at 01:18 +0000, Ping-Ke Shih wrote:
> > 
> > 
> > Thanks for the automation. I think it will be very useful for me to detect
> > patch errors earlier, so submitters can fix problems earlier before I'm
> > trying to merge. 
> 
> Hopefully. Right now we still need to get the [PATCH rtw] tags into the
> patches before. Perhaps we can auto-detect somehow later.
> 

FWIW I'm running this now:
https://github.com/jmberg/nipa/tree/configurable-list-wifi

In case anyone wants to take a look and/or help out with the tree
detection.

johannes

Re: please use tree tags in patches

[Jeff Johnson]

On 2/24/2025 3:15 AM, Johannes Berg wrote:
> On Mon, 2025-02-24 at 10:33 +0100, Johannes Berg wrote:
>> On Mon, 2025-02-24 at 01:18 +0000, Ping-Ke Shih wrote:
>>>
>>>
>>> Thanks for the automation. I think it will be very useful for me to detect
>>> patch errors earlier, so submitters can fix problems earlier before I'm
>>> trying to merge. 
>>
>> Hopefully. Right now we still need to get the [PATCH rtw] tags into the
>> patches before. Perhaps we can auto-detect somehow later.
>>
> 
> FWIW I'm running this now:
> https://github.com/jmberg/nipa/tree/configurable-list-wifi
> 
> In case anyone wants to take a look and/or help out with the tree
> detection.

Probably related, can you check:
https://patchwork.kernel.org/project/linux-wireless/patch/20250226113118.7626-1-quic_lingbok@quicinc.com/

This uses the "ath-next" tag but triggered:
jmberg/fixes_present	fail	Series targets non-next tree, but doesn't contain any Fixes tags