From: Johannes Berg <johannes@sipsolutions.net>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
linux-wireless@vger.kernel.org
Cc: Benjamin Berg <benjamin.berg@intel.com>, Ilan Peer <ilan.peer@intel.com>
Subject: Re: [PATCH iwlwifi] wifi: mac80211: ignore reserved bits in reconfiguration status
Date: Tue, 20 Jan 2026 10:09:22 +0100 [thread overview]
Message-ID: <a85a3aefd4a60536d68e6bbd2e6a8a2af9846aea.camel@sipsolutions.net> (raw)
In-Reply-To: <20260118095410.e54a0830f697.I9aef8f4fb6f1b06671bb6cf0e2bd4ec6e4c8bda4@changeid> (sfid-20260118_085436_785820_710033D5)
On Sun, 2026-01-18 at 09:54 +0200, Miri Korenblit wrote:
>
> +++ b/net/mac80211/mlme.c
> @@ -10243,7 +10243,7 @@ void ieee80211_process_ml_reconf_resp(struct ieee80211_sub_if_data *sdata,
> for (i = 0; i < mgmt->u.action.u.ml_reconf_resp.count; i++) {
> u16 status = get_unaligned_le16(pos + 1);
>
> - link_id = *pos;
> + link_id = u8_get_bits(*pos, 0xf);
Seems like there should be a constant for that? Or maybe even some kind
of struct for the "Reconfiguration Status Duple subfield", rather than
parsing the things separately?
johannes
prev parent reply other threads:[~2026-01-20 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 7:54 [PATCH iwlwifi] wifi: mac80211: ignore reserved bits in reconfiguration status Miri Korenblit
2026-01-20 9:09 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85a3aefd4a60536d68e6bbd2e6a8a2af9846aea.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin.berg@intel.com \
--cc=ilan.peer@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox