Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Josef Miegl <josef@miegl.cz>
Cc: Sebastian Gottschall <s.gottschall@newmedia-net.de>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Implementing Mikrotik IE
Date: Fri, 23 Aug 2019 12:54:42 +0200	[thread overview]
Message-ID: <a8f0fcfcc9d810aee1df461f051a757703cde2e5.camel@sipsolutions.net> (raw)
In-Reply-To: <68A3B9AF-8864-4C0F-A50B-71CCB76AE81D@miegl.cz>


> Works great. Is there a possibility that a toggle for this could be
> accepted upstream? After all, WDS isn't really standardized.

I general, I'd say yes. However!

There's ongoing to work to make EAPOL frames go over nl80211 instead,
see e.g. ieee80211_tx_control_port() in mac80211, and this patch for
hostapd:

https://patchwork.ozlabs.org/patch/1108185/

I'd prefer to have it in this path, by having a flag like the "bool
unencrypted" passed to ieee80211_tx_control_port(), (and replace "bool
unencrypted" by "unsigned int flags"). That way, we don't have to
actually keep any state.

In mac80211, we can pass this down to __ieee80211_subif_start_xmit() and
ieee80211_build_hdr() in the ctrl_flags or something like that. It
doesn't actually need to be a control or info flag, so we could add yet
another argument to save the space, but dunno if that's worth it now.

johannes


  reply	other threads:[~2019-08-23 10:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 15:28 Implementing Mikrotik IE Josef Miegl
2019-08-16  4:07 ` Sebastian Gottschall
2019-08-16 11:10   ` Josef Miegl
2019-08-16 11:15     ` Sebastian Gottschall
2019-08-16 11:38       ` Josef Miegl
2019-08-19 10:12         ` Johannes Berg
2019-08-19 11:37           ` Josef Miegl
2019-08-19 20:21             ` Johannes Berg
2019-08-21 20:04               ` Josef Miegl
2019-08-21 20:09                 ` Sebastian Gottschall
2019-08-21 20:12                 ` Johannes Berg
2019-08-21 21:17                   ` Josef Miegl
2019-08-22  7:00                     ` Johannes Berg
2019-08-22 20:08                       ` Johannes Berg
2019-08-22 21:06                         ` Josef Miegl
2019-08-23 10:54                           ` Johannes Berg [this message]
2019-08-27 13:08                           ` Sebastian Gottschall
2019-08-27 13:10                             ` Johannes Berg
2019-08-27 13:14                               ` Sebastian Gottschall
2019-08-20 11:53           ` Sebastian Gottschall
2019-08-20 12:22             ` Johannes Berg
2019-08-20 12:46               ` Sebastian Gottschall
2019-08-21 21:19               ` Josef Miegl
     [not found]               ` <8ec8202e-ca07-3594-5873-5b282d553711@newmedia-net.de>
2019-08-21 23:57                 ` Josef Miegl
2019-08-22  6:58                   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8f0fcfcc9d810aee1df461f051a757703cde2e5.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=josef@miegl.cz \
    --cc=linux-wireless@vger.kernel.org \
    --cc=s.gottschall@newmedia-net.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox