[PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[Gustavo A. R. Silva]

Remove unused structures and avoid the following
-Wflex-array-member-not-at-end warnings:

drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
index 1e8ab704dbfb..f00eb878b94b 100644
--- a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
+++ b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
@@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
 	__le16 duration;
 } __packed;
 
-struct ieee80211_info_element {
-	u8 id;
-	u8 len;
-	u8 data[];
-} __packed;
-
-struct ieee80211_measurement_request {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	struct ieee80211_measurement_params params[];
-} __packed;
-
-struct ieee80211_measurement_report {
-	struct ieee80211_info_element ie;
-	u8 token;
-	u8 mode;
-	u8 type;
-	union {
-		struct ieee80211_basic_report basic[0];
-	} u;
-} __packed;
-
 #endif
-- 
2.43.0

Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[Stanislaw Gruszka]

On Mon, Aug 11, 2025 at 02:10:39PM +0900, Gustavo A. R. Silva wrote:
> Remove unused structures and avoid the following
> -Wflex-array-member-not-at-end warnings:
> 
> drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>

> ---
>  .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> index 1e8ab704dbfb..f00eb878b94b 100644
> --- a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> +++ b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> @@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
>  	__le16 duration;
>  } __packed;
>  
> -struct ieee80211_info_element {
> -	u8 id;
> -	u8 len;
> -	u8 data[];
> -} __packed;
> -
> -struct ieee80211_measurement_request {
> -	struct ieee80211_info_element ie;
> -	u8 token;
> -	u8 mode;
> -	u8 type;
> -	struct ieee80211_measurement_params params[];
> -} __packed;
> -
> -struct ieee80211_measurement_report {
> -	struct ieee80211_info_element ie;
> -	u8 token;
> -	u8 mode;
> -	u8 type;
> -	union {
> -		struct ieee80211_basic_report basic[0];
> -	} u;
> -} __packed;
> -
>  #endif
> -- 
> 2.43.0
> 

Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[Gustavo A. R. Silva]

Hi all,

Friendly ping: who can take this, please? :)

Thanks!
-Gustavo

On 11/08/25 07:10, Gustavo A. R. Silva wrote:
> Remove unused structures and avoid the following
> -Wflex-array-member-not-at-end warnings:
> 
> drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:68:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h:60:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
>   .../wireless/intel/iwlegacy/iwl-spectrum.h    | 24 -------------------
>   1 file changed, 24 deletions(-)
> 
> diff --git a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> index 1e8ab704dbfb..f00eb878b94b 100644
> --- a/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> +++ b/drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
> @@ -50,28 +50,4 @@ struct ieee80211_measurement_params {
>   	__le16 duration;
>   } __packed;
>   
> -struct ieee80211_info_element {
> -	u8 id;
> -	u8 len;
> -	u8 data[];
> -} __packed;
> -
> -struct ieee80211_measurement_request {
> -	struct ieee80211_info_element ie;
> -	u8 token;
> -	u8 mode;
> -	u8 type;
> -	struct ieee80211_measurement_params params[];
> -} __packed;
> -
> -struct ieee80211_measurement_report {
> -	struct ieee80211_info_element ie;
> -	u8 token;
> -	u8 mode;
> -	u8 type;
> -	union {
> -		struct ieee80211_basic_report basic[0];
> -	} u;
> -} __packed;
> -
>   #endif

Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[Johannes Berg]

On Wed, 2025-08-27 at 11:25 +0200, Gustavo A. R. Silva wrote:
> Friendly

I contest that. It's been two weeks, while it's still summer with
vacations etc., not long after the merge window closed, with weeks to go
until the next release comes around. Why are you impatient?

I will take it. Eventually, the more you push the less I want to. And
it'd help if you actually followed our conventions and used 'wifi:'
prefix.

johannes

Re: [PATCH] iwlegacy: Remove unused structs and avoid -Wflex-array-member-not-at-end warnings

[Gustavo A. R. Silva]

On 27/08/25 11:36, Johannes Berg wrote:
> On Wed, 2025-08-27 at 11:25 +0200, Gustavo A. R. Silva wrote:
>> Friendly
> 
> I contest that. It's been two weeks, while it's still summer with

Sorry, I don't really know when people around the globe are on vacation
or not. I don't think we're based in the same area, so our customs may
vary.

> vacations etc., not long after the merge window closed, with weeks to go
> until the next release comes around. Why are you impatient?

Apparently (and according to git blame), the last person that committed a
change to this file was Greg KH back in 2019, see: commit 16da78b7b580e
("treewide: Replace GPLv2 boilerplate/ reference with SPDX - rule 270").

So, rather than impatience is more about not really knowing who's maintaining
this file.

> 
> I will take it. Eventually, the more you push the less I want to. And

Not sure what to make of this. I'm just doing my work and trying to
collaborate with people. I expect all my comments here clarify the
reason for the ping.

> it'd help if you actually followed our conventions and used 'wifi:'
> prefix.

Related to my comments above, you're not listed as a maintainer of this
file. If you were, I'd have probably remembered that.

scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/net/wireless/intel/iwlegacy/iwl-spectrum.h
Stanislaw Gruszka <stf_xl@wp.pl> (maintainer:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-wireless@vger.kernel.org (open list:INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy))
linux-kernel@vger.kernel.org (open list)
INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy) status: Supported

In any case, thanks for your response.
-Gustavo