Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <rafal@milecki.pl>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
	Wright Feng <wright.feng@cypress.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>
Subject: Re: brcmfmac: regression using AP mode
Date: Sat, 24 Nov 2018 22:23:55 +0100	[thread overview]
Message-ID: <ab765dfac2c4a19d820677c5c05a5566@milecki.pl> (raw)
In-Reply-To: <142675996.139583.1543082320719@email.ionos.de>

On 2018-11-24 18:58, Stefan Wahren wrote:
> today i wanted to setup an access point on my Raspberry Pi 3 A+
> (BCM43455). Unfortunately the hostapd 2.4 shipped with Raspbian failed
> with recent Linux kernel:
> 
> (...)
> 
> I was able to bisect this issue down to this commit:
> 
> 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag")
> 
> After reverting this commit hostapd works as expected.

It ringed a bell, I did a quick research and found it. It's because of
that ancient hostapd you're using. 2,5 years ago hostapd received a fix
for its discovery of driver capabilities:

commit f4830bed661f4adff51f50a0d37c64ceb748e780
Author: Rafał Miłecki <zajec5@gmail.com>
Date:   Mon Apr 25 17:10:47 2016 +0200

     nl80211: Try running without mgmt frame subscription (driver AP SME)

So your problem is the ancient hostapd that can't run with drivers that:
1) Report NL80211_ATTR_DEVICE_AP_SME
2) Don't support subscribing for PROBE_REQ and/or ACTION frames

Technically there is nothing wrong with such drivers and it's just a
hostapd bug (that's why it was fixed long time ago).

Now, you could try *not* reporting NL80211_ATTR_DEVICE_AP_SME but then
hostapd for drivers that:
1) Support monitor mode
2) Don't support subscribing for PROBE_REQ and/or ACTION frames
will hit yet another mode discovery path in and break as well.

That said there is no perfect solution.

brcmfmac *should* set WIPHY_FLAG_HAVE_AP_SME. It's required for a sane
capabilities discovery in hostapd. It's required to make sure other
supplicants can work with brcmfmac as well.

Possibly you can just update hostapd to anything more recent? I'm afraid
the version you're using may suffer from a lot of security issues anyway

  reply	other threads:[~2018-11-24 21:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 17:58 brcmfmac: regression using AP mode Stefan Wahren
2018-11-24 21:23 ` Rafał Miłecki [this message]
2018-11-25 13:14   ` Stefan Wahren
2018-11-26 10:11     ` Arend van Spriel
2018-11-26 18:14       ` Stefan Wahren
2018-11-28 20:13         ` Stefan Wahren
2018-11-29 10:42           ` James Hughes
2018-12-07 10:29       ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab765dfac2c4a19d820677c5c05a5566@milecki.pl \
    --to=rafal@milecki.pl \
    --cc=arend.vanspriel@broadcom.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=wright.feng@cypress.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox