* [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning
@ 2025-03-21 14:36 Dan Carpenter
2025-03-31 10:25 ` Korenblit, Miriam Rachel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-03-21 14:36 UTC (permalink / raw)
To: Pagadala Yesu Anjaneyulu
Cc: Miri Korenblit, Johannes Berg, Benjamin Berg, linux-wireless,
linux-kernel, kernel-janitors
The "resp_len" isn't initliazed if iwl_dhc_resp_data() fails.
Fixes: b611cf6b57a8 ("wifi: iwlwifi: mld: add support for DHC_TOOLS_UMAC_GET_TAS_STATUS command")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/mld/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
index 453ce2ba39d1..89d95e9b4f30 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
@@ -396,8 +396,8 @@ static ssize_t iwl_dbgfs_tas_get_status_read(struct iwl_mld *mld, char *buf,
.data[0] = &cmd,
};
struct iwl_dhc_tas_status_resp *resp = NULL;
+ u32 resp_len = 0;
ssize_t pos = 0;
- u32 resp_len;
u32 status;
int ret;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning
2025-03-21 14:36 [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning Dan Carpenter
@ 2025-03-31 10:25 ` Korenblit, Miriam Rachel
0 siblings, 0 replies; 2+ messages in thread
From: Korenblit, Miriam Rachel @ 2025-03-31 10:25 UTC (permalink / raw)
To: Dan Carpenter, Anjaneyulu, Pagadala Yesu
Cc: Berg, Johannes, Berg, Benjamin, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Friday, 21 March 2025 16:36
> To: Anjaneyulu, Pagadala Yesu <pagadala.yesu.anjaneyulu@intel.com>
> Cc: Korenblit, Miriam Rachel <miriam.rachel.korenblit@intel.com>; Berg,
> Johannes <johannes.berg@intel.com>; Berg, Benjamin
> <benjamin.berg@intel.com>; linux-wireless@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning
>
> The "resp_len" isn't initliazed if iwl_dhc_resp_data() fails.
>
> Fixes: b611cf6b57a8 ("wifi: iwlwifi: mld: add support for
> DHC_TOOLS_UMAC_GET_TAS_STATUS command")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/net/wireless/intel/iwlwifi/mld/debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> index 453ce2ba39d1..89d95e9b4f30 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mld/debugfs.c
> @@ -396,8 +396,8 @@ static ssize_t iwl_dbgfs_tas_get_status_read(struct
> iwl_mld *mld, char *buf,
> .data[0] = &cmd,
> };
> struct iwl_dhc_tas_status_resp *resp = NULL;
> + u32 resp_len = 0;
> ssize_t pos = 0;
> - u32 resp_len;
> u32 status;
> int ret;
>
> --
> 2.47.2
Acked-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-31 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-21 14:36 [PATCH next] wifi: iwlwifi: mld: silence uninitialized variable warning Dan Carpenter
2025-03-31 10:25 ` Korenblit, Miriam Rachel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox