* [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str()
@ 2026-06-08 12:34 Dan Carpenter
2026-06-09 0:44 ` Ping-Ke Shih
2026-07-03 2:19 ` Ping-Ke Shih
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-06-08 12:34 UTC (permalink / raw)
To: Kuan-Chung Chen; +Cc: Ping-Ke Shih, linux-wireless, kernel-janitors
This > comparison should be >= to avoid an out of bounds access.
Fixes: 419ed7f4a053 ("wifi: rtw89: debug: extend bb_info with TX status and PER")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/net/wireless/realtek/rtw89/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/debug.c b/drivers/net/wireless/realtek/rtw89/debug.c
index 8f5af873e09f..5786120602ab 100644
--- a/drivers/net/wireless/realtek/rtw89/debug.c
+++ b/drivers/net/wireless/realtek/rtw89/debug.c
@@ -4348,7 +4348,7 @@ static const char *rtw89_ppdu_str(struct rtw89_dev *rtwdev, u8 type, u8 subtype)
const struct rtw89_chip_info *chip = rtwdev->chip;
const struct rtw89_ppdu_info *ppdu_info;
- if (type > ARRAY_SIZE(rtw89_ppdu_infos))
+ if (type >= ARRAY_SIZE(rtw89_ppdu_infos))
return "RSVD";
ppdu_info = &rtw89_ppdu_infos[type];
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() 2026-06-08 12:34 [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() Dan Carpenter @ 2026-06-09 0:44 ` Ping-Ke Shih 2026-07-03 2:19 ` Ping-Ke Shih 1 sibling, 0 replies; 3+ messages in thread From: Ping-Ke Shih @ 2026-06-09 0:44 UTC (permalink / raw) To: Dan Carpenter, Damon Chen Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter <error27@gmail.com> wrote: > This > comparison should be >= to avoid an out of bounds access. > > Fixes: 419ed7f4a053 ("wifi: rtw89: debug: extend bb_info with TX status and PER") > Signed-off-by: Dan Carpenter <error27@gmail.com> Thanks for the finding. Acked-by: Ping-Ke Shih <pkshih@realtek.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() 2026-06-08 12:34 [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() Dan Carpenter 2026-06-09 0:44 ` Ping-Ke Shih @ 2026-07-03 2:19 ` Ping-Ke Shih 1 sibling, 0 replies; 3+ messages in thread From: Ping-Ke Shih @ 2026-07-03 2:19 UTC (permalink / raw) To: Dan Carpenter, Kuan-Chung Chen Cc: Ping-Ke Shih, linux-wireless, kernel-janitors Dan Carpenter <error27@gmail.com> wrote: > This > comparison should be >= to avoid an out of bounds access. > > Fixes: 419ed7f4a053 ("wifi: rtw89: debug: extend bb_info with TX status and PER") > Signed-off-by: Dan Carpenter <error27@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 1908534deb53 wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() --- https://github.com/pkshih/rtw.git ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-03 2:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-08 12:34 [PATCH next] wifi: rtw89: debug: fix off by on in rtw89_ppdu_str() Dan Carpenter 2026-06-09 0:44 ` Ping-Ke Shih 2026-07-03 2:19 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox