* [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out
@ 2026-07-31 17:04 Chris Bainbridge
2026-08-02 7:24 ` Korenblit, Miriam Rachel
0 siblings, 1 reply; 6+ messages in thread
From: Chris Bainbridge @ 2026-07-31 17:04 UTC (permalink / raw)
To: emmanuel.grumbach
Cc: johannes.berg, miriam.rachel.korenblit, linux-wireless,
regressions
Hi,
0eaa1f245ac0 ("wifi: iwlwifi: mvm: don't support the reset handshake for
old firmwares") introduced an intermittent boot regression on my laptop:
[ 15.974991] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000a address=0xbe9f5000 flags=0x0000]
[ 15.976184] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000a address=0xbe9f5400 flags=0x0000]
[ 15.978501] iwlwifi 0000:01:00.0: Master Disable Timed Out, 100 usec
The commit only contains:
+ /* Those firmware versions claim to support the fw_reset_handshake
+ * but they are buggy.
+ */
+ if (IWL_UCODE_MAJOR(mvm->fw->ucode_ver) <= 77)
+ trans->conf.fw_reset_handshake = false;
The if condition is evaluating true on my laptop despite using firmware
ty-a0-gf-a0-89.ucode. So I suspect this is not the correct way to check
the firmware version?
Also comment #21 on bugzilla.kernel.org bug #220600 (which this commit
was supposed to fix) reports the same "Master Disable Timed Out" error
(although no IO_PAGE_FAULTS, probably the bad memory access is not
caught without iommu=strict).
#regzbot introduced: 0eaa1f245ac03ed0c6394159360532726f666811
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out 2026-07-31 17:04 [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out Chris Bainbridge @ 2026-08-02 7:24 ` Korenblit, Miriam Rachel 2026-08-04 21:03 ` Chris Bainbridge 2026-10-12 15:52 ` Thorsten Leemhuis 0 siblings, 2 replies; 6+ messages in thread From: Korenblit, Miriam Rachel @ 2026-08-02 7:24 UTC (permalink / raw) To: Chris Bainbridge, Grumbach, Emmanuel Cc: Berg, Johannes, linux-wireless@vger.kernel.org, regressions@lists.linux.dev [-- Attachment #1: Type: text/plain, Size: 1850 bytes --] > -----Original Message----- > From: Chris Bainbridge <chris.bainbridge@gmail.com> > Sent: Friday, July 31, 2026 8:05 PM > To: Grumbach, Emmanuel <emmanuel.grumbach@intel.com> > Cc: Berg, Johannes <johannes.berg@intel.com>; Korenblit, Miriam Rachel > <miriam.rachel.korenblit@intel.com>; linux-wireless@vger.kernel.org; > regressions@lists.linux.dev > Subject: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out > > Hi, > > 0eaa1f245ac0 ("wifi: iwlwifi: mvm: don't support the reset handshake for old > firmwares") introduced an intermittent boot regression on my laptop: > > [ 15.974991] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT > domain=0x000a address=0xbe9f5000 flags=0x0000] > [ 15.976184] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT > domain=0x000a address=0xbe9f5400 flags=0x0000] > [ 15.978501] iwlwifi 0000:01:00.0: Master Disable Timed Out, 100 usec > > The commit only contains: > > + /* Those firmware versions claim to support the fw_reset_handshake > + * but they are buggy. > + */ > + if (IWL_UCODE_MAJOR(mvm->fw->ucode_ver) <= 77) > + trans->conf.fw_reset_handshake = false; > > The if condition is evaluating true on my laptop despite using firmware ty-a0-gf- > a0-89.ucode. So I suspect this is not the correct way to check the firmware > version? Yes, seems like you are right. Thanks for the report! I am attaching a fix candidate, I'd appreciate if you could test it. > > Also comment #21 on bugzilla.kernel.org bug #220600 (which this commit was > supposed to fix) reports the same "Master Disable Timed Out" error (although no > IO_PAGE_FAULTS, probably the bad memory access is not caught without > iommu=strict). > > #regzbot introduced: 0eaa1f245ac03ed0c6394159360532726f666811 [-- Attachment #2: 0001-wifi-iwlwifi-mvm-properly-check-the-FW-version.patch --] [-- Type: application/octet-stream, Size: 1807 bytes --] From 825098f2de2bc63e5ce180213d9fad040f644fb2 Mon Sep 17 00:00:00 2001 From: Miri Korenblit <miriam.rachel.korenblit@intel.com> Date: Sun, 2 Aug 2026 10:16:13 +0300 Subject: [PATCH] wifi: iwlwifi: mvm: properly check the FW version Organization: Intel Israel (74) Limited The mentioned commit aimed to disable fw reset handshake for FWs which their API version is less than 77. But the check is incorrect: in the old format, we should use IWL_UCODE_API, and for the new TLV format - fw.ucode_ver. Since iwlmvm handles only FWs with the new format, we can always use here fw.ucode_ver. Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> --- drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 2297392db955..7e45808da5b3 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c @@ -1412,15 +1412,13 @@ iwl_op_mode_mvm_start(struct iwl_trans *trans, const struct iwl_rf_cfg *cfg, sizeof(mvm->hw->wiphy->fw_version), "%.31s", fw->fw_version); - trans->conf.fw_reset_handshake = - fw_has_capa(&mvm->fw->ucode_capa, - IWL_UCODE_TLV_CAPA_FW_RESET_HANDSHAKE); - - /* Those firmware versions claim to support the fw_reset_handshake + /* Some firmware versions claim to support the fw_reset_handshake * but they are buggy. */ - if (IWL_UCODE_MAJOR(mvm->fw->ucode_ver) <= 77) - trans->conf.fw_reset_handshake = false; + trans->conf.fw_reset_handshake = + fw_has_capa(&mvm->fw->ucode_capa, + IWL_UCODE_TLV_CAPA_FW_RESET_HANDSHAKE) && + mvm->fw->ucode_ver > 77; trans->conf.queue_alloc_cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out 2026-08-02 7:24 ` Korenblit, Miriam Rachel @ 2026-08-04 21:03 ` Chris Bainbridge 2026-10-12 15:52 ` Thorsten Leemhuis 1 sibling, 0 replies; 6+ messages in thread From: Chris Bainbridge @ 2026-08-04 21:03 UTC (permalink / raw) To: Korenblit, Miriam Rachel Cc: Grumbach, Emmanuel, Berg, Johannes, linux-wireless@vger.kernel.org, regressions@lists.linux.dev On Sun, Aug 02, 2026 at 07:24:04AM +0000, Korenblit, Miriam Rachel wrote: > > > > -----Original Message----- > > From: Chris Bainbridge <chris.bainbridge@gmail.com> > > Sent: Friday, July 31, 2026 8:05 PM > > To: Grumbach, Emmanuel <emmanuel.grumbach@intel.com> > > Cc: Berg, Johannes <johannes.berg@intel.com>; Korenblit, Miriam Rachel > > <miriam.rachel.korenblit@intel.com>; linux-wireless@vger.kernel.org; > > regressions@lists.linux.dev > > Subject: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out > > > > Hi, > > > > 0eaa1f245ac0 ("wifi: iwlwifi: mvm: don't support the reset handshake for old > > firmwares") introduced an intermittent boot regression on my laptop: > > > > [ 15.974991] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT > > domain=0x000a address=0xbe9f5000 flags=0x0000] > > [ 15.976184] iwlwifi 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT > > domain=0x000a address=0xbe9f5400 flags=0x0000] > > [ 15.978501] iwlwifi 0000:01:00.0: Master Disable Timed Out, 100 usec > > > > The commit only contains: > > > > + /* Those firmware versions claim to support the fw_reset_handshake > > + * but they are buggy. > > + */ > > + if (IWL_UCODE_MAJOR(mvm->fw->ucode_ver) <= 77) > > + trans->conf.fw_reset_handshake = false; > > > > The if condition is evaluating true on my laptop despite using firmware ty-a0-gf- > > a0-89.ucode. So I suspect this is not the correct way to check the firmware > > version? > > Yes, seems like you are right. > Thanks for the report! > > I am attaching a fix candidate, I'd appreciate if you could test it. Thanks, the fix is working fine. Reported-and-tested-by: Chris Bainbridge <chris.bainbridge@gmail.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out 2026-08-02 7:24 ` Korenblit, Miriam Rachel 2026-08-04 21:03 ` Chris Bainbridge @ 2026-10-12 15:52 ` Thorsten Leemhuis 2026-11-13 8:08 ` HyeongJun An 1 sibling, 1 reply; 6+ messages in thread From: Thorsten Leemhuis @ 2026-10-12 15:52 UTC (permalink / raw) To: Korenblit, Miriam Rachel, Chris Bainbridge, Grumbach, Emmanuel Cc: Berg, Johannes, linux-wireless@vger.kernel.org, regressions@lists.linux.dev On 8/2/26 09:24, Korenblit, Miriam Rachel wrote: >> -----Original Message----- >> From: Chris Bainbridge <chris.bainbridge@gmail.com> >> Sent: Friday, July 31, 2026 8:05 PM >> To: Grumbach, Emmanuel <emmanuel.grumbach@intel.com> >> Cc: Berg, Johannes <johannes.berg@intel.com>; Korenblit, Miriam Rachel >> <miriam.rachel.korenblit@intel.com>; linux-wireless@vger.kernel.org; >> regressions@lists.linux.dev >> Subject: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out >> >> 0eaa1f245ac0 ("wifi: iwlwifi: mvm: don't support the reset handshake for old >> firmwares") introduced an intermittent boot regression on my laptop: >> [...] > > Yes, seems like you are right. > Thanks for the report! > > I am attaching a fix candidate, I'd appreciate if you could test it. Miri, Chris, what happened to this regression fix? From the outside it looks like it fell through the cracks, but well, it's easy to miss something from there, that's why I'm asking. Ciao, Thorsten > From 825098f2de2bc63e5ce180213d9fad040f644fb2 Mon Sep 17 00:00:00 2001 > From: Miri Korenblit <miriam.rachel.korenblit@intel.com> > Date: Sun, 2 Aug 2026 10:16:13 +0300 > Subject: [PATCH] wifi: iwlwifi: mvm: properly check the FW version > Organization: Intel Israel (74) Limited > > The mentioned commit aimed to disable fw reset handshake for FWs which > their API version is less than 77. > But the check is incorrect: in the old format, we should use > IWL_UCODE_API, and for the new TLV format - fw.ucode_ver. > Since iwlmvm handles only FWs with the new format, we can always use > here fw.ucode_ver. > > Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> > [...] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out 2026-10-12 15:52 ` Thorsten Leemhuis @ 2026-11-13 8:08 ` HyeongJun An 2026-11-16 13:09 ` Thorsten Leemhuis 0 siblings, 1 reply; 6+ messages in thread From: HyeongJun An @ 2026-11-13 8:08 UTC (permalink / raw) To: Korenblit, Miriam Rachel Cc: HyeongJun An, Thorsten Leemhuis, Chris Bainbridge, Grumbach, Emmanuel, Berg, Johannes, linux-wireless, regressions Hello Miri, The same happens on a Dell Latitude 9420 (Intel AX210, firmware 89.123cf747.0) with Intel VT-d, on 7.4-rc1. It shows up when iwlwifi stops the device, on driver unload and also once at probe and once on suspend entry: DMAR: [DMA Read NO_PASID] Request device [0000:a4:00.0] fault addr 0xfd8ed000 [fault reason 0x06] PTE Read access is not set iwlwifi 0000:a4:00.0: Master Disable Timed Out, 100 usec ty-a0-gf-a0-89.ucode has the TLV version 0x00000059, so IWL_UCODE_MAJOR() gives 0 and the "<= 77" check turns the reset handshake off. Your "wifi: iwlwifi: mvm: properly check the FW version" fixes the unload case here. Unloading and reloading iwlmvm and iwlwifi 50 times: without the patch: 18 of 50 unloads hit the fault and the timeout with the patch: 0 of 50 Tested-by: HyeongJun An <sammiee5311@gmail.com> I could not find the patch in next-20261112 or in the wireless trees yet. The check also went to 6.18.y as 9dca67624721. I ran these with Claude Code (Claude Opus 5.5). Best regards, HyeongJun An ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out 2026-11-13 8:08 ` HyeongJun An @ 2026-11-16 13:09 ` Thorsten Leemhuis 0 siblings, 0 replies; 6+ messages in thread From: Thorsten Leemhuis @ 2026-11-16 13:09 UTC (permalink / raw) To: HyeongJun An, Korenblit, Miriam Rachel Cc: Chris Bainbridge, Grumbach, Emmanuel, Berg, Johannes, linux-wireless, regressions On 11/13/26 09:08, HyeongJun An wrote: > Hello Miri, > > The same happens on a Dell Latitude 9420 (Intel AX210, firmware > 89.123cf747.0) with Intel VT-d, on 7.4-rc1. It shows up when iwlwifi > stops the device, on driver unload and also once at probe and once on > suspend entry: > > DMAR: [DMA Read NO_PASID] Request device [0000:a4:00.0] fault addr 0xfd8ed000 [fault reason 0x06] PTE Read access is not set > iwlwifi 0000:a4:00.0: Master Disable Timed Out, 100 usec > > ty-a0-gf-a0-89.ucode has the TLV version 0x00000059, so > IWL_UCODE_MAJOR() gives 0 and the "<= 77" check turns the reset > handshake off. > > Your "wifi: iwlwifi: mvm: properly check the FW version" fixes the > unload case here. Unloading and reloading iwlmvm and iwlwifi 50 times: > > without the patch: 18 of 50 unloads hit the fault and the timeout > with the patch: 0 of 50 > > Tested-by: HyeongJun An <sammiee5311@gmail.com> Just to be sure everybody is aware of it: Miri meanwhile afaics submitted the fix here: wifi: iwlwifi: mvm: correctly check the API version https://lore.kernel.org/all/20261114193144.ab54bc9717fc.I8cda260e2ef7aedd790915a17cb6832010f82aa4@changeid/ HyeongJun An: your Tested-by wasn't included, so might be worth resubmitting it there again as a reply. Ciao, Thorsten > I could not find the patch in next-20261112 or in the wireless trees > yet. The check also went to 6.18.y as 9dca67624721. > > I ran these with Claude Code (Claude Opus 5.5). > > Best regards, > HyeongJun An ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-16 13:16 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-31 17:04 [REGRESSION] iwlwifi IO_PAGE_FAULT and Master Disable Timed Out Chris Bainbridge 2026-08-02 7:24 ` Korenblit, Miriam Rachel 2026-08-04 21:03 ` Chris Bainbridge 2026-10-12 15:52 ` Thorsten Leemhuis 2026-11-13 8:08 ` HyeongJun An 2026-11-16 13:09 ` Thorsten Leemhuis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox