* [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
@ 2026-06-10 3:13 Yingying Tang
2026-06-29 2:16 ` Baochen Qiang
` (3 more replies)
0 siblings, 4 replies; 17+ messages in thread
From: Yingying Tang @ 2026-06-10 3:13 UTC (permalink / raw)
To: ath12k; +Cc: linux-wireless, yintang, yingying.tang
For WCN7850, MAC buffer ring size is updated to 2048 in
955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
to increase peak throughput.
But during the RX process, a phenomenon can still be observed where
the throughput drops by about 30% from its peak value and then recovers,
and this behavior repeats during RX.
After increasing MAC buffer ring size to 4096, the data rate drop has
gone.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
---
drivers/net/wireless/ath/ath12k/dp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
index f8cfc7bb29dd..6596089d4168 100644
--- a/drivers/net/wireless/ath/ath12k/dp.h
+++ b/drivers/net/wireless/ath/ath12k/dp.h
@@ -205,7 +205,7 @@ struct ath12k_pdev_dp {
#define DP_REO_CMD_RING_SIZE 256
#define DP_REO_STATUS_RING_SIZE 2048
#define DP_RXDMA_BUF_RING_SIZE 4096
-#define DP_RX_MAC_BUF_RING_SIZE 2048
+#define DP_RX_MAC_BUF_RING_SIZE 4096
#define DP_RXDMA_REFILL_RING_SIZE 2048
#define DP_RXDMA_ERR_DST_RING_SIZE 1024
#define DP_RXDMA_MON_STATUS_RING_SIZE 1024
--
base-commit: ff49eba595df500e4ddccc593088c8a4ab5f2c27
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-06-10 3:13 [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096 Yingying Tang
@ 2026-06-29 2:16 ` Baochen Qiang
2026-06-29 5:40 ` Rameshkumar Sundaram
` (2 subsequent siblings)
3 siblings, 0 replies; 17+ messages in thread
From: Baochen Qiang @ 2026-06-29 2:16 UTC (permalink / raw)
To: Yingying Tang, ath12k; +Cc: linux-wireless, yintang
On 6/10/2026 11:13 AM, Yingying Tang wrote:
> For WCN7850, MAC buffer ring size is updated to 2048 in
> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> to increase peak throughput.
>
> But during the RX process, a phenomenon can still be observed where
> the throughput drops by about 30% from its peak value and then recovers,
> and this behavior repeats during RX.
>
> After increasing MAC buffer ring size to 4096, the data rate drop has
> gone.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>
> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-06-10 3:13 [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096 Yingying Tang
2026-06-29 2:16 ` Baochen Qiang
@ 2026-06-29 5:40 ` Rameshkumar Sundaram
2026-06-30 21:26 ` Jeff Johnson
2026-10-20 8:53 ` Shawn Guo
3 siblings, 0 replies; 17+ messages in thread
From: Rameshkumar Sundaram @ 2026-06-29 5:40 UTC (permalink / raw)
To: Yingying Tang, ath12k; +Cc: linux-wireless, yintang
On 6/10/2026 8:43 AM, Yingying Tang wrote:
> For WCN7850, MAC buffer ring size is updated to 2048 in
> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> to increase peak throughput.
>
> But during the RX process, a phenomenon can still be observed where
> the throughput drops by about 30% from its peak value and then recovers,
> and this behavior repeats during RX.
>
> After increasing MAC buffer ring size to 4096, the data rate drop has
> gone.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>
> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/dp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
> index f8cfc7bb29dd..6596089d4168 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.h
> +++ b/drivers/net/wireless/ath/ath12k/dp.h
> @@ -205,7 +205,7 @@ struct ath12k_pdev_dp {
> #define DP_REO_CMD_RING_SIZE 256
> #define DP_REO_STATUS_RING_SIZE 2048
> #define DP_RXDMA_BUF_RING_SIZE 4096
> -#define DP_RX_MAC_BUF_RING_SIZE 2048
> +#define DP_RX_MAC_BUF_RING_SIZE 4096
> #define DP_RXDMA_REFILL_RING_SIZE 2048
> #define DP_RXDMA_ERR_DST_RING_SIZE 1024
> #define DP_RXDMA_MON_STATUS_RING_SIZE 1024
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-06-10 3:13 [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096 Yingying Tang
2026-06-29 2:16 ` Baochen Qiang
2026-06-29 5:40 ` Rameshkumar Sundaram
@ 2026-06-30 21:26 ` Jeff Johnson
2026-10-20 8:53 ` Shawn Guo
3 siblings, 0 replies; 17+ messages in thread
From: Jeff Johnson @ 2026-06-30 21:26 UTC (permalink / raw)
To: ath12k, Yingying Tang; +Cc: linux-wireless, yintang
On Tue, 09 Jun 2026 20:13:58 -0700, Yingying Tang wrote:
> For WCN7850, MAC buffer ring size is updated to 2048 in
> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> to increase peak throughput.
>
> But during the RX process, a phenomenon can still be observed where
> the throughput drops by about 30% from its peak value and then recovers,
> and this behavior repeats during RX.
>
> [...]
Applied, thanks!
[1/1] wifi: ath12k: change MAC buffer ring size to 4096
commit: 58aeb412495ada7fe5495c7805504d7cf1d45453
Best regards,
--
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-06-10 3:13 [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096 Yingying Tang
` (2 preceding siblings ...)
2026-06-30 21:26 ` Jeff Johnson
@ 2026-10-20 8:53 ` Shawn Guo
2026-10-21 5:08 ` Manivannan Sadhasivam
2026-10-22 2:30 ` Baochen Qiang
3 siblings, 2 replies; 17+ messages in thread
From: Shawn Guo @ 2026-10-20 8:53 UTC (permalink / raw)
To: Yingying Tang, linux-arm-msm; +Cc: ath12k, linux-wireless, yintang
+ linux-arm-msm
On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
> For WCN7850, MAC buffer ring size is updated to 2048 in
> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> to increase peak throughput.
>
> But during the RX process, a phenomenon can still be observed where
> the throughput drops by about 30% from its peak value and then recovers,
> and this behavior repeats during RX.
>
> After increasing MAC buffer ring size to 4096, the data rate drop has
> gone.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>
> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
FYI, in case someone else runs into this: with this change (merged in
v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
working with the older firmware that Debian trixie still ships
(firmware-atheros 20250410-2):
WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Probe and firmware download succeed, but every WMI command times out
once the interface is brought up:
ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
reverting it on v7.3 brings WiFi back with the old firmware.
Unmodified v7.3 works fine after updating to the current linux-firmware
image:
WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
On Debian trixie that one is available from trixie-backports
(firmware-atheros 20260916-1~bpo13+1).
So nothing needs fixing on the driver side. I'm just leaving this here
so that anyone who sees "wmi command ... timeout" on WCN7850 after a
kernel upgrade knows to update the firmware first.
Thanks,
Shawn
> ---
> drivers/net/wireless/ath/ath12k/dp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
> index f8cfc7bb29dd..6596089d4168 100644
> --- a/drivers/net/wireless/ath/ath12k/dp.h
> +++ b/drivers/net/wireless/ath/ath12k/dp.h
> @@ -205,7 +205,7 @@ struct ath12k_pdev_dp {
> #define DP_REO_CMD_RING_SIZE 256
> #define DP_REO_STATUS_RING_SIZE 2048
> #define DP_RXDMA_BUF_RING_SIZE 4096
> -#define DP_RX_MAC_BUF_RING_SIZE 2048
> +#define DP_RX_MAC_BUF_RING_SIZE 4096
> #define DP_RXDMA_REFILL_RING_SIZE 2048
> #define DP_RXDMA_ERR_DST_RING_SIZE 1024
> #define DP_RXDMA_MON_STATUS_RING_SIZE 1024
> --
> base-commit: ff49eba595df500e4ddccc593088c8a4ab5f2c27
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-20 8:53 ` Shawn Guo
@ 2026-10-21 5:08 ` Manivannan Sadhasivam
2026-10-22 2:30 ` Baochen Qiang
1 sibling, 0 replies; 17+ messages in thread
From: Manivannan Sadhasivam @ 2026-10-21 5:08 UTC (permalink / raw)
To: Jeff Johnson
Cc: Shawn Guo, Yingying Tang, linux-arm-msm, ath12k, linux-wireless,
yintang
+ Jeff
On Tue, Oct 20, 2026 at 04:53:03PM +0800, Shawn Guo wrote:
> + linux-arm-msm
>
> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
> > For WCN7850, MAC buffer ring size is updated to 2048 in
> > 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> > to increase peak throughput.
> >
> > But during the RX process, a phenomenon can still be observed where
> > the throughput drops by about 30% from its peak value and then recovers,
> > and this behavior repeats during RX.
> >
> > After increasing MAC buffer ring size to 4096, the data rate drop has
> > gone.
> >
> > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
> >
> > Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
>
> FYI, in case someone else runs into this: with this change (merged in
> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
> working with the older firmware that Debian trixie still ships
> (firmware-atheros 20250410-2):
>
> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Probe and firmware download succeed, but every WMI command times out
> once the interface is brought up:
>
> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
>
> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
> reverting it on v7.3 brings WiFi back with the old firmware.
>
> Unmodified v7.3 works fine after updating to the current linux-firmware
> image:
>
> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> On Debian trixie that one is available from trixie-backports
> (firmware-atheros 20260916-1~bpo13+1).
>
> So nothing needs fixing on the driver side. I'm just leaving this here
> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
> kernel upgrade knows to update the firmware first.
>
Thanks Shawn for reporting this regression!
Jeff, this is unacceptable in two grounds:
1. Driver change *must not* break userspace, in this case the old firmware. The
driver must maintain backwards compatibility even if the data rate drops with
the old firmware. This is the promise, kernel strives to keep up from the
start.
2. The offending patch didn't mention anything about the firmware
incompatibility, which is too bad. How does the users be notified of needing a
firmware update?
So I'd suggest reverting this commit and come up with a new change that
preserves the backwards compatibility with the old firmware while fixing the
throughput issue.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-20 8:53 ` Shawn Guo
2026-10-21 5:08 ` Manivannan Sadhasivam
@ 2026-10-22 2:30 ` Baochen Qiang
2026-10-22 9:20 ` Shawn Guo
1 sibling, 1 reply; 17+ messages in thread
From: Baochen Qiang @ 2026-10-22 2:30 UTC (permalink / raw)
To: Shawn Guo, Yingying Tang, linux-arm-msm; +Cc: ath12k, linux-wireless, yintang
On 10/20/2026 4:53 PM, Shawn Guo wrote:
> + linux-arm-msm
>
> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
>> For WCN7850, MAC buffer ring size is updated to 2048 in
>> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
>> to increase peak throughput.
>>
>> But during the RX process, a phenomenon can still be observed where
>> the throughput drops by about 30% from its peak value and then recovers,
>> and this behavior repeats during RX.
>>
>> After increasing MAC buffer ring size to 4096, the data rate drop has
>> gone.
>>
>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>>
>> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
>
> FYI, in case someone else runs into this: with this change (merged in
> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
> working with the older firmware that Debian trixie still ships
> (firmware-atheros 20250410-2):
>
> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Probe and firmware download succeed, but every WMI command times out
> once the interface is brought up:
>
> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
>
> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
> reverting it on v7.3 brings WiFi back with the old firmware.
>
> Unmodified v7.3 works fine after updating to the current linux-firmware
> image:
>
> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> On Debian trixie that one is available from trixie-backports
> (firmware-atheros 20260916-1~bpo13+1).
>
> So nothing needs fixing on the driver side. I'm just leaving this here
> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
> kernel upgrade knows to update the firmware first.
Hi Shawn, thanks for reporting this. I just had a quick test
WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
(ath-202610191908), everything looks good, simple connection and ping pass, I don't see
any ath12k warning.
The firmware images I am using comes from the first commit adding WCN7850 firmware:
fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
and the md5 values are:
linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
d3750b67b1013fe82358d0538fb131b0 ./amss.bin
c79c410d585360000c0490f16fda43e2 ./board-2.bin
73056f1d2aff886ce9bff313f455e963 ./m3.bin
d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
can you share the md5 values of your images? and have you ever tried the upstream mainline
kernel or the latest ath.git tree?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 2:30 ` Baochen Qiang
@ 2026-10-22 9:20 ` Shawn Guo
2026-10-22 11:00 ` Baochen Qiang
2026-10-22 13:44 ` Shawn Guo
0 siblings, 2 replies; 17+ messages in thread
From: Shawn Guo @ 2026-10-22 9:20 UTC (permalink / raw)
To: Baochen Qiang
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
>
>
> On 10/20/2026 4:53 PM, Shawn Guo wrote:
> > + linux-arm-msm
> >
> > On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
> >> For WCN7850, MAC buffer ring size is updated to 2048 in
> >> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> >> to increase peak throughput.
> >>
> >> But during the RX process, a phenomenon can still be observed where
> >> the throughput drops by about 30% from its peak value and then recovers,
> >> and this behavior repeats during RX.
> >>
> >> After increasing MAC buffer ring size to 4096, the data rate drop has
> >> gone.
> >>
> >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
> >>
> >> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
> >
> > FYI, in case someone else runs into this: with this change (merged in
> > v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
> > working with the older firmware that Debian trixie still ships
> > (firmware-atheros 20250410-2):
> >
> > WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> >
> > Probe and firmware download succeed, but every WMI command times out
> > once the interface is brought up:
> >
> > ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
> > ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
> > ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
> > ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
> >
> > Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
> > reverting it on v7.3 brings WiFi back with the old firmware.
> >
> > Unmodified v7.3 works fine after updating to the current linux-firmware
> > image:
> >
> > WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
> >
> > On Debian trixie that one is available from trixie-backports
> > (firmware-atheros 20260916-1~bpo13+1).
> >
> > So nothing needs fixing on the driver side. I'm just leaving this here
> > so that anyone who sees "wmi command ... timeout" on WCN7850 after a
> > kernel upgrade knows to update the firmware first.
>
> Hi Shawn, thanks for reporting this. I just had a quick test
> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
> (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
> any ath12k warning.
>
> The firmware images I am using comes from the first commit adding WCN7850 firmware:
>
> fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
>
> and the md5 values are:
>
> linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
> d3750b67b1013fe82358d0538fb131b0 ./amss.bin
> c79c410d585360000c0490f16fda43e2 ./board-2.bin
> 73056f1d2aff886ce9bff313f455e963 ./m3.bin
> d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
>
> can you share the md5 values of your images?
Hi Baochen,
Here are md5 values of the old firmware shipped by trixie firmware-atheros
20250410-2.
$ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
73056f1d2aff886ce9bff313f455e963 /lib/firmware/ath12k/WCN7850/hw2.0/m3.bin
> and have you ever tried the upstream mainline
> kernel or the latest ath.git tree?
I'm not sure what you mean by upstream mainline kernel, but v7.3 should
be the mainline kernel released a few days ago.
On the other hand, I just tested ath.git tree at tag ath-202610191908,
and it worked with the old firmware. So it seems there are some gaps
between v7.3 and ath kernel.
Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 9:20 ` Shawn Guo
@ 2026-10-22 11:00 ` Baochen Qiang
2026-10-22 13:38 ` Shawn Guo
2026-10-22 13:44 ` Shawn Guo
1 sibling, 1 reply; 17+ messages in thread
From: Baochen Qiang @ 2026-10-22 11:00 UTC (permalink / raw)
To: Shawn Guo; +Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On 10/22/2026 5:20 PM, Shawn Guo wrote:
> On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
>>
>>
>> On 10/20/2026 4:53 PM, Shawn Guo wrote:
>>> + linux-arm-msm
>>>
>>> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
>>>> For WCN7850, MAC buffer ring size is updated to 2048 in
>>>> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
>>>> to increase peak throughput.
>>>>
>>>> But during the RX process, a phenomenon can still be observed where
>>>> the throughput drops by about 30% from its peak value and then recovers,
>>>> and this behavior repeats during RX.
>>>>
>>>> After increasing MAC buffer ring size to 4096, the data rate drop has
>>>> gone.
>>>>
>>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>>>>
>>>> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
>>>
>>> FYI, in case someone else runs into this: with this change (merged in
>>> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
>>> working with the older firmware that Debian trixie still ships
>>> (firmware-atheros 20250410-2):
>>>
>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>
>>> Probe and firmware download succeed, but every WMI command times out
>>> once the interface is brought up:
>>>
>>> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
>>> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
>>> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
>>> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
>>>
>>> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
>>> reverting it on v7.3 brings WiFi back with the old firmware.
>>>
>>> Unmodified v7.3 works fine after updating to the current linux-firmware
>>> image:
>>>
>>> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>>>
>>> On Debian trixie that one is available from trixie-backports
>>> (firmware-atheros 20260916-1~bpo13+1).
>>>
>>> So nothing needs fixing on the driver side. I'm just leaving this here
>>> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
>>> kernel upgrade knows to update the firmware first.
>>
>> Hi Shawn, thanks for reporting this. I just had a quick test
>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
>> (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
>> any ath12k warning.
>>
>> The firmware images I am using comes from the first commit adding WCN7850 firmware:
>>
>> fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
>>
>> and the md5 values are:
>>
>> linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
>> d3750b67b1013fe82358d0538fb131b0 ./amss.bin
>> c79c410d585360000c0490f16fda43e2 ./board-2.bin
>> 73056f1d2aff886ce9bff313f455e963 ./m3.bin
>> d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
>>
>> can you share the md5 values of your images?
>
> Hi Baochen,
>
> Here are md5 values of the old firmware shipped by trixie firmware-atheros
> 20250410-2.
>
> $ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
> d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
> 5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
this is different from mine, can you try mine?
> 73056f1d2aff886ce9bff313f455e963 /lib/firmware/ath12k/WCN7850/hw2.0/m3.bin
>
>> and have you ever tried the upstream mainline
>> kernel or the latest ath.git tree?
>
> I'm not sure what you mean by upstream mainline kernel, but v7.3 should
I mean Linus's tree
> be the mainline kernel released a few days ago.
>
> On the other hand, I just tested ath.git tree at tag ath-202610191908,
> and it worked with the old firmware. So it seems there are some gaps
> between v7.3 and ath kernel.
can you share the exact tag of v7.3 kernel? is it just below tag?
commit c03c1a14507dfaf8b856c2608f9ac216021fc222 (tag: v7.3)
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun Oct 18 13:14:58 2026 -1000
Linux 7.3
diff --git a/Makefile b/Makefile
index 0dc1a9f4e63e..c61ea07ee505 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
VERSION = 7
PATCHLEVEL = 3
SUBLEVEL = 0
-EXTRAVERSION = -rc7
+EXTRAVERSION =
NAME = Baby Opossum Posse
# *DOCUMENTATION*
>
> Shawn
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 11:00 ` Baochen Qiang
@ 2026-10-22 13:38 ` Shawn Guo
2026-10-23 1:59 ` Baochen Qiang
0 siblings, 1 reply; 17+ messages in thread
From: Shawn Guo @ 2026-10-22 13:38 UTC (permalink / raw)
To: Baochen Qiang
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On Thu, Oct 22, 2026 at 07:00:31PM +0800, Baochen Qiang wrote:
>
>
> On 10/22/2026 5:20 PM, Shawn Guo wrote:
> > On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
> >>
> >>
> >> On 10/20/2026 4:53 PM, Shawn Guo wrote:
> >>> + linux-arm-msm
> >>>
> >>> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
> >>>> For WCN7850, MAC buffer ring size is updated to 2048 in
> >>>> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> >>>> to increase peak throughput.
> >>>>
> >>>> But during the RX process, a phenomenon can still be observed where
> >>>> the throughput drops by about 30% from its peak value and then recovers,
> >>>> and this behavior repeats during RX.
> >>>>
> >>>> After increasing MAC buffer ring size to 4096, the data rate drop has
> >>>> gone.
> >>>>
> >>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
> >>>>
> >>>> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
> >>>
> >>> FYI, in case someone else runs into this: with this change (merged in
> >>> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
> >>> working with the older firmware that Debian trixie still ships
> >>> (firmware-atheros 20250410-2):
> >>>
> >>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> >>>
> >>> Probe and firmware download succeed, but every WMI command times out
> >>> once the interface is brought up:
> >>>
> >>> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
> >>> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
> >>> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
> >>> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
> >>>
> >>> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
> >>> reverting it on v7.3 brings WiFi back with the old firmware.
> >>>
> >>> Unmodified v7.3 works fine after updating to the current linux-firmware
> >>> image:
> >>>
> >>> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
> >>>
> >>> On Debian trixie that one is available from trixie-backports
> >>> (firmware-atheros 20260916-1~bpo13+1).
> >>>
> >>> So nothing needs fixing on the driver side. I'm just leaving this here
> >>> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
> >>> kernel upgrade knows to update the firmware first.
> >>
> >> Hi Shawn, thanks for reporting this. I just had a quick test
> >> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
> >> (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
> >> any ath12k warning.
> >>
> >> The firmware images I am using comes from the first commit adding WCN7850 firmware:
> >>
> >> fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
> >>
> >> and the md5 values are:
> >>
> >> linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
> >> d3750b67b1013fe82358d0538fb131b0 ./amss.bin
> >> c79c410d585360000c0490f16fda43e2 ./board-2.bin
> >> 73056f1d2aff886ce9bff313f455e963 ./m3.bin
> >> d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
> >>
> >> can you share the md5 values of your images?
> >
> > Hi Baochen,
> >
> > Here are md5 values of the old firmware shipped by trixie firmware-atheros
> > 20250410-2.
> >
> > $ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
> > d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
> > 5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
>
> this is different from mine, can you try mine?
Are you sure this board file works for my Lenovo Yoga Slim 7x laptop?
>
> > 73056f1d2aff886ce9bff313f455e963 /lib/firmware/ath12k/WCN7850/hw2.0/m3.bin
> >
> >> and have you ever tried the upstream mainline
> >> kernel or the latest ath.git tree?
> >
> > I'm not sure what you mean by upstream mainline kernel, but v7.3 should
>
> I mean Linus's tree
>
> > be the mainline kernel released a few days ago.
> >
> > On the other hand, I just tested ath.git tree at tag ath-202610191908,
> > and it worked with the old firmware. So it seems there are some gaps
> > between v7.3 and ath kernel.
>
> can you share the exact tag of v7.3 kernel? is it just below tag?
Yes, it is.
Shawn
>
> commit c03c1a14507dfaf8b856c2608f9ac216021fc222 (tag: v7.3)
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sun Oct 18 13:14:58 2026 -1000
>
> Linux 7.3
>
> diff --git a/Makefile b/Makefile
> index 0dc1a9f4e63e..c61ea07ee505 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2,7 +2,7 @@
> VERSION = 7
> PATCHLEVEL = 3
> SUBLEVEL = 0
> -EXTRAVERSION = -rc7
> +EXTRAVERSION =
> NAME = Baby Opossum Posse
>
> # *DOCUMENTATION*
>
>
> >
> > Shawn
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 9:20 ` Shawn Guo
2026-10-22 11:00 ` Baochen Qiang
@ 2026-10-22 13:44 ` Shawn Guo
2026-10-23 2:13 ` Baochen Qiang
1 sibling, 1 reply; 17+ messages in thread
From: Shawn Guo @ 2026-10-22 13:44 UTC (permalink / raw)
To: Baochen Qiang
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On Thu, Oct 22, 2026 at 05:20:56PM +0800, Shawn Guo wrote:
> On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
> >
> >
> > On 10/20/2026 4:53 PM, Shawn Guo wrote:
> > > + linux-arm-msm
> > >
> > > On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
> > >> For WCN7850, MAC buffer ring size is updated to 2048 in
> > >> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
> > >> to increase peak throughput.
> > >>
> > >> But during the RX process, a phenomenon can still be observed where
> > >> the throughput drops by about 30% from its peak value and then recovers,
> > >> and this behavior repeats during RX.
> > >>
> > >> After increasing MAC buffer ring size to 4096, the data rate drop has
> > >> gone.
> > >>
> > >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
> > >>
> > >> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
> > >
> > > FYI, in case someone else runs into this: with this change (merged in
> > > v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
> > > working with the older firmware that Debian trixie still ships
> > > (firmware-atheros 20250410-2):
> > >
> > > WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> > >
> > > Probe and firmware download succeed, but every WMI command times out
> > > once the interface is brought up:
> > >
> > > ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
> > > ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
> > > ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
> > > ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
> > >
> > > Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
> > > reverting it on v7.3 brings WiFi back with the old firmware.
> > >
> > > Unmodified v7.3 works fine after updating to the current linux-firmware
> > > image:
> > >
> > > WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
> > >
> > > On Debian trixie that one is available from trixie-backports
> > > (firmware-atheros 20260916-1~bpo13+1).
> > >
> > > So nothing needs fixing on the driver side. I'm just leaving this here
> > > so that anyone who sees "wmi command ... timeout" on WCN7850 after a
> > > kernel upgrade knows to update the firmware first.
> >
> > Hi Shawn, thanks for reporting this. I just had a quick test
> > WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
> > (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
> > any ath12k warning.
> >
> > The firmware images I am using comes from the first commit adding WCN7850 firmware:
> >
> > fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
> >
> > and the md5 values are:
> >
> > linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
> > d3750b67b1013fe82358d0538fb131b0 ./amss.bin
> > c79c410d585360000c0490f16fda43e2 ./board-2.bin
> > 73056f1d2aff886ce9bff313f455e963 ./m3.bin
> > d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
> >
> > can you share the md5 values of your images?
>
> Hi Baochen,
>
> Here are md5 values of the old firmware shipped by trixie firmware-atheros
> 20250410-2.
>
> $ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
> d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
> 5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
> 73056f1d2aff886ce9bff313f455e963 /lib/firmware/ath12k/WCN7850/hw2.0/m3.bin
>
> > and have you ever tried the upstream mainline
> > kernel or the latest ath.git tree?
>
> I'm not sure what you mean by upstream mainline kernel, but v7.3 should
> be the mainline kernel released a few days ago.
>
> On the other hand, I just tested ath.git tree at tag ath-202610191908,
> and it worked with the old firmware. So it seems there are some gaps
> between v7.3 and ath kernel.
I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
the ath tag (working). It lands on:
15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
The previous commit, 643f0bf93617, still has 4096 entries and is broken.
15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
and works.
Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 13:38 ` Shawn Guo
@ 2026-10-23 1:59 ` Baochen Qiang
0 siblings, 0 replies; 17+ messages in thread
From: Baochen Qiang @ 2026-10-23 1:59 UTC (permalink / raw)
To: Shawn Guo; +Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On 10/22/2026 9:38 PM, Shawn Guo wrote:
> On Thu, Oct 22, 2026 at 07:00:31PM +0800, Baochen Qiang wrote:
>>
>>
>> On 10/22/2026 5:20 PM, Shawn Guo wrote:
>>> On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
>>>>
>>>>
>>>> On 10/20/2026 4:53 PM, Shawn Guo wrote:
>>>>> + linux-arm-msm
>>>>>
>>>>> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
>>>>>> For WCN7850, MAC buffer ring size is updated to 2048 in
>>>>>> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
>>>>>> to increase peak throughput.
>>>>>>
>>>>>> But during the RX process, a phenomenon can still be observed where
>>>>>> the throughput drops by about 30% from its peak value and then recovers,
>>>>>> and this behavior repeats during RX.
>>>>>>
>>>>>> After increasing MAC buffer ring size to 4096, the data rate drop has
>>>>>> gone.
>>>>>>
>>>>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>>>>>>
>>>>>> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
>>>>>
>>>>> FYI, in case someone else runs into this: with this change (merged in
>>>>> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
>>>>> working with the older firmware that Debian trixie still ships
>>>>> (firmware-atheros 20250410-2):
>>>>>
>>>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>>>
>>>>> Probe and firmware download succeed, but every WMI command times out
>>>>> once the interface is brought up:
>>>>>
>>>>> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
>>>>> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
>>>>> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
>>>>> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
>>>>>
>>>>> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
>>>>> reverting it on v7.3 brings WiFi back with the old firmware.
>>>>>
>>>>> Unmodified v7.3 works fine after updating to the current linux-firmware
>>>>> image:
>>>>>
>>>>> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>>>>>
>>>>> On Debian trixie that one is available from trixie-backports
>>>>> (firmware-atheros 20260916-1~bpo13+1).
>>>>>
>>>>> So nothing needs fixing on the driver side. I'm just leaving this here
>>>>> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
>>>>> kernel upgrade knows to update the firmware first.
>>>>
>>>> Hi Shawn, thanks for reporting this. I just had a quick test
>>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
>>>> (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
>>>> any ath12k warning.
>>>>
>>>> The firmware images I am using comes from the first commit adding WCN7850 firmware:
>>>>
>>>> fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
>>>>
>>>> and the md5 values are:
>>>>
>>>> linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
>>>> d3750b67b1013fe82358d0538fb131b0 ./amss.bin
>>>> c79c410d585360000c0490f16fda43e2 ./board-2.bin
>>>> 73056f1d2aff886ce9bff313f455e963 ./m3.bin
>>>> d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
>>>>
>>>> can you share the md5 values of your images?
>>>
>>> Hi Baochen,
>>>
>>> Here are md5 values of the old firmware shipped by trixie firmware-atheros
>>> 20250410-2.
>>>
>>> $ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
>>> d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
>>> 5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
>>
>> this is different from mine, can you try mine?
>
> Are you sure this board file works for my Lenovo Yoga Slim 7x laptop?
actually not, my board-2.bin may lack the BDF for your machine
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-22 13:44 ` Shawn Guo
@ 2026-10-23 2:13 ` Baochen Qiang
2026-10-23 2:43 ` Shawn Guo
0 siblings, 1 reply; 17+ messages in thread
From: Baochen Qiang @ 2026-10-23 2:13 UTC (permalink / raw)
To: Shawn Guo; +Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On 10/22/2026 9:44 PM, Shawn Guo wrote:
> On Thu, Oct 22, 2026 at 05:20:56PM +0800, Shawn Guo wrote:
>> On Thu, Oct 22, 2026 at 10:30:45AM +0800, Baochen Qiang wrote:
>>>
>>>
>>> On 10/20/2026 4:53 PM, Shawn Guo wrote:
>>>> + linux-arm-msm
>>>>
>>>> On Tue, Jun 09, 2026 at 08:13:58PM -0700, Yingying Tang wrote:
>>>>> For WCN7850, MAC buffer ring size is updated to 2048 in
>>>>> 955df16f2a4c3 ("wifi: ath12k: change MAC buffer ring size to 2048")
>>>>> to increase peak throughput.
>>>>>
>>>>> But during the RX process, a phenomenon can still be observed where
>>>>> the throughput drops by about 30% from its peak value and then recovers,
>>>>> and this behavior repeats during RX.
>>>>>
>>>>> After increasing MAC buffer ring size to 4096, the data rate drop has
>>>>> gone.
>>>>>
>>>>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
>>>>>
>>>>> Signed-off-by: Yingying Tang <yingying.tang@oss.qualcomm.com>
>>>>
>>>> FYI, in case someone else runs into this: with this change (merged in
>>>> v7.3), WiFi on my Lenovo Yoga Slim 7x (X1E80100, WCN7850 hw2.0) stopped
>>>> working with the older firmware that Debian trixie still ships
>>>> (firmware-atheros 20250410-2):
>>>>
>>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>>>>
>>>> Probe and firmware download succeed, but every WMI command times out
>>>> once the interface is brought up:
>>>>
>>>> ath12k_wifi7_pci 0004:01:00.0: wmi command 16387 timeout
>>>> ath12k_wifi7_pci 0004:01:00.0: failed to send WMI_PDEV_SET_PARAM cmd
>>>> ath12k_wifi7_pci 0004:01:00.0: failed to enable PMF QOS: -11
>>>> ath12k_wifi7_pci 0004:01:00.0: fail to start mac operations in pdev idx 0 ret -11
>>>>
>>>> Bisecting ath12k between v7.2 and v7.3 lands on this commit, and
>>>> reverting it on v7.3 brings WiFi back with the old firmware.
>>>>
>>>> Unmodified v7.3 works fine after updating to the current linux-firmware
>>>> image:
>>>>
>>>> WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>>>>
>>>> On Debian trixie that one is available from trixie-backports
>>>> (firmware-atheros 20260916-1~bpo13+1).
>>>>
>>>> So nothing needs fixing on the driver side. I'm just leaving this here
>>>> so that anyone who sees "wmi command ... timeout" on WCN7850 after a
>>>> kernel upgrade knows to update the firmware first.
>>>
>>> Hi Shawn, thanks for reporting this. I just had a quick test
>>> WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 with the latest ath tree
>>> (ath-202610191908), everything looks good, simple connection and ping pass, I don't see
>>> any ath12k warning.
>>>
>>> The firmware images I am using comes from the first commit adding WCN7850 firmware:
>>>
>>> fb04a7f4b750 ("ath12k: add new driver and firmware for WCN7850")
>>>
>>> and the md5 values are:
>>>
>>> linux-firmware/ath12k/WCN7850/hw2.0$ md5sum ./*
>>> d3750b67b1013fe82358d0538fb131b0 ./amss.bin
>>> c79c410d585360000c0490f16fda43e2 ./board-2.bin
>>> 73056f1d2aff886ce9bff313f455e963 ./m3.bin
>>> d0ee61498bf1a205147cdbcf645391e7 ./Notice.txt
>>>
>>> can you share the md5 values of your images?
>>
>> Hi Baochen,
>>
>> Here are md5 values of the old firmware shipped by trixie firmware-atheros
>> 20250410-2.
>>
>> $ md5sum /lib/firmware/ath12k/WCN7850/hw2.0/*
>> d3750b67b1013fe82358d0538fb131b0 /lib/firmware/ath12k/WCN7850/hw2.0/amss.bin
>> 5dacdfbe6c3c25d9e0605be8a9f1f6e4 /lib/firmware/ath12k/WCN7850/hw2.0/board-2.bin
>> 73056f1d2aff886ce9bff313f455e963 /lib/firmware/ath12k/WCN7850/hw2.0/m3.bin
>>
>>> and have you ever tried the upstream mainline
>>> kernel or the latest ath.git tree?
>>
>> I'm not sure what you mean by upstream mainline kernel, but v7.3 should
>> be the mainline kernel released a few days ago.
>>
>> On the other hand, I just tested ath.git tree at tag ath-202610191908,
>> and it worked with the old firmware. So it seems there are some gaps
>> between v7.3 and ath kernel.
>
> I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
> the ath tag (working). It lands on:
>
> 15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
>
> The previous commit, 643f0bf93617, still has 4096 entries and is broken.
> 15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
> and works.
thanks for sharing this. I can repro it using the 481 firmware once get 15f7603b69a8 reverted.
so the rule here seems that rxdma_buf_ring_size must be at least twice as large as
DP_RX_MAC_BUF_RING_SIZE (I also tries four times large, it works). This rule looks
reasonable to me, since WCN7850 get twos HW MACs and its firmware setups rx_mac_buf ring
for each, and each ring fills itself using the buffers all from the single RXDMA buffer ring.
maybe I should submit a patch mandate this rule.
>
> Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-23 2:13 ` Baochen Qiang
@ 2026-10-23 2:43 ` Shawn Guo
2026-10-23 3:13 ` Baochen Qiang
0 siblings, 1 reply; 17+ messages in thread
From: Shawn Guo @ 2026-10-23 2:43 UTC (permalink / raw)
To: Baochen Qiang
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On Fri, Oct 23, 2026 at 10:13:18AM +0800, Baochen Qiang wrote:
> On 10/22/2026 9:44 PM, Shawn Guo wrote:
[...]
> > I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
> > the ath tag (working). It lands on:
> >
> > 15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
> >
> > The previous commit, 643f0bf93617, still has 4096 entries and is broken.
> > 15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
> > and works.
>
> thanks for sharing this. I can repro it using the 481 firmware once get 15f7603b69a8 reverted.
Thanks for confirming!
> so the rule here seems that rxdma_buf_ring_size must be at least twice as large as
> DP_RX_MAC_BUF_RING_SIZE (I also tries four times large, it works). This rule looks
> reasonable to me, since WCN7850 get twos HW MACs and its firmware setups rx_mac_buf ring
> for each, and each ring fills itself using the buffers all from the single RXDMA buffer ring.
>
> maybe I should submit a patch mandate this rule.
I'm more concerned about how we would fix the regression for 7.3.x stable
kernel.
Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-23 2:43 ` Shawn Guo
@ 2026-10-23 3:13 ` Baochen Qiang
2026-10-23 3:44 ` Shawn Guo
0 siblings, 1 reply; 17+ messages in thread
From: Baochen Qiang @ 2026-10-23 3:13 UTC (permalink / raw)
To: Shawn Guo; +Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On 10/23/2026 10:43 AM, Shawn Guo wrote:
> On Fri, Oct 23, 2026 at 10:13:18AM +0800, Baochen Qiang wrote:
>> On 10/22/2026 9:44 PM, Shawn Guo wrote:
>
> [...]
>
>>> I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
>>> the ath tag (working). It lands on:
>>>
>>> 15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
>>>
>>> The previous commit, 643f0bf93617, still has 4096 entries and is broken.
>>> 15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
>>> and works.
>>
>> thanks for sharing this. I can repro it using the 481 firmware once get 15f7603b69a8 reverted.
>
> Thanks for confirming!
>
>> so the rule here seems that rxdma_buf_ring_size must be at least twice as large as
>> DP_RX_MAC_BUF_RING_SIZE (I also tries four times large, it works). This rule looks
>> reasonable to me, since WCN7850 get twos HW MACs and its firmware setups rx_mac_buf ring
>> for each, and each ring fills itself using the buffers all from the single RXDMA buffer ring.
>>
>> maybe I should submit a patch mandate this rule.
>
> I'm more concerned about how we would fix the regression for 7.3.x stable
> kernel.
we can try to ask stable team to backport 15f7603b69a8 ?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-23 3:13 ` Baochen Qiang
@ 2026-10-23 3:44 ` Shawn Guo
2026-10-23 4:42 ` Baochen Qiang
0 siblings, 1 reply; 17+ messages in thread
From: Shawn Guo @ 2026-10-23 3:44 UTC (permalink / raw)
To: Baochen Qiang, Jeff Johnson
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
+ Jeff
On Fri, Oct 23, 2026 at 11:13:56AM +0800, Baochen Qiang wrote:
>
>
> On 10/23/2026 10:43 AM, Shawn Guo wrote:
> > On Fri, Oct 23, 2026 at 10:13:18AM +0800, Baochen Qiang wrote:
> >> On 10/22/2026 9:44 PM, Shawn Guo wrote:
> >
> > [...]
> >
> >>> I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
> >>> the ath tag (working). It lands on:
> >>>
> >>> 15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
> >>>
> >>> The previous commit, 643f0bf93617, still has 4096 entries and is broken.
> >>> 15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
> >>> and works.
> >>
> >> thanks for sharing this. I can repro it using the 481 firmware once get 15f7603b69a8 reverted.
> >
> > Thanks for confirming!
> >
> >> so the rule here seems that rxdma_buf_ring_size must be at least twice as large as
> >> DP_RX_MAC_BUF_RING_SIZE (I also tries four times large, it works). This rule looks
> >> reasonable to me, since WCN7850 get twos HW MACs and its firmware setups rx_mac_buf ring
> >> for each, and each ring fills itself using the buffers all from the single RXDMA buffer ring.
> >>
> >> maybe I should submit a patch mandate this rule.
> >
> > I'm more concerned about how we would fix the regression for 7.3.x stable
> > kernel.
>
> we can try to ask stable team to backport 15f7603b69a8 ?
Ok, I can do the backport after the commit lands mainline, assuming it's
part of Jeff's PR for 7.4 merge window.
Shawn
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096
2026-10-23 3:44 ` Shawn Guo
@ 2026-10-23 4:42 ` Baochen Qiang
0 siblings, 0 replies; 17+ messages in thread
From: Baochen Qiang @ 2026-10-23 4:42 UTC (permalink / raw)
To: Shawn Guo, Jeff Johnson
Cc: Yingying Tang, linux-arm-msm, ath12k, linux-wireless, yintang
On 10/23/2026 11:44 AM, Shawn Guo wrote:
> + Jeff
>
> On Fri, Oct 23, 2026 at 11:13:56AM +0800, Baochen Qiang wrote:
>>
>>
>> On 10/23/2026 10:43 AM, Shawn Guo wrote:
>>> On Fri, Oct 23, 2026 at 10:13:18AM +0800, Baochen Qiang wrote:
>>>> On 10/22/2026 9:44 PM, Shawn Guo wrote:
>>>
>>> [...]
>>>
>>>>> I bisected drivers/net/wireless/ath/ath12k between v7.3 (broken) and
>>>>> the ath tag (working). It lands on:
>>>>>
>>>>> 15f7603b69a8 ("wifi: ath12k: Increase RXDMA buffer ring size for default memory profile")
>>>>>
>>>>> The previous commit, 643f0bf93617, still has 4096 entries and is broken.
>>>>> 15f7603b69a8 changes one line, .rxdma_buf_ring_size from 4096 to 8192,
>>>>> and works.
>>>>
>>>> thanks for sharing this. I can repro it using the 481 firmware once get 15f7603b69a8 reverted.
>>>
>>> Thanks for confirming!
>>>
>>>> so the rule here seems that rxdma_buf_ring_size must be at least twice as large as
>>>> DP_RX_MAC_BUF_RING_SIZE (I also tries four times large, it works). This rule looks
>>>> reasonable to me, since WCN7850 get twos HW MACs and its firmware setups rx_mac_buf ring
>>>> for each, and each ring fills itself using the buffers all from the single RXDMA buffer ring.
>>>>
>>>> maybe I should submit a patch mandate this rule.
>>>
>>> I'm more concerned about how we would fix the regression for 7.3.x stable
>>> kernel.
>>
>> we can try to ask stable team to backport 15f7603b69a8 ?
>
> Ok, I can do the backport after the commit lands mainline, assuming it's
> part of Jeff's PR for 7.4 merge window.
>
> Shawn
Thank you Shawn!
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2026-10-23 4:42 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 3:13 [PATCH ath-next] wifi: ath12k: change MAC buffer ring size to 4096 Yingying Tang
2026-06-29 2:16 ` Baochen Qiang
2026-06-29 5:40 ` Rameshkumar Sundaram
2026-06-30 21:26 ` Jeff Johnson
2026-10-20 8:53 ` Shawn Guo
2026-10-21 5:08 ` Manivannan Sadhasivam
2026-10-22 2:30 ` Baochen Qiang
2026-10-22 9:20 ` Shawn Guo
2026-10-22 11:00 ` Baochen Qiang
2026-10-22 13:38 ` Shawn Guo
2026-10-23 1:59 ` Baochen Qiang
2026-10-22 13:44 ` Shawn Guo
2026-10-23 2:13 ` Baochen Qiang
2026-10-23 2:43 ` Shawn Guo
2026-10-23 3:13 ` Baochen Qiang
2026-10-23 3:44 ` Shawn Guo
2026-10-23 4:42 ` Baochen Qiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox