From: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
To: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Cc: Jeff Johnson <jjohnson@kernel.org>, Kalle Valo <kvalo@kernel.org>,
Baochen Qiang <quic_bqiang@quicinc.com>,
P Praneesh <quic_ppranees@quicinc.com>,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org
Subject: Re: [PATCH ath-current] wifi: ath12k: fix DMA direction for re-injected Rx buffers
Date: Fri, 23 Oct 2026 11:27:27 +0200 [thread overview]
Message-ID: <atsof77Ru3vW4l0s@lore-desk> (raw)
In-Reply-To: <41eff135-80fe-4820-b9c4-48705159a013@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
> On 10/17/2026 5:16 PM, Lorenzo Bianconi wrote:
>
> > --- a/drivers/net/wireless/ath/ath12k/core.h
> > +++ b/drivers/net/wireless/ath/ath12k/core.h
> > @@ -149,6 +149,7 @@ struct ath12k_skb_rxcb {
> > u8 tid;
> > u16 peer_id;
> > bool is_end_of_ppdu;
> > + bool reinjected;
>
> rxcb->is_frag already identifies a reinjected frame, can we use it instead?
Hi Baochen,
I agree, we can use is_frag and drop reinjected field. I will fix it in v2.
>
>
> > diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c
> b/drivers/net/wireless/ath/ath12k/dp_rx.c
> > index 8fa0e90b4531..0003cc5a3720 100644
> > --- a/drivers/net/wireless/ath/ath12k/dp_rx.c
> > +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
> > @@ -138,6 +138,7 @@ int ath12k_dp_rx_bufs_replenish(struct ath12k_dp *dp,
> > if (!rx_desc)
> > goto fail_dma_unmap;
> >
> > + ATH12K_SKB_RXCB(skb)->reinjected = false;
>
> These skbs come straight from dev_alloc_skb(), which clears CB area inside, so this is not
> required. But for readability purpose I have no objection to keep it.
ack, I will drop it in v2.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-10-23 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 9:16 [PATCH ath-current] wifi: ath12k: fix DMA direction for re-injected Rx buffers Lorenzo Bianconi
2026-10-23 8:07 ` Baochen Qiang
2026-10-23 9:27 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atsof77Ru3vW4l0s@lore-desk \
--to=lorenzo.bianconi@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_ppranees@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox