From: "Rafał Miłecki" <zajec5@gmail.com>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: Michael Buesch <mb@bu3sch.de>,
bcm43xx-dev@lists.berlios.de,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/7] b43: N-PHY: implement TX PHY cleanup and setup
Date: Sun, 17 Jan 2010 17:48:34 +0100 [thread overview]
Message-ID: <b170af451001170848s27dab1acmac125287dacbb3ae@mail.gmail.com> (raw)
In-Reply-To: <69e28c911001170844m2dd5beb9j6ebca9292f41f7ce@mail.gmail.com>
2010/1/17 Gábor Stefanik <netrolller.3d@gmail.com>:
> On Sun, Jan 17, 2010 at 5:41 PM, Michael Buesch <mb@bu3sch.de> wrote:
>> On Sunday 17 January 2010 17:37:29 Gábor Stefanik wrote:
>>> While you are at it, why aren't you programming these table writes?
>>> The table handling functions are AFAIK already in place...
>>
>> Because we like small patches.
>> Please do _not_ increase the patchsize.
>
> They do not increase patch size - table reads/writes are one-line (in
> fact, they are shorter than the placeholder comments in place of
> them).
Well, I just started implementing code without understanding of
tables... and got stick in implementing functions. There are some
"crazy" IDs, offsets and it's not only writing but also some
mysterious table reading... You know, it just sounds scary ;)
I'll have to finally read specs/existing code for tables, understand
it and implement.
--
Rafał
prev parent reply other threads:[~2010-01-17 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 12:03 [PATCH 2/7] b43: N-PHY: implement TX PHY cleanup and setup Rafał Miłecki
2010-01-17 16:37 ` Gábor Stefanik
2010-01-17 16:41 ` Michael Buesch
2010-01-17 16:44 ` Gábor Stefanik
2010-01-17 16:48 ` Rafał Miłecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b170af451001170848s27dab1acmac125287dacbb3ae@mail.gmail.com \
--to=zajec5@gmail.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox