Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Help with encrypting PMF management frames
Date: Thu, 6 Jun 2019 15:12:39 -0700	[thread overview]
Message-ID: <bc99ae7e-ace3-94a4-03da-77db3698aadd@candelatech.com> (raw)
In-Reply-To: <fe571fe9-d5e5-38b8-5afa-2ba4fbb51f67@candelatech.com>

On 6/6/19 9:54 AM, Ben Greear wrote:
> Hello,
> 
> My variant of ath10k uses the normal 'native-wifi' tx path for management frames.
> Internally in the firmware, it seems that the management TID is flagged to expect
> raw frames, and I think that is why I see Action frames on-air that are not actually
> encrypted but which have some space added to their packet that should be filled in by
> the hw-crypt engine.
> 
> Is there a way to get mac80211 to software-crypt just management-tid PMF frames?
> 
> So far, I have not been able to find the correct place in the tx logic of
> mac80211...
> 
> Thanks,
> Ben
> 

Ok, I found the issue.  It seems the ath10k hardware refuses to encrypt
management frames unless they are sent in RAW mode (nwifi mgt frames are sent
w/out encryption for whatever reason).

So, the fix is in the ath10k driver (and just my driver I suppose, stock
driver uses a different API for mgt frames that eventually is raw-tx down in
the firmware).

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


      reply	other threads:[~2019-06-06 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-06 16:54 Help with encrypting PMF management frames Ben Greear
2019-06-06 22:12 ` Ben Greear [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc99ae7e-ace3-94a4-03da-77db3698aadd@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox