From: Christian Lamparter <chunkeey@gmail.com>
To: Linux Wireless <linux-wireless@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Cc: Wu Yunchuan <yunchuan@nfschina.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions
Date: Fri, 29 Sep 2023 09:23:26 +0200 [thread overview]
Message-ID: <c5611be9-ef4d-4e49-84de-7ce893e3c73c@gmail.com> (raw)
In-Reply-To: <d41d0c98-82ef-40f6-8c5c-68a94b5a4655@kadam.mountain>
On 9/29/23 08:49, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 09:43:03AM +0300, Dan Carpenter wrote:
>> I don't know anything which would warn about this. Generally, in the
>> kernel we try to avoid casts but perhaps there was a static checker
>> which likes casts?
>>
>> If removing these sorts of casts were an issue we would have known by
>> now.
>
> Thinking about it more, if this caused a static checker warning then
> probably every kmalloc() would need a cast.
Oh, we do have our fair share of static checker noise in:
drivers/net/wireless/ath/ (this is where carl9170 is located)!
I would like to take the chance to again point to this beauty:
<https://lore.kernel.org/linux-wireless/TYAP286MB03154F9AAFD4C35BEEDE4A99BC4CA@TYAP286MB0315.JPNP286.PROD.OUTLOOK.COM/T/#mf1b8919a000fe661803c17073f48b3c410888541>
@Dan, @Jeff can you please comment on that too?
As for this patch: If Wu ran some compiles with
what GCC version he has available and nothing turned up:
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Regards,
Christian
next prev parent reply other threads:[~2023-09-29 7:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:49 [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Wu Yunchuan
2023-09-20 18:15 ` Jeff Johnson
2023-09-20 19:00 ` Christian Lamparter
2023-09-22 1:33 ` yunchuan
2023-09-28 15:31 ` Kalle Valo
2023-09-28 19:26 ` Jeff Johnson
2023-09-29 6:43 ` Dan Carpenter
2023-09-29 6:49 ` Dan Carpenter
2023-09-29 7:23 ` Christian Lamparter [this message]
2023-09-29 12:26 ` Dan Carpenter
2023-09-29 12:30 ` Dan Carpenter
2023-09-29 16:10 ` Jeff Johnson
2023-09-29 17:22 ` Jeff Johnson
2023-10-02 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5611be9-ef4d-4e49-84de-7ce893e3c73c@gmail.com \
--to=chunkeey@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox