From: Christian Lamparter <chunkeey@gmail.com>
To: Wu Yunchuan <yunchuan@nfschina.com>, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions
Date: Wed, 20 Sep 2023 21:00:08 +0200 [thread overview]
Message-ID: <e544d992-cddd-4ade-81ef-2eed4f3681e8@gmail.com> (raw)
In-Reply-To: <20230919044916.523308-1-yunchuan@nfschina.com>
On 9/19/23 06:49, Wu Yunchuan wrote:
> No need cast (void *) to (struct ar9170 *), (u8 *) or (void*).
hmm, your mail went into the spam folder. Good thing I checked.
From what I remember: The reason why these casts were added in
carl9170 was because of compiler warnings/complaints.
Current gcc compilers should be OK (given that the kernel-bot
didn't react, or went your Mail to their spam-folder as well?)
but have you checked these older versions?
(In 6.5.0 Documentation/admin-guide/README.rst states that one
should have at least gcc 5.1 - could you run with those and
see if C=2 W=1 passes?)
Regards,
Christian
> Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
> ---
> drivers/net/wireless/ath/carl9170/usb.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/usb.c b/drivers/net/wireless/ath/carl9170/usb.c
> index e4eb666c6eea..c4edf8355941 100644
> --- a/drivers/net/wireless/ath/carl9170/usb.c
> +++ b/drivers/net/wireless/ath/carl9170/usb.c
> @@ -178,7 +178,7 @@ static void carl9170_usb_tx_data_complete(struct urb *urb)
> switch (urb->status) {
> /* everything is fine */
> case 0:
> - carl9170_tx_callback(ar, (void *)urb->context);
> + carl9170_tx_callback(ar, urb->context);
> break;
>
> /* disconnect */
> @@ -369,7 +369,7 @@ void carl9170_usb_handle_tx_err(struct ar9170 *ar)
> struct urb *urb;
>
> while ((urb = usb_get_from_anchor(&ar->tx_err))) {
> - struct sk_buff *skb = (void *)urb->context;
> + struct sk_buff *skb = urb->context;
>
> carl9170_tx_drop(ar, skb);
> carl9170_tx_callback(ar, skb);
> @@ -397,7 +397,7 @@ static void carl9170_usb_tasklet(struct tasklet_struct *t)
>
> static void carl9170_usb_rx_complete(struct urb *urb)
> {
> - struct ar9170 *ar = (struct ar9170 *)urb->context;
> + struct ar9170 *ar = urb->context;
> int err;
>
> if (WARN_ON_ONCE(!ar))
> @@ -559,7 +559,7 @@ static int carl9170_usb_flush(struct ar9170 *ar)
> int ret, err = 0;
>
> while ((urb = usb_get_from_anchor(&ar->tx_wait))) {
> - struct sk_buff *skb = (void *)urb->context;
> + struct sk_buff *skb = urb->context;
> carl9170_tx_drop(ar, skb);
> carl9170_tx_callback(ar, skb);
> usb_free_urb(urb);
> @@ -668,7 +668,7 @@ int carl9170_exec_cmd(struct ar9170 *ar, const enum carl9170_cmd_oids cmd,
> memcpy(ar->cmd.data, payload, plen);
>
> spin_lock_bh(&ar->cmd_lock);
> - ar->readbuf = (u8 *)out;
> + ar->readbuf = out;
> ar->readlen = outlen;
> spin_unlock_bh(&ar->cmd_lock);
>
next prev parent reply other threads:[~2023-09-20 19:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 4:49 [PATCH v2 wireless-next 2/9] carl9170: remove unnecessary (void*) conversions Wu Yunchuan
2023-09-20 18:15 ` Jeff Johnson
2023-09-20 19:00 ` Christian Lamparter [this message]
2023-09-22 1:33 ` yunchuan
2023-09-28 15:31 ` Kalle Valo
2023-09-28 19:26 ` Jeff Johnson
2023-09-29 6:43 ` Dan Carpenter
2023-09-29 6:49 ` Dan Carpenter
2023-09-29 7:23 ` Christian Lamparter
2023-09-29 12:26 ` Dan Carpenter
2023-09-29 12:30 ` Dan Carpenter
2023-09-29 16:10 ` Jeff Johnson
2023-09-29 17:22 ` Jeff Johnson
2023-10-02 16:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e544d992-cddd-4ade-81ef-2eed4f3681e8@gmail.com \
--to=chunkeey@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yunchuan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox