Linux wireless drivers development
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Evan Quan <evan.quan@amd.com>,
	rafael@kernel.org, lenb@kernel.org, alexander.deucher@amd.com,
	christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
	daniel@ffwll.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, mario.limonciello@amd.com,
	mdaenzer@redhat.com, maarten.lankhorst@linux.intel.com,
	tzimmermann@suse.de, hdegoede@redhat.com, jingyuwang_vip@163.com,
	lijo.lazar@amd.com, jim.cromie@gmail.com, bellosilicio@gmail.com,
	andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
	arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations
Date: Wed, 21 Jun 2023 18:14:03 +0200	[thread overview]
Message-ID: <d2dba04d-36bf-4d07-bf2b-dd06671c45c6@lunn.ch> (raw)
In-Reply-To: <216f3c5aa1299100a0009ddf4e95b019855a32be.camel@sipsolutions.net>

> > Do only ACPI based systems have:
> > 
> >    interference of relatively high-powered harmonics of the (G-)DDR
> >    memory clocks with local radio module frequency bands used by
> >    Wifi 6/6e/7."
> > 
> > Could Device Tree based systems not experience this problem?
> 
> They could, of course, but they'd need some other driver to change
> _something_ in the system? I don't even know what this is doing
> precisely under the hood in the ACPI BIOS

If you don't know what it is actually doing, it suggests the API is
not very well defined. Is there even enough details that ARM64 ACPI
BIOS could implement this? 

> > > +/**
> > > + * APIs needed by drivers/subsystems for contributing frequencies:
> > > + * During probe, check `wbrf_supported_producer` to see if WBRF is supported.
> > > + * If adding frequencies, then call `wbrf_add_exclusion` with the
> > > + * start and end points specified for the frequency ranges added.
> > > + * If removing frequencies, then call `wbrf_remove_exclusion` with
> > > + * start and end points specified for the frequency ranges added.
> > > + */
> > > +bool wbrf_supported_producer(struct acpi_device *adev);
> > > +int wbrf_add_exclusion(struct acpi_device *adev,
> > > +		       struct wbrf_ranges_in *in);
> > > +int wbrf_remove_exclusion(struct acpi_device *adev,
> > > +			  struct wbrf_ranges_in *in);
> > 
> > Could struct device be used here, to make the API agnostic to where
> > the information is coming from? That would then allow somebody in the
> > future to implement a device tree based information provider.
> 
> That does make sense, and it wouldn't even be that much harder if we
> assume in a given platform there's only one provider

That seems like a very reasonable assumption. It is theoretically
possible to build an ACPI + DT hybrid, but i've never seen it actually
done.

If an ARM64 ACPI BIOS could implement this, then i would guess the low
level bits would be solved, i guess jumping into the EL1
firmware. Putting DT on top instead should not be too hard.

	Andrew

  reply	other threads:[~2023-06-21 16:15 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  5:45 [PATCH V4 0/8] Support Wifi RFI interference mitigation feature Evan Quan
2023-06-21  5:45 ` [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations Evan Quan
2023-06-21 15:36   ` Andrew Lunn
2023-06-21 15:39     ` Johannes Berg
2023-06-21 16:14       ` Andrew Lunn [this message]
2023-06-21 16:23         ` Limonciello, Mario
2023-06-21 16:31           ` Andrew Lunn
2023-06-21 16:40             ` Limonciello, Mario
2023-06-21 17:20               ` Andrew Lunn
2023-06-21 16:37         ` Johannes Berg
2023-06-21 16:15       ` Limonciello, Mario
2023-06-21 16:52         ` Andrew Lunn
2023-06-21 17:08           ` Limonciello, Mario
2023-06-21 17:26             ` Andrew Lunn
2023-06-21 17:43               ` Limonciello, Mario
2023-06-21 18:30                 ` Andrew Lunn
2023-06-21 18:50                   ` Limonciello, Mario
2023-06-21 19:25                     ` Andrew Lunn
2023-06-21 22:18                       ` Johannes Berg
2023-06-22  1:55                         ` Andrew Lunn
2023-06-22 20:28                           ` Limonciello, Mario
2023-06-22 21:20                     ` Andrew Lunn
2023-06-23 14:52   ` Rafael J. Wysocki
2023-06-23 15:57     ` Limonciello, Mario
2023-06-23 16:28       ` Rafael J. Wysocki
2023-06-23 16:48         ` Limonciello, Mario
2023-06-23 17:15           ` Rafael J. Wysocki
2023-06-30 10:37             ` Quan, Evan
2023-06-23 16:38   ` Rafael J. Wysocki
2023-06-21  5:45 ` [PATCH V4 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing Evan Quan
2023-06-21  5:45 ` [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF Evan Quan
2023-06-21 10:22   ` Johannes Berg
2023-06-21 14:12     ` Limonciello, Mario
2023-06-21 14:25       ` Johannes Berg
2023-06-21  5:45 ` [PATCH V4 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature Evan Quan
2023-06-21  5:46 ` [PATCH V4 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature Evan Quan
2023-06-21  5:46 ` [PATCH V4 6/8] drm/amd/pm: add flood detection for wbrf events Evan Quan
2023-06-21  5:46 ` [PATCH V4 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0 Evan Quan
2023-06-21  5:46 ` [PATCH V4 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7 Evan Quan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2dba04d-36bf-4d07-bf2b-dd06671c45c6@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=bellosilicio@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edumazet@google.com \
    --cc=evan.quan@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=jim.cromie@gmail.com \
    --cc=jingyuwang_vip@163.com \
    --cc=johannes@sipsolutions.net \
    --cc=jsg@jsg.id.au \
    --cc=kuba@kernel.org \
    --cc=lenb@kernel.org \
    --cc=lijo.lazar@amd.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=mdaenzer@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=trix@redhat.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox