Linux wireless drivers development
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Limonciello, Mario" <mario.limonciello@amd.com>,
	Evan Quan <evan.quan@amd.com>,
	rafael@kernel.org, lenb@kernel.org, alexander.deucher@amd.com,
	christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
	daniel@ffwll.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, mdaenzer@redhat.com,
	maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
	hdegoede@redhat.com, jingyuwang_vip@163.com, lijo.lazar@amd.com,
	jim.cromie@gmail.com, bellosilicio@gmail.com,
	andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
	arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations
Date: Thu, 22 Jun 2023 03:55:25 +0200	[thread overview]
Message-ID: <ef7dc1ab-c6d0-4761-8d0a-8949bfd3da80@lunn.ch> (raw)
In-Reply-To: <3e337dc0482e16e2aaa4090b613dc8dea7803fa8.camel@sipsolutions.net>

> Honestly I'm not sure though we need this complexity right now? I mean,
> it'd be really easy to replace the calls in mac80211 with some other
> more generalised calls in the future?
> 
> You need some really deep platform/hardware level knowledge and
> involvement to do this, so I don't think it's something that someone
> will come up with very easily for a DT-based platform...

What is this API about?

It is a struct device says, i'm badly designed and make a mess of the
following frequency bands. Optionally, if you ask me nicely, i might
be able to tweak what i'm doing to avoid interfering with you.

And it is about a struct device say, i'm using this particular
frequency. If you can reduce the noise you make, i would be thankful.

The one generating the noise could be anything. The PWM driving my
laptop display back light?, What is being interfered with?  The 3.5mm
audio jack?

How much deep system knowledge is needed to call pwm_set_state() to
move the base frequency up above 20Khz so only my dog will hear it?
But at the cost of a loss of efficiency and my battery going flatter
faster?

Is the DDR memory really the only badly designed component, when you
think of the range of systems Linux is used on from PHC to tiny
embedded systems?

Ideally we want any sort of receiver with a low noise amplifier to
just unconditionally use this API to let rest of the system know about
it. And ideally we want anything which is a source of noise to declare
itself. What happens after that should be up to the struct device
causing the interference.

Mario did say:

  The way that WBRF has been architected, it's intended to be able to
  scale to any type of device pair that has harmonic issues.

Andrew

  reply	other threads:[~2023-06-22  1:56 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  5:45 [PATCH V4 0/8] Support Wifi RFI interference mitigation feature Evan Quan
2023-06-21  5:45 ` [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations Evan Quan
2023-06-21 15:36   ` Andrew Lunn
2023-06-21 15:39     ` Johannes Berg
2023-06-21 16:14       ` Andrew Lunn
2023-06-21 16:23         ` Limonciello, Mario
2023-06-21 16:31           ` Andrew Lunn
2023-06-21 16:40             ` Limonciello, Mario
2023-06-21 17:20               ` Andrew Lunn
2023-06-21 16:37         ` Johannes Berg
2023-06-21 16:15       ` Limonciello, Mario
2023-06-21 16:52         ` Andrew Lunn
2023-06-21 17:08           ` Limonciello, Mario
2023-06-21 17:26             ` Andrew Lunn
2023-06-21 17:43               ` Limonciello, Mario
2023-06-21 18:30                 ` Andrew Lunn
2023-06-21 18:50                   ` Limonciello, Mario
2023-06-21 19:25                     ` Andrew Lunn
2023-06-21 22:18                       ` Johannes Berg
2023-06-22  1:55                         ` Andrew Lunn [this message]
2023-06-22 20:28                           ` Limonciello, Mario
2023-06-22 21:20                     ` Andrew Lunn
2023-06-23 14:52   ` Rafael J. Wysocki
2023-06-23 15:57     ` Limonciello, Mario
2023-06-23 16:28       ` Rafael J. Wysocki
2023-06-23 16:48         ` Limonciello, Mario
2023-06-23 17:15           ` Rafael J. Wysocki
2023-06-30 10:37             ` Quan, Evan
2023-06-23 16:38   ` Rafael J. Wysocki
2023-06-21  5:45 ` [PATCH V4 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing Evan Quan
2023-06-21  5:45 ` [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF Evan Quan
2023-06-21 10:22   ` Johannes Berg
2023-06-21 14:12     ` Limonciello, Mario
2023-06-21 14:25       ` Johannes Berg
2023-06-21  5:45 ` [PATCH V4 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature Evan Quan
2023-06-21  5:46 ` [PATCH V4 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature Evan Quan
2023-06-21  5:46 ` [PATCH V4 6/8] drm/amd/pm: add flood detection for wbrf events Evan Quan
2023-06-21  5:46 ` [PATCH V4 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0 Evan Quan
2023-06-21  5:46 ` [PATCH V4 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7 Evan Quan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef7dc1ab-c6d0-4761-8d0a-8949bfd3da80@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=bellosilicio@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=edumazet@google.com \
    --cc=evan.quan@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=jim.cromie@gmail.com \
    --cc=jingyuwang_vip@163.com \
    --cc=johannes@sipsolutions.net \
    --cc=jsg@jsg.id.au \
    --cc=kuba@kernel.org \
    --cc=lenb@kernel.org \
    --cc=lijo.lazar@amd.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=mdaenzer@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=trix@redhat.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox