From: Johannes Berg <johannes@sipsolutions.net>
To: Karthikeyan Kathirvel <karthikeyan.kathirvel@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org
Subject: Re: [PATCH wireless-next v4 2/2] wifi: mac80211_hwsim: Add UHR capabilities to the driver
Date: Tue, 24 Feb 2026 17:20:19 +0100 [thread overview]
Message-ID: <d52fdbe5d9a483b5746b7253b512958d1460a9a1.camel@sipsolutions.net> (raw)
In-Reply-To: <20260217054731.3667600-3-karthikeyan.kathirvel@oss.qualcomm.com>
On Tue, 2026-02-17 at 11:17 +0530, Karthikeyan Kathirvel wrote:
>
> + .uhr_cap = {
> + .has_uhr = true,
> + .mac = {
> + .mac_cap[0] =
> + IEEE80211_UHR_MAC_CAP0_DPS_SUPP |
> + IEEE80211_UHR_MAC_CAP0_DPS_ASSIST_SUPP |
I'm really not sure we should claim all of this, e.g. DPS assist, right
now.
Also, I think you really mixed this up - a regular AP shouldn't claim
DPS below (only mobile AP), but this here station should probably not
normally claim DPS assist?
Just as examples! There are other issues like this such as:
> + IEEE80211_UHR_MAC_CAP1_AP_PUO_SUPP |
I don't think the station should claim AP PUO support.
Certainly not an exhaustive list, ELR also seems wrong, etc.
johannes
next prev parent reply other threads:[~2026-02-24 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 5:47 [PATCH wireless-next v4 00/02] wifi: ieee80211/mac80211: Add UHR (802.11bn) Capability and Operation parsing helpers Karthikeyan Kathirvel
2026-02-17 5:47 ` [PATCH wireless-next v4 1/2] wifi: UHR: define DPS/DBE/P-EDCA elements and fix size parsing Karthikeyan Kathirvel
2026-02-24 16:32 ` Johannes Berg
2026-03-03 10:11 ` Karthikeyan Kathirvel
2026-02-24 16:42 ` Johannes Berg
2026-02-24 17:38 ` Johannes Berg
2026-03-03 10:11 ` Karthikeyan Kathirvel
2026-02-24 20:47 ` Johannes Berg
2026-02-17 5:47 ` [PATCH wireless-next v4 2/2] wifi: mac80211_hwsim: Add UHR capabilities to the driver Karthikeyan Kathirvel
2026-02-24 16:20 ` Johannes Berg [this message]
2026-03-03 11:41 ` Karthikeyan Kathirvel
2026-03-03 11:44 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d52fdbe5d9a483b5746b7253b512958d1460a9a1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath12k@lists.infradead.org \
--cc=karthikeyan.kathirvel@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox