What should setting rate on 'AP' interface mean?

What should setting rate on 'AP' interface mean?

[Ben Greear]

I was trying to use 'iw' to set rates on an AP interface, hoping it would
set tx-rates on all of the stations (peers) to the same thing.

It appears that the ath10k driver will set ratesets on all stations if
we specify more than one rate, but if we specify a single rate, it does
not iterate through all stations, and just sets the 'vdev' fixed rate.

So, should the driver somehow attempt to set single rate on all the stations when
using a single rate?

Or, do we need an API to force rates for individual stations (peers) and leave
the driver in the current configuration?

Or is it the firmware's responsibility to set the rate for all peers when
we set the vdev fixed rate on an AP vdev?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Re: What should setting rate on 'AP' interface mean?

[Adrian Chadd]

Hi,

IIRC, I think it's the drivers job to determine per-peer fixed rate.



-adrian


On 10 October 2017 at 11:34, Ben Greear <greearb@candelatech.com> wrote:
> I was trying to use 'iw' to set rates on an AP interface, hoping it would
> set tx-rates on all of the stations (peers) to the same thing.
>
> It appears that the ath10k driver will set ratesets on all stations if
> we specify more than one rate, but if we specify a single rate, it does
> not iterate through all stations, and just sets the 'vdev' fixed rate.
>
> So, should the driver somehow attempt to set single rate on all the stations
> when
> using a single rate?
>
> Or, do we need an API to force rates for individual stations (peers) and
> leave
> the driver in the current configuration?
>
> Or is it the firmware's responsibility to set the rate for all peers when
> we set the vdev fixed rate on an AP vdev?
>
> Thanks,
> Ben
>
> --
> Ben Greear <greearb@candelatech.com>
> Candela Technologies Inc  http://www.candelatech.com
>

Re: What should setting rate on 'AP' interface mean?

[Ben Greear]

On 10/10/2017 12:09 PM, Adrian Chadd wrote:
> Hi,
>
> IIRC, I think it's the drivers job to determine per-peer fixed rate.

 From poking at the 10.1 firmware source, seems that setting fixed RC on the vdev
should over-ride all of the stations, but it did not appear to be working
as expected...

While trying to debug that, I hit a kernel lockup on rmmod ...it is hard
to make progress some days!

Thanks,
Ben

>
>
>
> -adrian
>
>
> On 10 October 2017 at 11:34, Ben Greear <greearb@candelatech.com> wrote:
>> I was trying to use 'iw' to set rates on an AP interface, hoping it would
>> set tx-rates on all of the stations (peers) to the same thing.
>>
>> It appears that the ath10k driver will set ratesets on all stations if
>> we specify more than one rate, but if we specify a single rate, it does
>> not iterate through all stations, and just sets the 'vdev' fixed rate.
>>
>> So, should the driver somehow attempt to set single rate on all the stations
>> when
>> using a single rate?
>>
>> Or, do we need an API to force rates for individual stations (peers) and
>> leave
>> the driver in the current configuration?
>>
>> Or is it the firmware's responsibility to set the rate for all peers when
>> we set the vdev fixed rate on an AP vdev?
>>
>> Thanks,
>> Ben
>>
>> --
>> Ben Greear <greearb@candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com