* [PATCH] iwlwifi: mvm: Revert "iwlwifi: mvm: fix scan config command size"
@ 2019-12-31 8:36 Jian-Hong Pan
2019-12-31 8:52 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Jian-Hong Pan @ 2019-12-31 8:36 UTC (permalink / raw)
To: Johannes Berg, Emmanuel Grumbach, Luca Coelho, Kalle Valo,
David S . Miller, Shahar S Matityahu, Tova Mussai, Ayala Beker
Cc: Intel Linux Wireless, linux-wireless, netdev, linux-kernel, linux,
Jian-Hong Pan
The Intel(R) Dual Band Wireless AC 9461 WiFi keeps restarting until
commit 06eb547c4ae4 ("wlwifi: mvm: fix scan config command size") is
reverted.
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=206025
Fixes: commit 06eb547c4ae4 ("wlwifi: mvm: fix scan config command size")
Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
---
drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
index a046ac9fa852..a5af8f4128b1 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
@@ -1213,7 +1213,7 @@ static int iwl_mvm_legacy_config_scan(struct iwl_mvm *mvm)
cmd_size = sizeof(struct iwl_scan_config_v2);
else
cmd_size = sizeof(struct iwl_scan_config_v1);
- cmd_size += num_channels;
+ cmd_size += mvm->fw->ucode_capa.n_scan_channels;
cfg = kzalloc(cmd_size, GFP_KERNEL);
if (!cfg)
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iwlwifi: mvm: Revert "iwlwifi: mvm: fix scan config command size"
2019-12-31 8:36 [PATCH] iwlwifi: mvm: Revert "iwlwifi: mvm: fix scan config command size" Jian-Hong Pan
@ 2019-12-31 8:52 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2019-12-31 8:52 UTC (permalink / raw)
To: Jian-Hong Pan, Johannes Berg, Emmanuel Grumbach, Kalle Valo,
David S . Miller, Shahar S Matityahu, Tova Mussai, Ayala Beker
Cc: Intel Linux Wireless, linux-wireless, netdev, linux-kernel, linux
On Tue, 2019-12-31 at 16:36 +0800, Jian-Hong Pan wrote:
> The Intel(R) Dual Band Wireless AC 9461 WiFi keeps restarting until
> commit 06eb547c4ae4 ("wlwifi: mvm: fix scan config command size") is
> reverted.
>
> Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=206025
> Fixes: commit 06eb547c4ae4 ("wlwifi: mvm: fix scan config command size")
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> ---
We already have this fix queued up for v5.5-rc*:
https://patchwork.kernel.org/patch/11313069/
Thanks for the patch anyway!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-31 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-31 8:36 [PATCH] iwlwifi: mvm: Revert "iwlwifi: mvm: fix scan config command size" Jian-Hong Pan
2019-12-31 8:52 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox