* Re: [PATCH] cfg80211: don't report SME connection errs at SIOCSIW{FREQ/AP/ESSID}
From: Johannes Berg @ 2009-09-14 17:43 UTC (permalink / raw)
To: Holger Schurig; +Cc: linux-wireless, John W Linville
In-Reply-To: <200909141323.44245.hs4233@mail.mn-solutions.de>
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
On Mon, 2009-09-14 at 13:23 +0200, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
>
> ---
>
> This fixes
>
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> ioctl[SIOCSIWFREQ]: No such file or directory
> ioctl[SIOCSIWESSID]: No such file or directory
> 1252921276.268451: Association request to the driver failed
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
>
> and makes it
>
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
>
> However, otherwise this hasn't been greatly tested and I
> don't have a great understanding of cfg80211, SME, etc ...
And doesn't look correct to me at all. probably something missing wrt.
disconnect() while connecting.
johannes
> Index: linux-wl/net/wireless/wext-sme.c
> ===================================================================
> --- linux-wl.orig/net/wireless/wext-sme.c 2009-09-14 12:05:54.000000000 +0200
> +++ linux-wl/net/wireless/wext-sme.c 2009-09-14 12:06:09.000000000 +0200
> @@ -110,7 +110,7 @@ int cfg80211_mgd_wext_siwfreq(struct net
> goto out;
> }
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
> @@ -196,7 +196,7 @@ int cfg80211_mgd_wext_siwessid(struct ne
>
> wdev->wext.connect.crypto.control_port = false;
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
> @@ -283,7 +283,7 @@ int cfg80211_mgd_wext_siwap(struct net_d
> } else
> wdev->wext.connect.bssid = NULL;
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: RTL8187B wireless driver issue
From: Vignette consultant @ 2009-09-14 17:56 UTC (permalink / raw)
To: Larry Finger; +Cc: wireless
In-Reply-To: <4AAE7446.3080407@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
Larry,
I got the same error even after adding wlan0 in
/etc/network/interfaces file. I set the essid using "sudo iwconfig
wlan0 essid linksys" command and restarted network. I tried other
essids, but it gives same error.
Attached files contain log files. Please advise about solution.
How do I disable usb monitoring log, so I can see wlan0 interface log
from dmesg?
Thanks
Sam
On 9/14/09, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Vignette consultant wrote:
>> Hi
>>
>> Attached files contain several logs of various commands. The log-1
>> file is before running command and log-2 file is after running
>> specific command.
>>
>> Here are commands that I give as soon as I log in. It's server edition.
>>
>> $ sudo ifconfig wlan0 up
>> $ sudo iwconfig wlan0 ESSID linksys
>> $ sudo dhclient wlan0 - results in no IP addr leased
>
> Your wireless has not associated and has no communication, which is
> why it cannot get an IP using DHCP.
>
> A quick check with Google indicates that Ubuntu uses
> /etc/network/interfaces to control the devices. Once that is correct,
> you should be able to 'sudo /etc/init.d/networking restart' to start
> the network. If the server is properly configured, the network should
> start on boot.
>
> BTW, the dmesg buffer is circular. All that usb monitoring output has
> completely filled the buffer, and it contains no useful information.
>
[-- Attachment #2: interfaces.log --]
[-- Type: text/plain, Size: 238 bytes --]
# This file describes the network interfaces available on your system
# and how to activate them. For more information, see interfaces(5).
# The loopback network interface
auto lo
iface lo inet loopback
auto wlan0
iface wlan0 inet dhcp
[-- Attachment #3: ifconfig.log --]
[-- Type: text/plain, Size: 1009 bytes --]
lo Link encap:Local Loopback
inet addr:127.0.0.1 Mask:255.0.0.0
UP LOOPBACK RUNNING MTU:16436 Metric:1
RX packets:0 errors:0 dropped:0 overruns:0 frame:0
TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:0
RX bytes:0 (0.0 B) TX bytes:0 (0.0 B)
wlan0 Link encap:Ethernet HWaddr 00:16:44:8f:8f:90
UP BROADCAST MULTICAST MTU:1500 Metric:1
RX packets:0 errors:0 dropped:0 overruns:0 frame:0
TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:0 (0.0 B) TX bytes:0 (0.0 B)
wmaster0 Link encap:UNSPEC HWaddr 00-16-44-8F-8F-90-00-00-00-00-00-00-00-00-00-00
UP RUNNING MTU:0 Metric:1
RX packets:0 errors:0 dropped:0 overruns:0 frame:0
TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:0 (0.0 B) TX bytes:0 (0.0 B)
[-- Attachment #4: iwconfig.log --]
[-- Type: text/plain, Size: 463 bytes --]
wlan0 IEEE 802.11bg ESSID:"linksys"
Mode:Managed Frequency:2.437 GHz Access Point: Not-Associated
Tx-Power=27 dBm
Retry long limit:7 RTS thr:off Fragment thr:off
Encryption key:off
Power Management:off
Link Quality:0 Signal level:0 Noise level:0
Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0
Tx excessive retries:0 Invalid misc:0 Missed beacon:0
[-- Attachment #5: scan.log --]
[-- Type: text/plain, Size: 5149 bytes --]
wlan0 Scan completed :
Cell 01 - Address: 00:1F:33:3C:63:C4
Channel:1
Frequency:2.412 GHz (Channel 1)
Quality=61/70 Signal level=-49 dBm
Encryption key:on
ESSID:"net2000"
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 18 Mb/s
24 Mb/s; 36 Mb/s; 54 Mb/s
Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 48 Mb/s
Mode:Master
Extra:tsf=0000003d4af91183
Extra: Last beacon: 1580ms ago
IE: Unknown: 00076E657432303030
IE: Unknown: 010882848B962430486C
IE: Unknown: 030101
IE: Unknown: 2A0100
IE: Unknown: 2F0100
IE: IEEE 802.11i/WPA2 Version 1
Group Cipher : TKIP
Pairwise Ciphers (2) : CCMP TKIP
Authentication Suites (1) : PSK
IE: Unknown: 32040C121860
IE: Unknown: DD7C0050F204104A00011010440001021041000100103B00010310470010AA9D0E6D2602AE7039A5776EBF8C70BE1021000D4E4554474541522C20496E632E10230009574E5238333442763210240009574E523833344276321042000230311054000800060050F204000110110009574E52383334427632100800020084
IE: Unknown: DD090010180200F0010000
IE: WPA Version 1
Group Cipher : TKIP
Pairwise Ciphers (2) : CCMP TKIP
Authentication Suites (1) : PSK
IE: Unknown: DD180050F2020101800003A4000027A4000042435E0062322F00
Cell 02 - Address: 00:1C:10:32:94:61
Channel:6
Frequency:2.437 GHz (Channel 6)
Quality=57/70 Signal level=-53 dBm
Encryption key:off
ESSID:"linksys"
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 18 Mb/s
24 Mb/s; 36 Mb/s; 54 Mb/s
Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 48 Mb/s
Mode:Master
Extra:tsf=0000009d3efb0184
Extra: Last beacon: 540ms ago
IE: Unknown: 00076C696E6B737973
IE: Unknown: 010882848B962430486C
IE: Unknown: 030106
IE: Unknown: 050400010000
IE: Unknown: 2A0104
IE: Unknown: 2F0104
IE: Unknown: 32040C121860
IE: Unknown: DD090010180200F4000000
Cell 03 - Address: 00:1B:2F:F6:4F:1E
Channel:6
Frequency:2.437 GHz (Channel 6)
Quality=45/70 Signal level=-65 dBm
Encryption key:on
ESSID:"Home"
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 6 Mb/s
12 Mb/s; 24 Mb/s; 36 Mb/s
Bit Rates:9 Mb/s; 18 Mb/s; 48 Mb/s; 54 Mb/s
Mode:Master
Extra:tsf=0000009d3e650181
Extra: Last beacon: 520ms ago
IE: Unknown: 0004486F6D65
IE: Unknown: 010882848B960C183048
IE: Unknown: 030106
IE: Unknown: 050400010008
IE: Unknown: 2A0100
IE: Unknown: 32041224606C
IE: IEEE 802.11i/WPA2 Version 1
Group Cipher : TKIP
Pairwise Ciphers (2) : TKIP CCMP
Authentication Suites (1) : PSK
Preauthentication Supported
IE: WPA Version 1
Group Cipher : TKIP
Pairwise Ciphers (2) : TKIP CCMP
Authentication Suites (1) : PSK
IE: Unknown: DD0900037F0101001DFF7F
IE: Unknown: DD0C00037F020101060002A34000
IE: Unknown: DD1A00037F0301000000001B2FF64F1E021B2FF64F1E64002C011D08
Cell 04 - Address: 00:14:BF:7D:27:F8
Channel:6
Frequency:2.437 GHz (Channel 6)
Quality=40/70 Signal level=-70 dBm
Encryption key:off
ESSID:"numberone"
Bit Rates:1 Mb/s; 2 Mb/s; 5.5 Mb/s; 11 Mb/s; 18 Mb/s
24 Mb/s; 36 Mb/s; 54 Mb/s
Bit Rates:6 Mb/s; 9 Mb/s; 12 Mb/s; 48 Mb/s
Mode:Master
Extra:tsf=0000009d3e4c0183
Extra: Last beacon: 850ms ago
IE: Unknown: 00096E756D6265726F6E65
IE: Unknown: 010882848B962430486C
IE: Unknown: 030106
IE: Unknown: 050400010000
IE: Unknown: 2A0104
IE: Unknown: 2F0104
IE: Unknown: 32040C121860
IE: Unknown: DD090010180200F4000000
[-- Attachment #6: dhclient.log --]
[-- Type: text/plain, Size: 781 bytes --]
Internet Systems Consortium DHCP Client V3.1.1
Copyright 2004-2008 Internet Systems Consortium.
All rights reserved.
For info, please visit http://www.isc.org/sw/dhcp/
Listening on LPF/wlan0/00:16:44:8f:8f:90
Sending on LPF/wlan0/00:16:44:8f:8f:90
Sending on Socket/fallback
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 5
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 10
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 10
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 7
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 12
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 13
DHCPDISCOVER on wlan0 to 255.255.255.255 port 67 interval 4
No DHCPOFFERS received.
No working leases in persistent database - sleeping.
^ permalink raw reply
* Re: iwlagn: order 2 page allocation failures
From: Mel Gorman @ 2009-09-14 17:59 UTC (permalink / raw)
To: Christoph Lameter
Cc: Zhu Yi, Chatre, Reinette, Frans Pop, Larry Finger,
John W. Linville, Pekka Enberg, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, Andrew Morton, Krauss, Assaf,
Johannes Berg, Abbas, Mohamed
In-Reply-To: <alpine.DEB.1.10.0909141141200.24447@V090114053VZO-1>
On Mon, Sep 14, 2009 at 11:42:15AM -0400, Christoph Lameter wrote:
> On Mon, 14 Sep 2009, Zhu Yi wrote:
>
> > BTW, does SLAB/SLUB guarantee size of multiple PAGE_SIZE __kmalloc()
> > allocation align on PAGE_SIZE (or 256 bytes) boundary?
>
> Page allocators guarantee page aligned data. Slab allocators do not.
>
> You can create a slab that aligns objects on 256 byte boundary if you
> want.
>
The allocation of buffers >= PAGE_SIZE even when allocated with
kmalloc() are page-aligned though right? It's not an explicit guarantee
but is it not always the case?
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply
* Re: iwlagn: order 2 page allocation failures
From: Christoph Lameter @ 2009-09-14 18:04 UTC (permalink / raw)
To: Mel Gorman
Cc: Zhu Yi, Chatre, Reinette, Frans Pop, Larry Finger,
John W. Linville, Pekka Enberg, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net, Andrew Morton, Krauss, Assaf,
Johannes Berg, Abbas, Mohamed
In-Reply-To: <20090914175942.GH11778@csn.ul.ie>
On Mon, 14 Sep 2009, Mel Gorman wrote:
> The allocation of buffers >= PAGE_SIZE even when allocated with
> kmalloc() are page-aligned though right? It's not an explicit guarantee
> but is it not always the case?
Its typically the case but debug options may misalign the object. The
guarantee for kmalloc caches is to be cacheline aligned.
^ permalink raw reply
* Re: [PATCH v3 3/4] ath5k: define ath_common ops
From: Bob Copeland @ 2009-09-14 18:12 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless, devel, ath9k-devel
In-Reply-To: <1252919221-13628-1-git-send-email-lrodriguez@atheros.com>
On Mon, Sep 14, 2009 at 5:07 AM, Luis R. Rodriguez
<lrodriguez@atheros.com> wrote:
> Only common ath read/write ops go through the common ops.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Thanks Luis, looks good to me too.
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply
* Re: Kernel oops with 2.6.31-wl
From: Larry Finger @ 2009-09-14 18:20 UTC (permalink / raw)
To: Johannes Berg; +Cc: wireless
In-Reply-To: <1252950017.23427.49.camel@johannes.local>
Johannes Berg wrote:
> On Mon, 2009-09-14 at 09:05 -0500, Larry Finger wrote:
>> Using the kernel v2.6.31-38241-g2d3a51e, I get the following kernel
>> oops when unloading b43:
>
>> RIP: 0010:[<ffffffffa02a3a3e>] [<ffffffffa02a3a3e>]
>> b43_op_config+0x10c/0x36f [b43]
>
> Seems like a b43 problem to me.
I had pretty much reached that conclusion. I will need to swap cards
to debug as the 4315 won't run on older kernels without a lot of patches.
Larry
^ permalink raw reply
* missing device id in ar9170 driver
From: Fabian Lenz @ 2009-09-14 18:46 UTC (permalink / raw)
To: linux-wireless
Hello! A quick note: device id 1002 for my TP-LINK TL-WN821N stick is missing,
please include it in the driver.
Regards!
^ permalink raw reply
* [PATCH] b43: LP-PHY: Fix analog core switching
From: Gábor Stefanik @ 2009-09-14 19:10 UTC (permalink / raw)
To: John Linville, Michael Buesch, Larry Finger
Cc: Broadcom Wireless, linux-wireless
The generic analog switch routine is not correct for LP-PHY according
to the latest specs. Implement the proper analog core switch routine.
Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
---
diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 80da9c7..b0e127a 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -2160,6 +2160,16 @@ static int lpphy_b2063_tune(struct b43_w
return 0;
}
+static void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
+{
+ if (on) {
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x7);
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x7);
+ } else {
+ b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xFFF8);
+ }
+}
+
static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
unsigned int new_channel)
{
@@ -2239,7 +2249,7 @@ const struct b43_phy_operations b43_phyo
.radio_read = b43_lpphy_op_radio_read,
.radio_write = b43_lpphy_op_radio_write,
.software_rfkill = b43_lpphy_op_software_rfkill,
- .switch_analog = b43_phyop_switch_analog_generic,
+ .switch_analog = b43_lpphy_op_switch_analog,
.switch_channel = b43_lpphy_op_switch_channel,
.get_default_chan = b43_lpphy_op_get_default_chan,
.set_rx_antenna = b43_lpphy_op_set_rx_antenna,
^ permalink raw reply related
* Re: [PATCH] b43: LP-PHY: Fix analog core switching
From: Thomas Ilnseher @ 2009-09-14 19:24 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Michael Buesch, Larry Finger, linux-wireless,
Broadcom Wireless
In-Reply-To: <4AAE950C.2050704@gmail.com>
On Mo, 2009-09-14 at 21:10 +0200, Gábor Stefanik wrote:
> The generic analog switch routine is not correct for LP-PHY according
> to the latest specs. Implement the proper analog core switch routine.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 80da9c7..b0e127a 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -2160,6 +2160,16 @@ static int lpphy_b2063_tune(struct b43_w
> return 0;
> }
>
> +static void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
> +{
The spec says:
Else if this in an LP PHY
a. If argument "on" is zero
1. OR PHY Register 0x43C with 7
2. OR PHY Register 0x43B with 7
> + if (on) {
This stuff is executed when on is true (ie. anything else than zero)
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x7);
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x7);
> + } else {
> + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xFFF8);
> + }
> +}
> +
> static int b43_lpphy_op_switch_channel(struct b43_wldev *dev,
> unsigned int new_channel)
> {
> @@ -2239,7 +2249,7 @@ const struct b43_phy_operations b43_phyo
> .radio_read = b43_lpphy_op_radio_read,
> .radio_write = b43_lpphy_op_radio_write,
> .software_rfkill = b43_lpphy_op_software_rfkill,
> - .switch_analog = b43_phyop_switch_analog_generic,
> + .switch_analog = b43_lpphy_op_switch_analog,
> .switch_channel = b43_lpphy_op_switch_channel,
> .get_default_chan = b43_lpphy_op_get_default_chan,
> .set_rx_antenna = b43_lpphy_op_set_rx_antenna,
>
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
^ permalink raw reply
* Missing device ID in p54usb driver
From: Jari Jaakola @ 2009-09-14 19:38 UTC (permalink / raw)
To: linux-wireless
Hello!
Device ID "0cde:0015" is missing from driver "p54usb". This usb wlan
stick is Z-Com XG-705A, it seems to work ok after I added device id in
driver, builded and installed it. I used compat-wireless-2.6.30.
Regards,
Jari
PS. Below is lsusb -v
Bus 002 Device 006: ID 0cde:0015 Z-Com Zoom Wireless-G
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor 0x0cde Z-Com
idProduct 0x0015 Zoom Wireless-G
bcdDevice 1.00
iManufacturer 1 Conexant
iProduct 2 Cohiba 3887a rev1
iSerial 3 3887-0100
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 53
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 500mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 5
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 1
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)
^ permalink raw reply
* Re: [PATCH] b43: LP-PHY: Fix analog core switching
From: Michael Buesch @ 2009-09-14 19:40 UTC (permalink / raw)
To: Gábor Stefanik
Cc: John Linville, Larry Finger, Broadcom Wireless, linux-wireless
In-Reply-To: <4AAE950C.2050704@gmail.com>
On Monday 14 September 2009 21:10:04 Gábor Stefanik wrote:
> The generic analog switch routine is not correct for LP-PHY according
> to the latest specs. Implement the proper analog core switch routine.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
> ---
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 80da9c7..b0e127a 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -2160,6 +2160,16 @@ static int lpphy_b2063_tune(struct b43_w
> return 0;
> }
>
> +static void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
> +{
> + if (on) {
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x7);
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x7);
> + } else {
> + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xFFF8);
> + }
> +}
You have the if branches swapped. (Don't add a ! in front of the on. Swap the branches).
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH3]Add analog switch support
From: Gábor Stefanik @ 2009-09-14 19:43 UTC (permalink / raw)
To: Thomas Ilnseher, John Linville; +Cc: Broadcom Wireless, linux-wireless
In-Reply-To: <1252956934.4696.23.camel@luzifer.localnet>
Always send patches to John Linville, and CC linux-wireless.
On Mon, Sep 14, 2009 at 9:35 PM, Thomas Ilnseher <illth@gmx.de> wrote:
> As I've seen Gàbor's patch, I noticed that my previous patch was
> bullshit. This patch should work:
>
> Signed-off-by: Thomas Ilnseher <illth@gmx.de>
>
> diff -uNr b/drivers/net/wireless/b43/phy_lp.c a/drivers/net/wireless/b43/phy_lp.c
> --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 +0200
> +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 +0200
> @@ -2228,6 +2228,16 @@
> return B43_TXPWR_RES_DONE;
> }
>
> +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
> +{
> + if (on) {
> + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
> + } else {
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
> + }
> +}
> +
> const struct b43_phy_operations b43_phyops_lp = {
> .allocate = b43_lpphy_op_allocate,
> .free = b43_lpphy_op_free,
> @@ -2239,7 +2249,7 @@
> .radio_read = b43_lpphy_op_radio_read,
> .radio_write = b43_lpphy_op_radio_write,
> .software_rfkill = b43_lpphy_op_software_rfkill,
> - .switch_analog = b43_phyop_switch_analog_generic,
> + .switch_analog = b43_lpphy_op_switch_analog,
> .switch_channel = b43_lpphy_op_switch_channel,
> .get_default_chan = b43_lpphy_op_get_default_chan,
> .set_rx_antenna = b43_lpphy_op_set_rx_antenna,
>
>
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>
--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
^ permalink raw reply
* Re: [PATCH RFC 2/3] sdio: pass unknown cis tuples to sdio drivers
From: Pierre Ossman @ 2009-09-14 19:52 UTC (permalink / raw)
To: Michael Buesch; +Cc: Albert Herranz, bcm43xx-dev, linux-mmc, linux-wireless
In-Reply-To: <200909072056.00673.mb@bu3sch.de>
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
On Mon, 7 Sep 2009 20:55:58 +0200
Michael Buesch <mb@bu3sch.de> wrote:
> On Monday 07 September 2009 20:47:12 Albert Herranz wrote:
> >
> >
>
> Please also submit to the SDIO maintainer.
>
There isn't one anymore, so submitting to this list is the correct
method.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply
* Re: [PATCH3]Add analog switch support
From: Thomas Ilnseher @ 2009-09-14 19:56 UTC (permalink / raw)
To: John Linville; +Cc: Broadcom Wireless, linux-wireless
In-Reply-To: <69e28c910909141243i5551c87bsfd0c9e767cfa254@mail.gmail.com>
On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote:
> Always send patches to John Linville, and CC linux-wireless.
Ok, the last try ...
As I've seen Gàbor's patch, I noticed that my previous patch was
bullshit. This patch should work:
(see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore)
Signed-off-by: Thomas Ilnseher <illth@gmx.de>
diff -uNr b/drivers/net/wireless/b43/phy_lp.c
a/drivers/net/wireless/b43/phy_lp.c
--- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000
+0200
+++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573
+0200
@@ -2228,6 +2228,16 @@
return B43_TXPWR_RES_DONE;
}
+void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
+{
+ if (on) {
+ b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
+ } else {
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
+ }
+}
+
const struct b43_phy_operations b43_phyops_lp = {
.allocate = b43_lpphy_op_allocate,
.free = b43_lpphy_op_free,
@@ -2239,7 +2249,7 @@
.radio_read = b43_lpphy_op_radio_read,
.radio_write = b43_lpphy_op_radio_write,
.software_rfkill = b43_lpphy_op_software_rfkill,
- .switch_analog = b43_phyop_switch_analog_generic,
+ .switch_analog = b43_lpphy_op_switch_analog,
.switch_channel = b43_lpphy_op_switch_channel,
.get_default_chan = b43_lpphy_op_get_default_chan,
.set_rx_antenna = b43_lpphy_op_set_rx_antenna,
^ permalink raw reply
* Re: [PATCH3]Add analog switch support
From: Larry Finger @ 2009-09-14 20:18 UTC (permalink / raw)
To: Thomas Ilnseher; +Cc: John Linville, Broadcom Wireless, linux-wireless
In-Reply-To: <1252958183.4696.25.camel@luzifer.localnet>
Thomas Ilnseher wrote:
> On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote:
>> Always send patches to John Linville, and CC linux-wireless.
> Ok, the last try ...
>
> As I've seen Gàbor's patch, I noticed that my previous patch was
> bullshit. This patch should work:
>
> (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore)
>
> Signed-off-by: Thomas Ilnseher <illth@gmx.de>
>
A few points about patch formatting.
The subject of the submittal message should be of the form "[PATCH]
component: Description". For this one, something like "[PATCH] b43:
Add LP PHY analog switch support" would be appropriate. If multiple
versions are needed, indicate that a previous one is superceded by
[PATCH V2] ..., etc.
There should be a line containing --- after the last signed-off-by line.
Anything between the beginning of the e-mail and the --- line becomes
part of the permanent record if the patch is accepted. Usually quoted
material and words like bullshit are avoided. Not always, but usually.
Between the --- line and the start of the patch, you can place
instructions to Linville regarding the circumstances of the patch and
its priority. Such directions are useful to distinguish an improvement
that should wait for the next merge period from a bug fix that should
be sent upstream ASAP. In this case, the patch fixes a system crash on
some platforms and should be applied now.
Larry
^ permalink raw reply
* Re: [PATCH3]Add analog switch support
From: Thomas Ilnseher @ 2009-09-14 20:22 UTC (permalink / raw)
To: John Linville; +Cc: Broadcom Wireless, linux-wireless
In-Reply-To: <1252958183.4696.25.camel@luzifer.localnet>
I can now confirm that the patch below DOES compile, and even works.
Here is the dmesg output on my router:
root@OpenWrt:/tmp# dmesg
b43-phy1: Broadcom 5354 WLAN found (core revision 13)
b43-phy1 debug: Found PHY: Analog 6, Type 5, Revision 0
b43-phy1 debug: Found Radio: Manuf 0x17F, Version 0x2062, Revision 1
phy1: Selected rate control algorithm 'minstrel'
Broadcom 43xx driver loaded [ Features: PL, Firmware-ID: FW13 ]
b43 ssb0:3: firmware: requesting b43/ucode13.fw
b43 ssb0:3: firmware: requesting b43/lp0initvals13.fw
b43 ssb0:3: firmware: requesting b43/lp0bsinitvals13.fw
b43-phy1: Loading firmware version 410.2160 (2007-05-26 15:32:10)
b43-phy1 debug: b2062: Using crystal tab entry 19200 kHz.
b43-phy1 debug: Chip initialized
b43-phy1 debug: 64-bit DMA initialized
Registered led device: b43-phy1::tx
Registered led device: b43-phy1::rx
b43-phy1 debug: Wireless interface started
b43-phy1 debug: Adding Interface type 2
wlan0: direct probe to AP XXXXXXXX (try 1)
wlan0 direct probe responded
wlan0: authenticate with AP XXXXXXXX (try 1)
wlan0: authenticated
wlan0: associate with AP XXXXXXXX (try 1)
wlan0: RX AssocResp from XXXXXXXX (capab=0x431 status=0 aid=1)
wlan0: associated
b43-phy1 debug: Using hardware based encryption for keyidx: 0, mac: XXXXXXXX
root@OpenWrt:/tmp# iwconfig 2> /dev/null
wlan0 IEEE 802.11bg ESSID:"tommy"
Mode:Managed Frequency:2.412 GHz Access Point: XX:XX:XX:XX:XX:XX
Bit Rate=11 Mb/s Tx-Power=20 dBm
Retry long limit:7 RTS thr:off Fragment thr:off
Encryption key:off
Power Management:off
Link Quality=70/70 Signal level=3 dBm
Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0
Tx excessive retries:0 Invalid misc:0 Missed beacon:0
On Mo, 2009-09-14 at 21:56 +0200, Thomas Ilnseher wrote:
> On Mo, 2009-09-14 at 21:43 +0200, Gábor Stefanik wrote:
> > Always send patches to John Linville, and CC linux-wireless.
> Ok, the last try ...
>
> As I've seen Gàbor's patch, I noticed that my previous patch was
> bullshit. This patch should work:
>
> (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore)
>
> Signed-off-by: Thomas Ilnseher <illth@gmx.de>
>
> diff -uNr b/drivers/net/wireless/b43/phy_lp.c
> a/drivers/net/wireless/b43/phy_lp.c
> --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000
> +0200
> +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573
> +0200
> @@ -2228,6 +2228,16 @@
> return B43_TXPWR_RES_DONE;
> }
>
> +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
> +{
> + if (on) {
> + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
> + } else {
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
> + }
> +}
> +
> const struct b43_phy_operations b43_phyops_lp = {
> .allocate = b43_lpphy_op_allocate,
> .free = b43_lpphy_op_free,
> @@ -2239,7 +2249,7 @@
> .radio_read = b43_lpphy_op_radio_read,
> .radio_write = b43_lpphy_op_radio_write,
> .software_rfkill = b43_lpphy_op_software_rfkill,
> - .switch_analog = b43_phyop_switch_analog_generic,
> + .switch_analog = b43_lpphy_op_switch_analog,
> .switch_channel = b43_lpphy_op_switch_channel,
> .get_default_chan = b43_lpphy_op_get_default_chan,
> .set_rx_antenna = b43_lpphy_op_set_rx_antenna,
>
>
>
^ permalink raw reply
* Re: Kernel oops with 2.6.31-wl
From: Michael Buesch @ 2009-09-14 20:45 UTC (permalink / raw)
To: Larry Finger; +Cc: Johannes Berg, wireless
In-Reply-To: <4AAE8965.4040108@lwfinger.net>
On Monday 14 September 2009 20:20:21 Larry Finger wrote:
> Johannes Berg wrote:
> > On Mon, 2009-09-14 at 09:05 -0500, Larry Finger wrote:
> >> Using the kernel v2.6.31-38241-g2d3a51e, I get the following kernel
> >> oops when unloading b43:
> >
> >> RIP: 0010:[<ffffffffa02a3a3e>] [<ffffffffa02a3a3e>]
> >> b43_op_config+0x10c/0x36f [b43]
> >
> > Seems like a b43 problem to me.
>
> I had pretty much reached that conclusion. I will need to swap cards
> to debug as the 4315 won't run on older kernels without a lot of patches.
I can't reproduce here. What sequence of events is needed to trigger this?
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH3]Add analog switch support
From: Michael Buesch @ 2009-09-14 20:47 UTC (permalink / raw)
To: bcm43xx-dev; +Cc: Thomas Ilnseher, John Linville, linux-wireless
In-Reply-To: <1252959777.4696.29.camel@luzifer.localnet>
On Monday 14 September 2009 22:22:57 Thomas Ilnseher wrote:
> I can now confirm that the patch below DOES compile, and even works.
So can you send a version which conforms to our patch submission standards as larry explained?
--
Greetings, Michael.
^ permalink raw reply
* Re: Kernel oops with 2.6.31-wl
From: Larry Finger @ 2009-09-14 20:50 UTC (permalink / raw)
To: Michael Buesch; +Cc: Johannes Berg, wireless
In-Reply-To: <200909142245.52042.mb@bu3sch.de>
Michael Buesch wrote:
> On Monday 14 September 2009 20:20:21 Larry Finger wrote:
>> Johannes Berg wrote:
>>> On Mon, 2009-09-14 at 09:05 -0500, Larry Finger wrote:
>>>> Using the kernel v2.6.31-38241-g2d3a51e, I get the following kernel
>>>> oops when unloading b43:
>>>> RIP: 0010:[<ffffffffa02a3a3e>] [<ffffffffa02a3a3e>]
>>>> b43_op_config+0x10c/0x36f [b43]
>>> Seems like a b43 problem to me.
>> I had pretty much reached that conclusion. I will need to swap cards
>> to debug as the 4315 won't run on older kernels without a lot of patches.
>
> I can't reproduce here. What sequence of events is needed to trigger this?
All I have to do is make a connection, then "sudo modprobe -rv b43"
while the connection is live. I have not tried shutting the interface
down before the modprobe. It gets through the "rmmod b43" and the
"rmmod ssb" and then crashes.
Larry
^ permalink raw reply
* Re: RTL8187B wireless driver issue
From: Hin-Tak Leung @ 2009-09-14 20:51 UTC (permalink / raw)
To: Vignette consultant; +Cc: Larry Finger, wireless
In-Reply-To: <3b0e19890909141056l4a01b8f9w9887af5d6219c3ff@mail.gmail.com>
On Mon, Sep 14, 2009 at 6:56 PM, Vignette consultant
<vignette75@gmail.com> wrote:
> Larry,
>
> I got the same error even after adding wlan0 in
> /etc/network/interfaces file. I set the essid using "sudo iwconfig
> wlan0 essid linksys" command and restarted network. I tried other
> essids, but it gives same error.
>
> Attached files contain log files. Please advise about solution.
>
> How do I disable usb monitoring log, so I can see wlan0 interface log
> from dmesg?
>
> Thanks
> Sam
>
> On 9/14/09, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> Vignette consultant wrote:
>>> Hi
>>>
>>> Attached files contain several logs of various commands. The log-1
>>> file is before running command and log-2 file is after running
>>> specific command.
>>>
>>> Here are commands that I give as soon as I log in. It's server edition.
>>>
>>> $ sudo ifconfig wlan0 up
>>> $ sudo iwconfig wlan0 ESSID linksys
>>> $ sudo dhclient wlan0 - results in no IP addr leased
>>
>> Your wireless has not associated and has no communication, which is
>> why it cannot get an IP using DHCP.
>>
>> A quick check with Google indicates that Ubuntu uses
>> /etc/network/interfaces to control the devices. Once that is correct,
>> you should be able to 'sudo /etc/init.d/networking restart' to start
>> the network. If the server is properly configured, the network should
>> start on boot.
>>
>> BTW, the dmesg buffer is circular. All that usb monitoring output has
>> completely filled the buffer, and it contains no useful information.
>>
>
scanning works, so there doesn't seem to be anything wrong with the
device or the driver itself. However, even for static configuration,
sometimes wpa_supplicant can still be involved and interfere, so you
probably want to make sure you put all the relevant config in
wpa_supplicant.conf , as well as manually; or make sure no other
network tools are running. (udev can launch wpa_supplicant/dhcp on
ifconfig up automatically - the 'not ready' messages are from udev
hooks). Lastly, I think the Ubuntu/Debian family packages
compat-wireless as 'kernel-modules-backport' or something; try that or
even compat-wireless. ( a while back there was a bug with
associattion).
^ permalink raw reply
* Re: Kernel oops with 2.6.31-wl
From: Michael Buesch @ 2009-09-14 20:55 UTC (permalink / raw)
To: Larry Finger; +Cc: Johannes Berg, wireless
In-Reply-To: <4AAEAC90.7070205@lwfinger.net>
On Monday 14 September 2009 22:50:24 Larry Finger wrote:
> Michael Buesch wrote:
> > On Monday 14 September 2009 20:20:21 Larry Finger wrote:
> >> Johannes Berg wrote:
> >>> On Mon, 2009-09-14 at 09:05 -0500, Larry Finger wrote:
> >>>> Using the kernel v2.6.31-38241-g2d3a51e, I get the following kernel
> >>>> oops when unloading b43:
> >>>> RIP: 0010:[<ffffffffa02a3a3e>] [<ffffffffa02a3a3e>]
> >>>> b43_op_config+0x10c/0x36f [b43]
> >>> Seems like a b43 problem to me.
> >> I had pretty much reached that conclusion. I will need to swap cards
> >> to debug as the 4315 won't run on older kernels without a lot of patches.
> >
> > I can't reproduce here. What sequence of events is needed to trigger this?
>
> All I have to do is make a connection, then "sudo modprobe -rv b43"
> while the connection is live. I have not tried shutting the interface
> down before the modprobe. It gets through the "rmmod b43" and the
> "rmmod ssb" and then crashes.
Ok, works. Thanks.
I'll send a patch soon.
--
Greetings, Michael.
^ permalink raw reply
* [PATCH] b43: Add LP PHY Analog Switch Support
From: Thomas Ilnseher @ 2009-09-14 21:01 UTC (permalink / raw)
To: John Linville; +Cc: Broadcom Wireless, linux-wireless
The current verison of b43 uses "b43_phyop_switch_analog_generic" for A,
G and LP phys.
According to the spec, this is the wrong behaviour for the LP PHY
(see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore )
While no problems on the x86 plattform where seen, this leads to a crash
on the BCM5354 SoC (MIPS 32 LE plattform).
This patch implements the analog switch for LP PHYs according to the
specs. It fixes the crash
signed-off-by: Thomas Ilnseher <illth@gmx.de>
---
diff -uNr b/drivers/net/wireless/b43/phy_lp.c
a/drivers/net/wireless/b43/phy_lp.c
--- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 +0200
+++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 +0200
@@ -2228,6 +2228,16 @@
return B43_TXPWR_RES_DONE;
}
+void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
+{
+ if (on) {
+ b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
+ } else {
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
+ b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
+ }
+}
+
const struct b43_phy_operations b43_phyops_lp = {
.allocate = b43_lpphy_op_allocate,
.free = b43_lpphy_op_free,
@@ -2239,7 +2249,7 @@
.radio_read = b43_lpphy_op_radio_read,
.radio_write = b43_lpphy_op_radio_write,
.software_rfkill = b43_lpphy_op_software_rfkill,
- .switch_analog = b43_phyop_switch_analog_generic,
+ .switch_analog = b43_lpphy_op_switch_analog,
.switch_channel = b43_lpphy_op_switch_channel,
.get_default_chan = b43_lpphy_op_get_default_chan,
.set_rx_antenna = b43_lpphy_op_set_rx_antenna,
^ permalink raw reply
* Re: [PATCH] b43: Add LP PHY Analog Switch Support
From: Michael Buesch @ 2009-09-14 21:07 UTC (permalink / raw)
To: bcm43xx-dev; +Cc: Thomas Ilnseher, John Linville, linux-wireless
In-Reply-To: <1252962093.4696.45.camel@luzifer.localnet>
On Monday 14 September 2009 23:01:33 Thomas Ilnseher wrote:
> The current verison of b43 uses "b43_phyop_switch_analog_generic" for A,
> G and LP phys.
>
> According to the spec, this is the wrong behaviour for the LP PHY
> (see: http://bcm-v4.sipsolutions.net/802.11/PHY/Anacore )
>
> While no problems on the x86 plattform where seen, this leads to a crash
> on the BCM5354 SoC (MIPS 32 LE plattform).
> This patch implements the analog switch for LP PHYs according to the
> specs. It fixes the crash
>
> signed-off-by: Thomas Ilnseher <illth@gmx.de>
> ---
> diff -uNr b/drivers/net/wireless/b43/phy_lp.c
> a/drivers/net/wireless/b43/phy_lp.c
> --- b/drivers/net/wireless/b43/phy_lp.c 2009-09-14 06:14:18.000000000 +0200
> +++ a/drivers/net/wireless/b43/phy_lp.c 2009-09-14 21:03:15.158507573 +0200
> @@ -2228,6 +2228,16 @@
> return B43_TXPWR_RES_DONE;
> }
>
> +void b43_lpphy_op_switch_analog(struct b43_wldev *dev, bool on)
> +{
> + if (on) {
> + b43_phy_mask(dev, B43_LPPHY_AFE_CTL_OVR, 0xfff8);
> + } else {
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVRVAL, 0x0007);
> + b43_phy_set(dev, B43_LPPHY_AFE_CTL_OVR, 0x0007);
> + }
> +}
> +
> const struct b43_phy_operations b43_phyops_lp = {
> .allocate = b43_lpphy_op_allocate,
> .free = b43_lpphy_op_free,
> @@ -2239,7 +2249,7 @@
> .radio_read = b43_lpphy_op_radio_read,
> .radio_write = b43_lpphy_op_radio_write,
> .software_rfkill = b43_lpphy_op_software_rfkill,
> - .switch_analog = b43_phyop_switch_analog_generic,
> + .switch_analog = b43_lpphy_op_switch_analog,
> .switch_channel = b43_lpphy_op_switch_channel,
> .get_default_chan = b43_lpphy_op_get_default_chan,
> .set_rx_antenna = b43_lpphy_op_set_rx_antenna,
>
ack
--
Greetings, Michael.
^ permalink raw reply
* [RFC] ar9170usb: add ar9170 usbid
From: Christian Lamparter @ 2009-09-14 21:08 UTC (permalink / raw)
To: Fabian Lenz; +Cc: linux-wireless, Luis R. Rodriguez, Stephen.Chen
In-Reply-To: <200909142046.07525.lenz_fabian@yahoo.de>
Reported-by: Fabian Lenz <lenz_fabian@yahoo.de>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
Stephen,
- since 0x0cf3 is Atheros' vendor id - can you please lookup the real product
code name for 0x0cf3:0x1002.
I will take care of the re-spin and update the wiki.
Thanks,
Chr
---
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
index e0138ac..68b0bda 100644
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ b/drivers/net/wireless/ath/ar9170/usb.c
@@ -64,6 +64,8 @@ static struct usb_device_id ar9170_usb_ids[] = {
{ USB_DEVICE(0x0cf3, 0x9170) },
/* Atheros TG121N */
{ USB_DEVICE(0x0cf3, 0x1001) },
+ /* Atheros - Unknown Product Name - */
+ { USB_DEVICE(0x0cf3, 0x1002) },
/* Cace Airpcap NX */
{ USB_DEVICE(0xcace, 0x0300) },
/* D-Link DWA 160A */
^ permalink raw reply related
* [PATCH] p54usb: add Zcomax XG-705A usbid
From: Christian Lamparter @ 2009-09-14 21:08 UTC (permalink / raw)
To: Jari Jaakola; +Cc: linux-wireless, John W. Linville, stable
In-Reply-To: <6c9000d40909141238w2331a975tdaf0952487a3c76@mail.gmail.com>
This patch adds a new usbid for Zcomax XG-705A to the device table.
Cc: stable@kernel.org
Reported-by: Jari Jaakola <jari.jaakola@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
diff --git a/drivers/net/wireless/p54/p54usb.c b/drivers/net/wireless/p54/p54usb.c
index e44460f..17e1995 100644
--- a/drivers/net/wireless/p54/p54usb.c
+++ b/drivers/net/wireless/p54/p54usb.c
@@ -67,6 +67,7 @@ static struct usb_device_id p54u_table[] __devinitdata = {
{USB_DEVICE(0x0bf8, 0x1009)}, /* FUJITSU E-5400 USB D1700*/
{USB_DEVICE(0x0cde, 0x0006)}, /* Medion MD40900 */
{USB_DEVICE(0x0cde, 0x0008)}, /* Sagem XG703A */
+ {USB_DEVICE(0x0cde, 0x0015)}, /* Zcomax XG-705A */
{USB_DEVICE(0x0d8e, 0x3762)}, /* DLink DWL-G120 Cohiba */
{USB_DEVICE(0x124a, 0x4025)}, /* IOGear GWU513 (GW3887IK chip) */
{USB_DEVICE(0x1260, 0xee22)}, /* SMC 2862W-G version 2 */
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox