* Re: [PATCH 35/41] rt2800: prepare for rt2800lib addition
From: Ivo van Doorn @ 2009-11-05 19:07 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173617.28463.6733.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: prepare for rt2800lib addition
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 36/41] rt2800: add rt2800lib (part one)
From: Ivo van Doorn @ 2009-11-05 19:09 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173624.28463.78147.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part one)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 37/41] rt2x00: remove needless ifdefs from rt2x00leds.h
From: Ivo van Doorn @ 2009-11-05 19:09 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173633.28463.3378.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: remove needless ifdefs from rt2x00leds.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 38/41] rt2800: add rt2800lib (part two)
From: Ivo van Doorn @ 2009-11-05 19:10 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173640.28463.5454.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part two)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 39/41] rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
From: Ivo van Doorn @ 2009-11-05 19:10 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173650.28463.23162.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 40/41] rt2800: add rt2800lib (part three)
From: Ivo van Doorn @ 2009-11-05 19:11 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173657.28463.90918.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part three)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: [PATCH 41/41] rt2800: add rt2800lib (part four)
From: Ivo van Doorn @ 2009-11-05 19:12 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Gertjan van Wingerde, linux-kernel,
John W. Linville
In-Reply-To: <20091104173705.28463.81484.sendpatchset@localhost.localdomain>
On Wednesday 04 November 2009, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part four)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
^ permalink raw reply
* Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344
From: Pavel Machek @ 2009-11-05 19:19 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Johannes Berg, Dmitry Torokhov, David Miller, torvalds, linville,
linux-kernel, linux-wireless
In-Reply-To: <1257262187.3420.73.camel@localhost.localdomain>
On Wed 2009-11-04 00:29:47, Marcel Holtmann wrote:
> Hi Johannes,
>
> > > > I just think that it's a matter of courtesy that should be independent
> > > > from the release cycle to ask the author/maintainer by default, not as a
> > > > second thought ("unless [...] have other solution"). You can always CC
> > > > Linus and ask him to revert if you don't get a response.
> > > >
> > > > What's wrong with that? It doesn't actually delay the action, but it
> > > > makes the discussion much more friendly and cooperative instead of
> > > > giving the author and maintainer the feeling that their opinion only
> > > > matters as a second thought.
> > > >
> > >
> > > I think you are reading too much into who was addressed directly and who
> > > was "only" CCed...
> >
> > Maybe. But it seems to be happening pretty often recently that people
> > first ask for a revert and then for a fix, ignoring any thought that
> > might have gone into a particular commit...
>
> I have to agree here. It happens why too often lately. And this needs to
> stop. Otherwise why bother with subsystem maintainers? Just send
> everything to Linus directly and have him to review every line of code.
>
> Dmitry, this is not against you, but the proper way would have been to
> just mail linux-wireless about it and you would have gotten the same
> response to it than you got by including Linus and LKML. This blind CC
> to LKML is not helpful. It starts confusion and just increases the load
Yes, lkml cc *is* helpful, as he's probably not the only one hitting
that problem.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply
* Re: [PATCH] rtl8187: Remove deprecated 'qual' from returned RX status
From: Hin-Tak Leung @ 2009-11-05 19:21 UTC (permalink / raw)
To: Larry Finger
Cc: John W Linville, Hin-Tak Leung, Herton Ronaldo Krzesinski,
linux-wireless
In-Reply-To: <4af26c2f.v0dYcKOlddHI9QEQ%Larry.Finger@lwfinger.net>
On Thu, Nov 5, 2009 at 6:09 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> The qual member of ieee80211_rx_status is deprecated. As a result, this
> driver no longer needs to calculate a quality value.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: Hin-Tak Leung <htl10@users.sourceforge.net>
a bit busy lately. I'l give this a try soonest. BTW, well-done with
the oops on unplug.
Hin-Tak
> ---
>
> John,
>
> This is 2.6.33 material.
>
> Larry
> ---
>
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_dev.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_dev.c
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_dev.c
> @@ -320,7 +320,6 @@ static void rtl8187_rx_cb(struct urb *ur
> struct ieee80211_rx_status rx_status = { 0 };
> int rate, signal;
> u32 flags;
> - u32 quality;
> unsigned long f;
>
> spin_lock_irqsave(&priv->rx_queue.lock, f);
> @@ -338,10 +337,9 @@ static void rtl8187_rx_cb(struct urb *ur
> (typeof(hdr))(skb_tail_pointer(skb) - sizeof(*hdr));
> flags = le32_to_cpu(hdr->flags);
> /* As with the RTL8187B below, the AGC is used to calculate
> - * signal strength and quality. In this case, the scaling
> + * signal strength. In this case, the scaling
> * constants are derived from the output of p54usb.
> */
> - quality = 130 - ((41 * hdr->agc) >> 6);
> signal = -4 - ((27 * hdr->agc) >> 6);
> rx_status.antenna = (hdr->signal >> 7) & 1;
> rx_status.mactime = le64_to_cpu(hdr->mac_time);
> @@ -354,23 +352,18 @@ static void rtl8187_rx_cb(struct urb *ur
> * In testing, none of these quantities show qualitative
> * agreement with AP signal strength, except for the AGC,
> * which is inversely proportional to the strength of the
> - * signal. In the following, the quality and signal strength
> - * are derived from the AGC. The arbitrary scaling constants
> + * signal. In the following, the signal strength
> + * is derived from the AGC. The arbitrary scaling constants
> * are chosen to make the results close to the values obtained
> * for a BCM4312 using b43 as the driver. The noise is ignored
> * for now.
> */
> flags = le32_to_cpu(hdr->flags);
> - quality = 170 - hdr->agc;
> signal = 14 - hdr->agc / 2;
> rx_status.antenna = (hdr->rssi >> 7) & 1;
> rx_status.mactime = le64_to_cpu(hdr->mac_time);
> }
>
> - if (quality > 100)
> - quality = 100;
> - rx_status.qual = quality;
> - priv->quality = quality;
> rx_status.signal = signal;
> priv->signal = signal;
> rate = (flags >> 20) & 0xF;
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187.h
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187.h
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187.h
> @@ -119,7 +119,6 @@ struct rtl8187_priv {
> } hw_rev;
> struct sk_buff_head rx_queue;
> u8 signal;
> - u8 quality;
> u8 noise;
> u8 slot_time;
> u8 aifsn[4];
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply
* [PATCH] rt2x00: Don't queue ieee80211 work after USB removal
From: Ivo van Doorn @ 2009-11-05 19:22 UTC (permalink / raw)
To: John Linville; +Cc: users, linux-wireless, Sean Cross
From: Sean Cross <sean@chumby.com>
This prevents the rt2x00 driver from queueing ieee80211 work after the
USB card has been removed, preventing a kernel panic.
Signed-off-by: Sean Cross <sean@chumby.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 71761b3..73bbec5 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -815,6 +815,8 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
mutex_init(&rt2x00dev->csr_mutex);
+ set_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
+
/*
* Make room for rt2x00_intf inside the per-interface
* structure ieee80211_vif.
@@ -871,8 +873,6 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
rt2x00leds_register(rt2x00dev);
rt2x00debug_register(rt2x00dev);
- set_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
-
return 0;
exit:
diff --git a/drivers/net/wireless/rt2x00/rt2x00link.c b/drivers/net/wireless/rt2x00/rt2x00link.c
index c64db0b..c708d0b 100644
--- a/drivers/net/wireless/rt2x00/rt2x00link.c
+++ b/drivers/net/wireless/rt2x00/rt2x00link.c
@@ -362,8 +362,9 @@ void rt2x00link_start_tuner(struct rt2x00_dev *rt2x00dev)
rt2x00link_reset_tuner(rt2x00dev, false);
- ieee80211_queue_delayed_work(rt2x00dev->hw,
- &link->work, LINK_TUNE_INTERVAL);
+ if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
+ ieee80211_queue_delayed_work(rt2x00dev->hw,
+ &link->work, LINK_TUNE_INTERVAL);
}
void rt2x00link_stop_tuner(struct rt2x00_dev *rt2x00dev)
@@ -469,8 +470,10 @@ static void rt2x00link_tuner(struct work_struct *work)
* Increase tuner counter, and reschedule the next link tuner run.
*/
link->count++;
- ieee80211_queue_delayed_work(rt2x00dev->hw,
- &link->work, LINK_TUNE_INTERVAL);
+
+ if (test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
+ ieee80211_queue_delayed_work(rt2x00dev->hw,
+ &link->work, LINK_TUNE_INTERVAL);
}
void rt2x00link_register(struct rt2x00_dev *rt2x00dev)
diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c
index 5015448..f02b48a 100644
--- a/drivers/net/wireless/rt2x00/rt2x00usb.c
+++ b/drivers/net/wireless/rt2x00/rt2x00usb.c
@@ -47,6 +47,8 @@ int rt2x00usb_vendor_request(struct rt2x00_dev *rt2x00dev,
(requesttype == USB_VENDOR_REQUEST_IN) ?
usb_rcvctrlpipe(usb_dev, 0) : usb_sndctrlpipe(usb_dev, 0);
+ if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
+ return -ENODEV;
for (i = 0; i < REGISTER_BUSY_COUNT; i++) {
status = usb_control_msg(usb_dev, pipe, request, requesttype,
@@ -60,8 +62,10 @@ int rt2x00usb_vendor_request(struct rt2x00_dev *rt2x00dev,
* -ENODEV: Device has disappeared, no point continuing.
* All other errors: Try again.
*/
- else if (status == -ENODEV)
+ else if (status == -ENODEV) {
+ clear_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags);
break;
+ }
}
ERROR(rt2x00dev,
@@ -161,6 +165,9 @@ int rt2x00usb_regbusy_read(struct rt2x00_dev *rt2x00dev,
{
unsigned int i;
+ if (!test_bit(DEVICE_STATE_PRESENT, &rt2x00dev->flags))
+ return -ENODEV;
+
for (i = 0; i < REGISTER_BUSY_COUNT; i++) {
rt2x00usb_register_read_lock(rt2x00dev, offset, reg);
if (!rt2x00_get_field32(*reg, field))
^ permalink raw reply related
* Re: [PATCH] rtl8187: Remove deprecated 'qual' from returned RX status
From: Michael Buesch @ 2009-11-05 19:24 UTC (permalink / raw)
To: Hin-Tak Leung
Cc: Larry Finger, John W Linville, Hin-Tak Leung,
Herton Ronaldo Krzesinski, linux-wireless
In-Reply-To: <3ace41890911051121u16c7de8cpb97d0be12cdd0aa6@mail.gmail.com>
On Thursday 05 November 2009 20:21:39 Hin-Tak Leung wrote:
> > + * is derived from the AGC. The arbitrary scaling constants
> > * are chosen to make the results close to the values obtained
> > * for a BCM4312 using b43 as the driver. The noise is ignored
It's not really a good idea to take b43 for reference, because the values/scales
are chosen pretty arbitrarily in that driver. So you basically end up
with an arbitrary^2 value.
--
Greetings, Michael.
^ permalink raw reply
* Re: [PATCH] rtl8187: Remove deprecated 'qual' from returned RX status
From: Hin-Tak Leung @ 2009-11-05 19:43 UTC (permalink / raw)
To: Michael Buesch
Cc: Larry Finger, John W Linville, Hin-Tak Leung,
Herton Ronaldo Krzesinski, linux-wireless
In-Reply-To: <200911052024.32608.mb@bu3sch.de>
On Thu, Nov 5, 2009 at 7:24 PM, Michael Buesch <mb@bu3sch.de> wrote:
> On Thursday 05 November 2009 20:21:39 Hin-Tak Leung wrote:
>> > + * is derived from the AGC. The arbitrary scaling constants
>> > * are chosen to make the results close to the values obtained
>> > * for a BCM4312 using b43 as the driver. The noise is ignored
>
> It's not really a good idea to take b43 for reference, because the values/scales
> are chosen pretty arbitrarily in that driver. So you basically end up
> with an arbitrary^2 value.
>
> --
> Greetings, Michael.
>
Well, onee needs to start from something... many users, bug reporters
have often quoted 'I used driver/device X and it shows 90% strength,
yours shows 60%..." and vice versa. They don't know the numbers are
made up in both drivers, just differently :-).
Hin-Tak
^ permalink raw reply
* Re: [PATCH 31/41] rt2800usb: add RXINFO_DESC_SIZE definition
From: Gertjan van Wingerde @ 2009-11-05 20:33 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173547.28463.36376.sendpatchset@localhost.localdomain>
On 11/04/09 18:35, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800usb: add RXINFO_DESC_SIZE definition
>
> Add RXINFO_DESC_SIZE definition and use it instead of abusing
> RXD_DESC_SIZE one (TXD_DESC_SIZE and RXD_DESC_SIZE are specific
> to PCI version of the chipset).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 32/41] rt2800: fix duplication in header files
From: Gertjan van Wingerde @ 2009-11-05 20:37 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173554.28463.72619.sendpatchset@localhost.localdomain>
On 11/04/09 18:35, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: fix duplication in header files
>
> Updated debugging scripts are located here:
>
> http://www.kernel.org/pub/linux/kernel/people/bart/rt2800/scripts/
>
> (they also work fine with older drivers)
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 33/41] rt2800: fix comments in rt2800.h
From: Gertjan van Wingerde @ 2009-11-05 20:38 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173602.28463.31521.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: fix comments in rt2800.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 34/41] rt2x00: add support for different chipset interfaces
From: Gertjan van Wingerde @ 2009-11-05 20:39 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173610.28463.4270.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: add support for different chipset interfaces
>
> Enhance rt2x00 infrastructure by adding explicit information
> about used chipset interface to struct rt2x00_chip.
>
> The new field will be used by rt2800 drivers for rt2800 library.
>
> Also add commonly used rt2x00_intf_is_pci() and rt2x00_intf_is_usb()
> helpers to make code easier to read (noticed by Ivo van Doorn).
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 35/41] rt2800: prepare for rt2800lib addition
From: Gertjan van Wingerde @ 2009-11-05 20:43 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173617.28463.6733.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: prepare for rt2800lib addition
>
> Part of preparations for later code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 36/41] rt2800: add rt2800lib (part one)
From: Gertjan van Wingerde @ 2009-11-05 20:44 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173624.28463.78147.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part one)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 37/41] rt2x00: remove needless ifdefs from rt2x00leds.h
From: Gertjan van Wingerde @ 2009-11-05 20:45 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173633.28463.3378.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: remove needless ifdefs from rt2x00leds.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 38/41] rt2800: add rt2800lib (part two)
From: Gertjan van Wingerde @ 2009-11-05 20:50 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173640.28463.5454.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part two)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 39/41] rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
From: Gertjan van Wingerde @ 2009-11-05 20:51 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173650.28463.23162.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 40/41] rt2800: add rt2800lib (part three)
From: Gertjan van Wingerde @ 2009-11-05 20:56 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173657.28463.90918.sendpatchset@localhost.localdomain>
On 11/04/09 18:36, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part three)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
I wonder how many differences we are going to get between rt2800pci and rt2800usb with respect to register settings, but this is good enough for now. When the differences turn out to be too big, we can always move the affected functions into rt2800_ops and let each driver provide his own version.
^ permalink raw reply
* Re: [PATCH 41/41] rt2800: add rt2800lib (part four)
From: Gertjan van Wingerde @ 2009-11-05 20:57 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <20091104173705.28463.81484.sendpatchset@localhost.localdomain>
On 11/04/09 18:37, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] rt2800: add rt2800lib (part four)
>
> Code unification.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
For what it is worth:
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
^ permalink raw reply
* Re: [PATCH 00/41] rewritten rt2800 drivers
From: Gertjan van Wingerde @ 2009-11-05 20:59 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: linux-wireless, Ivo van Doorn, linux-kernel, John W. Linville
In-Reply-To: <14add3d10911041219j6ab25282re4f98d14029b1f68@mail.gmail.com>
On 11/04/09 21:19, Gertjan van Wingerde wrote:
> On Wed, Nov 4, 2009 at 6:31 PM, Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com> wrote:
>>
>> Hi,
>>
>> Here is the rt2800 rewrite in the form of patches (I've trimmed cc:
>> list considerably since I'm not sure whether most people really want
>> to see 40+ patches in their mailboxes).
>>
>>
>> There were some minor changes since yesterday:
>>
>> - two new patches were added at the top of tree fixing Kconfig help
>> entries of rt2800[pci,usb] drivers to be more helpful and to prevent
>> wasting people's time (I think that patch #1 should go to Linus'
>> tree as soon as possible, ditto for patch #2 and net-next tree)
>>
>> - patch descriptions were improved for many patches
>> (suggestion from Ingo)
>>
>> - rt2x00_intf_is_[pci,usb]() helpers for commonly used checks were
>> added to "rt2x00: add support for different chipset interfaces" patch
>> (suggestion from Ivo)
>>
>> - addition of separate rt2800 MAINTAINERS entry was dropped for now
>> because it stirred needless controversies distracting people from
>> technical issues (thanks to Julian Calaby for pointing this to me),
>> the goal of change was to make sure that people won't bother busy
>> rt2x00 maintainers about rt2800 tree so it is not a big deal anyway
>>
>>
>> The rt2800 tree has also been updated to reflect those changes
>> (old branch is still available as rt2800-v1 for reference):
>>
>> The following changes since commit fa867e7355a1bdcd9bf7d55ebe9296f5b9c4028a:
>> Juuso Oikarinen (1):
>> wl1271: Generalize command response reading
>>
>> are available in the git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git rt2800
>>
>> Bartlomiej Zolnierkiewicz (41):
>> rt2800usb: make Kconfig help entry more helpful
>> rt2800pci: make Kconfig help entry more helpful
>> rt2800usb: fix rt2800usb_rfcsr_read()
>> rt2800pci: fix crypto in TX frame
>> rt2800pci: fix comment about register access
>> rt2800pci: fix comment about IV/EIV fields
>> rt2x00: fix rt2x00usb_register_read() comment
>> rt2800usb: use rt2x00usb_register_multiwrite() to set key entries
>> rt2800usb: add rt2800_register_[read,write]() wrappers
>> rt2800pci: add rt2800_register_[read,write]() wrappers
>> rt2800usb: add rt2800_register_multi[read,write]() wrappers
>> rt2800pci: add rt2800_register_multi[read,write]() wrappers
>> rt2800usb: add rt2800_regbusy_read() wrapper
>> rt2800pci: add rt2800_regbusy_read() wrapper
>> rt2800usb: add rt2800_bbp_[read,write]() wrappers
>> rt2800pci: add rt2800_bbp_[read,write]() wrappers
>> rt2800usb: add rt2800_rfcsr_[read,write]() wrappers
>> rt2800pci: add rt2800_rfcsr_[read,write]() wrappers
>> rt2800usb: add rt2800_rf_[read,write]() wrappers
>> rt2800pci: add rt2800_rf_[read,write]() wrappers
>> rt2800usb: add rt2800_mcu_request() wrapper
>> rt2800pci: add rt2800_mcu_request() wrapper
>> rt2x00: add driver private field to struct rt2x00_dev
>> rt2800usb: convert to use struct rt2800_ops methods
>> rt2800pci: convert to use struct rt2800_ops methods
>> rt2x00: fix rt2x00usb_register_multiwrite() arguments
>> rt2x00: fix rt2x00usb_regbusy_read() arguments
>> rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
>> rt2800: add rt2800lib.h
>> rt2800usb: fix comments in rt2800usb.h
>> rt2800usb: add RXINFO_DESC_SIZE definition
>> rt2800: fix duplication in header files
>> rt2800: fix comments in rt2800.h
>> rt2x00: add support for different chipset interfaces
>> rt2800: prepare for rt2800lib addition
>> rt2800: add rt2800lib (part one)
>> rt2x00: remove needless ifdefs from rt2x00leds.h
>> rt2800: add rt2800lib (part two)
>> rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
>> rt2800: add rt2800lib (part three)
>> rt2800: add rt2800lib (part four)
>>
>> drivers/net/wireless/rt2x00/Kconfig | 16 +-
>> drivers/net/wireless/rt2x00/Makefile | 1 +
>> drivers/net/wireless/rt2x00/rt2800.h | 1816 ++++++++++++++++++++++++++++
>> drivers/net/wireless/rt2x00/rt2800lib.c | 1817 ++++++++++++++++++++++++++++
>> drivers/net/wireless/rt2x00/rt2800lib.h | 134 +++
>> drivers/net/wireless/rt2x00/rt2800pci.c | 1908 +++---------------------------
>> drivers/net/wireless/rt2x00/rt2800pci.h | 1780 ----------------------------
>> drivers/net/wireless/rt2x00/rt2800usb.c | 1828 ++---------------------------
>> drivers/net/wireless/rt2x00/rt2800usb.h | 1818 +----------------------------
>> drivers/net/wireless/rt2x00/rt2x00.h | 43 +
>> drivers/net/wireless/rt2x00/rt2x00leds.h | 4 -
>> drivers/net/wireless/rt2x00/rt2x00pci.h | 24 +-
>> drivers/net/wireless/rt2x00/rt2x00usb.c | 2 +-
>> drivers/net/wireless/rt2x00/rt2x00usb.h | 17 +-
>> 14 files changed, 4048 insertions(+), 7160 deletions(-)
>> create mode 100644 drivers/net/wireless/rt2x00/rt2800.h
>> create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.c
>> create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.h
>>
>
> Hi Bart,
>
> Many thanks for these patches.
>
> So far I have been able to go through the first 30 patches of the
> series. I'll finish the other 11 tomorrow (when I'm back home and have
> better facilities to review these more elaborate patches of the
> series).
> They all look fine to me, I only had a comment for patch 10.
>
> I've sent my ACKs for the remaining 29 I reviewed.
>
> I guess Ivo still has to review them as well, as, so far, he has been
> the one of the rt2x00 project to give the final ACK for inclusion,
> unless he indicates that he is fine with my assessments.
>
> ---
> Gertjan
> rt2x00 developer
>
OK. I have now completed my review of the remaining patches and have sent my ACKs for those.
^ permalink raw reply
* Re: [PATCH 00/41] rewritten rt2800 drivers
From: Luis R. Rodriguez @ 2009-11-05 21:06 UTC (permalink / raw)
To: Gertjan van Wingerde
Cc: Bartlomiej Zolnierkiewicz, linux-wireless, Ivo van Doorn,
linux-kernel, John W. Linville
In-Reply-To: <4AF33C9E.6090609@gmail.com>
On Thu, Nov 5, 2009 at 12:59 PM, Gertjan van Wingerde
<gwingerde@gmail.com> wrote:
> On 11/04/09 21:19, Gertjan van Wingerde wrote:
>> On Wed, Nov 4, 2009 at 6:31 PM, Bartlomiej Zolnierkiewicz
>> <bzolnier@gmail.com> wrote:
>>>
>>> Hi,
>>>
>>> Here is the rt2800 rewrite in the form of patches (I've trimmed cc:
>>> list considerably since I'm not sure whether most people really want
>>> to see 40+ patches in their mailboxes).
>>>
>>>
>>> There were some minor changes since yesterday:
>>>
>>> - two new patches were added at the top of tree fixing Kconfig help
>>> entries of rt2800[pci,usb] drivers to be more helpful and to prevent
>>> wasting people's time (I think that patch #1 should go to Linus'
>>> tree as soon as possible, ditto for patch #2 and net-next tree)
>>>
>>> - patch descriptions were improved for many patches
>>> (suggestion from Ingo)
>>>
>>> - rt2x00_intf_is_[pci,usb]() helpers for commonly used checks were
>>> added to "rt2x00: add support for different chipset interfaces" patch
>>> (suggestion from Ivo)
>>>
>>> - addition of separate rt2800 MAINTAINERS entry was dropped for now
>>> because it stirred needless controversies distracting people from
>>> technical issues (thanks to Julian Calaby for pointing this to me),
>>> the goal of change was to make sure that people won't bother busy
>>> rt2x00 maintainers about rt2800 tree so it is not a big deal anyway
>>>
>>>
>>> The rt2800 tree has also been updated to reflect those changes
>>> (old branch is still available as rt2800-v1 for reference):
>>>
>>> The following changes since commit fa867e7355a1bdcd9bf7d55ebe9296f5b9c4028a:
>>> Juuso Oikarinen (1):
>>> wl1271: Generalize command response reading
>>>
>>> are available in the git repository at:
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git rt2800
>>>
>>> Bartlomiej Zolnierkiewicz (41):
>>> rt2800usb: make Kconfig help entry more helpful
>>> rt2800pci: make Kconfig help entry more helpful
>>> rt2800usb: fix rt2800usb_rfcsr_read()
>>> rt2800pci: fix crypto in TX frame
>>> rt2800pci: fix comment about register access
>>> rt2800pci: fix comment about IV/EIV fields
>>> rt2x00: fix rt2x00usb_register_read() comment
>>> rt2800usb: use rt2x00usb_register_multiwrite() to set key entries
>>> rt2800usb: add rt2800_register_[read,write]() wrappers
>>> rt2800pci: add rt2800_register_[read,write]() wrappers
>>> rt2800usb: add rt2800_register_multi[read,write]() wrappers
>>> rt2800pci: add rt2800_register_multi[read,write]() wrappers
>>> rt2800usb: add rt2800_regbusy_read() wrapper
>>> rt2800pci: add rt2800_regbusy_read() wrapper
>>> rt2800usb: add rt2800_bbp_[read,write]() wrappers
>>> rt2800pci: add rt2800_bbp_[read,write]() wrappers
>>> rt2800usb: add rt2800_rfcsr_[read,write]() wrappers
>>> rt2800pci: add rt2800_rfcsr_[read,write]() wrappers
>>> rt2800usb: add rt2800_rf_[read,write]() wrappers
>>> rt2800pci: add rt2800_rf_[read,write]() wrappers
>>> rt2800usb: add rt2800_mcu_request() wrapper
>>> rt2800pci: add rt2800_mcu_request() wrapper
>>> rt2x00: add driver private field to struct rt2x00_dev
>>> rt2800usb: convert to use struct rt2800_ops methods
>>> rt2800pci: convert to use struct rt2800_ops methods
>>> rt2x00: fix rt2x00usb_register_multiwrite() arguments
>>> rt2x00: fix rt2x00usb_regbusy_read() arguments
>>> rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
>>> rt2800: add rt2800lib.h
>>> rt2800usb: fix comments in rt2800usb.h
>>> rt2800usb: add RXINFO_DESC_SIZE definition
>>> rt2800: fix duplication in header files
>>> rt2800: fix comments in rt2800.h
>>> rt2x00: add support for different chipset interfaces
>>> rt2800: prepare for rt2800lib addition
>>> rt2800: add rt2800lib (part one)
>>> rt2x00: remove needless ifdefs from rt2x00leds.h
>>> rt2800: add rt2800lib (part two)
>>> rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
>>> rt2800: add rt2800lib (part three)
>>> rt2800: add rt2800lib (part four)
>>>
>>> drivers/net/wireless/rt2x00/Kconfig | 16 +-
>>> drivers/net/wireless/rt2x00/Makefile | 1 +
>>> drivers/net/wireless/rt2x00/rt2800.h | 1816 ++++++++++++++++++++++++++++
>>> drivers/net/wireless/rt2x00/rt2800lib.c | 1817 ++++++++++++++++++++++++++++
>>> drivers/net/wireless/rt2x00/rt2800lib.h | 134 +++
>>> drivers/net/wireless/rt2x00/rt2800pci.c | 1908 +++---------------------------
>>> drivers/net/wireless/rt2x00/rt2800pci.h | 1780 ----------------------------
>>> drivers/net/wireless/rt2x00/rt2800usb.c | 1828 ++---------------------------
>>> drivers/net/wireless/rt2x00/rt2800usb.h | 1818 +----------------------------
>>> drivers/net/wireless/rt2x00/rt2x00.h | 43 +
>>> drivers/net/wireless/rt2x00/rt2x00leds.h | 4 -
>>> drivers/net/wireless/rt2x00/rt2x00pci.h | 24 +-
>>> drivers/net/wireless/rt2x00/rt2x00usb.c | 2 +-
>>> drivers/net/wireless/rt2x00/rt2x00usb.h | 17 +-
>>> 14 files changed, 4048 insertions(+), 7160 deletions(-)
>>> create mode 100644 drivers/net/wireless/rt2x00/rt2800.h
>>> create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.c
>>> create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.h
>>>
>>
>> Hi Bart,
>>
>> Many thanks for these patches.
>>
>> So far I have been able to go through the first 30 patches of the
>> series. I'll finish the other 11 tomorrow (when I'm back home and have
>> better facilities to review these more elaborate patches of the
>> series).
>> They all look fine to me, I only had a comment for patch 10.
>>
>> I've sent my ACKs for the remaining 29 I reviewed.
>>
>> I guess Ivo still has to review them as well, as, so far, he has been
>> the one of the rt2x00 project to give the final ACK for inclusion,
>> unless he indicates that he is fine with my assessments.
>>
>> ---
>> Gertjan
>> rt2x00 developer
>>
>
> OK. I have now completed my review of the remaining patches and have sent my ACKs for those.
A little summary would be nice for those who don't want to read single
line acks/nacks.
Luis
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox