* [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events
From: Colin King @ 2017-12-07 10:20 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
size of the array. Improvement suggested by coccinelle.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
index 763e8ba6b178..7e01981bc5c8 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
@@ -16049,8 +16049,7 @@ static void wlc_phy_workarounds_nphy_gainctrl(struct brcms_phy *pi)
wlc_phy_set_rfseq_nphy(pi, NPHY_RFSEQ_UPDATEGAINU,
rfseq_updategainu_events,
rfseq_updategainu_dlys,
- sizeof(rfseq_updategainu_events) /
- sizeof(rfseq_updategainu_events[0]));
+ ARRAY_SIZE(rfseq_updategainu_events));
mod_phy_reg(pi, 0x153, (0xff << 8), (90 << 8));
--
2.14.1
^ permalink raw reply related
* Re: [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events
From: Arend van Spriel @ 2017-12-07 10:30 UTC (permalink / raw)
To: Colin King, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, Kalle Valo, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Cc: kernel-janitors, linux-kernel
In-Reply-To: <20171207102047.21635-1-colin.king@canonical.com>
On 12/7/2017 11:20 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
> size of the array. Improvement suggested by coccinelle.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
^ permalink raw reply
* RE: [EXT] Re: [PATCH 1/3] mwifiex: cleanup rx_pkt_lock usage in 11n_rxreorder.c
From: Ganapathi Bhat @ 2017-12-07 10:29 UTC (permalink / raw)
To: Doug Anderson, Brian Norris
Cc: linux-wireless@vger.kernel.org, Cathy Luo, Xinming Hu,
Zhiyuan Yang, James Cao, Mangesh Malusare,
Karthik Doddayennegere Ananthapadmanabha
In-Reply-To: <CAD=FV=ViNE5gnDTexYKpMN_Bb1bqZHwnJQ0h64=Rc8x-_1=iFQ@mail.gmail.com>
SGkgRG91Zy9Ccmlhbg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IGRp
YW5kZXJzQGdvb2dsZS5jb20gW21haWx0bzpkaWFuZGVyc0Bnb29nbGUuY29tXSBPbiBCZWhhbGYg
T2YNCj4gRG91ZyBBbmRlcnNvbg0KPiBTZW50OiBXZWRuZXNkYXksIE5vdmVtYmVyIDA4LCAyMDE3
IDI6NDUgQU0NCj4gVG86IEdhbmFwYXRoaSBCaGF0DQo+IENjOiBCcmlhbiBOb3JyaXM7IGxpbnV4
LXdpcmVsZXNzQHZnZXIua2VybmVsLm9yZzsgQ2F0aHkgTHVvOyBYaW5taW5nIEh1Ow0KPiBaaGl5
dWFuIFlhbmc7IEphbWVzIENhbzsgTWFuZ2VzaCBNYWx1c2FyZTsgS2FydGhpayBEb2RkYXllbm5l
Z2VyZQ0KPiBBbmFudGhhcGFkbWFuYWJoYQ0KPiBTdWJqZWN0OiBSZTogW0VYVF0gUmU6IFtQQVRD
SCAxLzNdIG13aWZpZXg6IGNsZWFudXAgcnhfcGt0X2xvY2sgdXNhZ2UgaW4NCj4gMTFuX3J4cmVv
cmRlci5jDQo+DQo+IEhpLA0KPg0KPiBPbiBUdWUsIE5vdiA3LCAyMDE3IGF0IDg6MjUgQU0sIEdh
bmFwYXRoaSBCaGF0IDxnYmhhdEBtYXJ2ZWxsLmNvbT4NCj4gd3JvdGU6DQo+ID4gSGkgRG91Zy9C
cmlhbiwNCj4gPg0KPiA+IFRoYW5rcyBhIGxvdCBmb3IgdGhlIGNvbW1lbnRzIGFuZCB0aGUgZGlz
Y3Vzc2lvbi4gRmlyc3Qgb2YgYWxsIHdlIHdpbGwgYWJvcnQNCj4gdGhlIGNoYW5nZSBhZGRlZCBi
eSB0aGlzIHBhdGNoIGFzIHdlIGRvbid0IG5lZWQgcnhfcGt0X2xvY2sgYWNxdWlyZWQgdG8NCj4g
cHJvdGVjdCB0aGUgZGVsZXRlZCBpdGVtLiAgTmV4dCwgd2Ugd2lsbCBwcmVwYXJlIGJlbG93IGNo
YW5nZXMgdG8gYWRkcmVzcw0KPiB0aGUgY29uY2VybnMgZGlzY3Vzc2VkOg0KPiA+IDEuIE1vdmUg
cnhfcGt0X2xvY2sgZnJvbSBtd2lmaWV4X3ByaXZhdGUgdG8gcnhfcmVvcmRlcl90YmwNCj4NCj4g
Li4ub3IsIHBvc3NpYmx5LCByZW1vdmUgcnhfcGt0X2xvY2sgY29tcGxldGVseS4gIFNlZSBteSBv
dGhlciByZXNwb25zZS4uLg0KQWZ0ZXIgY2hlY2tpbmcgdGhlIGZsb3csIEkgYW0gdGhpbmtpbmcg
b2YgcmVtb3ZpbmcgYmVsb3cgMyBzcGluIGxvY2tzOg0KcnhfcmVvcmRlcl90YmxfbG9jaw0Kcnhf
cGt0X2xvY2sNCnR4X2JhX3N0cmVhbV90YmxfbG9jaw0KQXMgeW91IGJvdGggaGF2ZSBwb2ludGVk
IGVhcmxpZXIsIHRoZXkgdXNlZCBieSBtYWluIHRocmVhZCBhbmQgb2NjYXNpb25hbGx5IGJ5IGNm
ZzgwMjExIChmb3IgVERMUyBjb25maWd1cmF0aW9uKS4NCkNhbiB5b3UgcGxlYXNlIGNvbW1lbnQg
b24gdGhpcyBjaGFuZ2U/IElzIGl0IE9LIHRvIGlnbm9yZSBjZmc4MDIxMSBoZXJlLg0KPg0KPiAt
RG91Zw0KDQpSZWdhcmRzLA0KR2FuYXBhdGhpDQo=
^ permalink raw reply
* Re: [PATCH 00/10] brcmfmac: restructuring sdio access functions
From: Kalle Valo @ 2017-12-07 10:49 UTC (permalink / raw)
To: Arend van Spriel; +Cc: linux-wireless
In-Reply-To: <5A2902DE.3050206@broadcom.com>
Arend van Spriel <arend.vanspriel@broadcom.com> writes:
> On 12/7/2017 9:49 AM, Kalle Valo wrote:
>> Arend van Spriel <arend.vanspriel@broadcom.com> writes:
>>
>>> On 11/13/2017 9:35 PM, Arend van Spriel wrote:
>>>> These patches were originally submitted by Ian Molton a while ago so decided
>>>> to resubmit them. This is a first series of 10 patches. Tested using BCM4354
>>>> device which showed no regression.
>>>>
>>>> It is intended for 4.16 (no rush ;-) ) and applies to the master branch of
>>>> the wireless-drivers-next repository.
>>>
>>> Hi Kalle,
>>>
>>> I have follow-up series on this one. If you plan to take it today or
>>> tomorrow, I can hold the follow-up a bit more.
>>
>> I'm hoping to apply these today.
>>
>
> btw. my neighbors put out the Finnish flag.
Cool!
> Was that about your independence? Not a yearly event, or is it?
December 6th is the independence day in Finland and that's a yearly
event, a public holiday etc. But this year was special as it was 100
years from gaining our independence.
So yesterday, instead of applying patches, I was looking at people
shaking hands[1] on TV. Yes, we are weird ;)
[1] https://en.wikipedia.org/wiki/Independence_Day_Reception_(in_Finland)
--
Kalle Valo
^ permalink raw reply
* Re: [01/10] brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()
From: Kalle Valo @ 2017-12-07 13:12 UTC (permalink / raw)
To: Arend Van Spriel; +Cc: linux-wireless, Ian Molton, Arend van Spriel
In-Reply-To: <1510605347-7629-2-git-send-email-arend.vanspriel@broadcom.com>
Arend Van Spriel <arend.vanspriel@broadcom.com> wrote:
> From: Ian Molton <ian@mnementh.co.uk>
>
> All the other IO functions are the other way round in this
> driver. Make this one match.
>
> Signed-off-by: Ian Molton <ian@mnementh.co.uk>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
10 patches applied to wireless-drivers-next.git, thanks.
1fd3ae124d5e brcmfmac: Fix parameter order in brcmf_sdiod_f0_writeb()
1e6f676f43aa brcmfmac: Register sizes on hardware are not dependent on compiler types
0fcc9fe00484 brcmfmac: Split brcmf_sdiod_regrw_helper() up.
b9b0d290bc0c brcmfmac: Clean up brcmf_sdiod_set_sbaddr_window()
ea243e9077b3 brcmfmac: Remove dead IO code
4a3338ba2a74 brcmfmac: Remove bandaid for SleepCSR
993a98a42e6e brcmfmac: Remove brcmf_sdiod_request_data()
3508a056a1f4 brcmfmac: Fix asymmetric IO functions.
12e3e74e2820 brcmfmac: Remove noisy debugging.
dd8a2d49e4ed brcmfmac: Rename bcmerror to err
--
https://patchwork.kernel.org/patch/10056667/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: rtlwifi: Convert individual interrupt results to struct
From: Kalle Valo @ 2017-12-07 13:14 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless, Larry Finger, Ping-Ke Shih
In-Reply-To: <20171112200645.26284-1-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> With the RTL8822BE and later devices, the number of interrupt vectors
> has grown from 2 to 4. At this point, saving and passing those vectors
> in a struct makes more sense than using individual scaler variables.
>
> In two of the drivers, code to process the second of the interrupt
> registers was included, but commented out. This patch removes those
> useless sections.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
78aa6012033f rtlwifi: Convert individual interrupt results to struct
--
https://patchwork.kernel.org/patch/10054899/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [1/3] rtlwifi: Reduce IO in RX interrupt to boost throughput
From: Kalle Valo @ 2017-12-07 13:15 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: Larry.Finger, linux-wireless, steventing, yhchuang
In-Reply-To: <20171113093935.20431-2-pkshih@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> wrote:
> From: Ping-Ke Shih <pkshih@realtek.com>
>
> Check remaining count of RX packets cost a lot of CPU time, so only update
> when the counter decreases to zero. In old flow, the counter was updated
> once a RX packet is received.
>
> Signed-off-by: Steven Ting <steventing@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
3 patches applied to wireless-drivers-next.git, thanks.
fb9829e90dcd rtlwifi: Reduce IO in RX interrupt to boost throughput
dc9682a0cca5 rtlwifi: fix the wrong size to calculate fifo space
cf54622c8076 rtlwifi: cleanup the code that check whether TX ring is available
--
https://patchwork.kernel.org/patch/10055429/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: rtlwifi: rtl818x: remove redundant check for cck_power > 15
From: Kalle Valo @ 2017-12-07 13:16 UTC (permalink / raw)
To: Colin Ian King
Cc: Hin-Tak Leung, Larry Finger, linux-wireless, netdev,
kernel-janitors, linux-kernel
In-Reply-To: <20171114170145.3987-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> cck_poweri cannot be greated than 15 as is derived from the bottom 4 bits
> from riv->channels[channel - 1].hw_value & 0xf. Hence the check for it
> being greater than 15 is redundant and can be removed.
>
> Detected by CoverityScan, CID#744303 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
45d9d1a12efa rtlwifi: rtl818x: remove redundant check for cck_power > 15
--
https://patchwork.kernel.org/patch/10057925/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v2] mwl8k: Expand non-DFS 5G channels
From: Kalle Valo @ 2017-12-07 13:17 UTC (permalink / raw)
To: Weixiao Zhang
Cc: Lennert Buytenhek, Johannes Berg, Andrew Zaborowski,
Weixiao Zhang, linux-wireless, netdev, linux-kernel
In-Reply-To: <20171116075955.qbbqhwqn4lys3xco@ximibaba.lan>
Weixiao Zhang <waveletboy@gmail.com> wrote:
> Add non-DFS 5G upper channels (149-165) besides existed 4 lower channels
> (36, 40, 44, 48).
>
> Signed-off-by: Weixiao Zhang <waveletboy@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
4628257bf300 mwl8k: Expand non-DFS 5G channels
--
https://patchwork.kernel.org/patch/10060831/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: wlcore: use boottime for fw time sync
From: Kalle Valo @ 2017-12-07 13:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: y2038, Arnd Bergmann, Johannes Berg, Arend Van Spriel,
Iain Hunter, Reizer, Eyal, David S. Miller, linux-wireless,
netdev, linux-kernel
In-Reply-To: <20171127114903.2779545-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> Using getnstimeofday()/timespec_to_ns() causes an overflow on 32-bit
> architectures in 2038, and may suffer from time jumps due to
> settimeofday() or leap seconds.
>
> I don't see a reason why this needs to be UTC, so either monotonic
> or boot time would be better here. Assuming that the fw time keeps
> running during suspend, boottime is better than monotonic, and
> ktime_get_boot_ns() will also save the additional conversion to
> nanoseconds.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to wireless-drivers-next.git, thanks.
99f6996d4cba wlcore: use boottime for fw time sync
--
https://patchwork.kernel.org/patch/10076691/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: wlcore: allow elp during wowlan suspend
From: Kalle Valo @ 2017-12-07 13:24 UTC (permalink / raw)
To: Reizer, Eyal
Cc: Greg Kroah-Hartman, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B364A3796@DFRE01.ent.ti.com>
"Reizer, Eyal" <eyalr@ti.com> wrote:
> when enabling wowlan and entering suspend the last write to the firmware
> allowing it to go into elp mode was not completing before suspend, leaving
> the firmware running in full active mode consuming high power.
> Use an immediate call instead of a work queue for this last access
> allowing the firmware to go into power save during wowlan uspend.
>
> Signed-off-by: Eyal Reizer <eyalr@ti.com>
Patch applied to wireless-drivers-next.git, thanks.
37bf241b8e7b wlcore: allow elp during wowlan suspend
--
https://patchwork.kernel.org/patch/10078927/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [V2] wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM
From: Kalle Valo @ 2017-12-07 13:24 UTC (permalink / raw)
To: Colin Ian King; +Cc: linux-wireless, netdev, kernel-janitors, linux-kernel
In-Reply-To: <20171201100258.10029-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in error message text. Also remove the
> error message on an kzalloc failure as this is redundant.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
c4ee30a280b1 wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM
--
https://patchwork.kernel.org/patch/10086741/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: rsi: fix memory leak on buf and usb_reg_buf
From: Kalle Valo @ 2017-12-07 13:26 UTC (permalink / raw)
To: Colin Ian King
Cc: Amitkumar Karwar, Prameela Rani Garnepudi, linux-wireless, netdev,
kernel-janitors, linux-kernel
In-Reply-To: <20171116173918.3030-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the cases where len is too long, the error return path fails to
> kfree allocated buffers buf and usb_reg_buf. The simplest fix is to
> perform the sanity check on len before the allocations to avoid having
> to do the kfree'ing in the first place.
>
> Detected by CoverityScan, CID#1452258,1452259 ("Resource Leak")
>
> Fixes: 59f73e2ae185 ("rsi: check length before USB read/write register")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
c4ee30a280b1 wlcore, wl1251: fix spelling: "Couldnt" -> "Couldn't" and remove error on -ENOMEM
--
https://patchwork.kernel.org/patch/10061619/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v3] mwifiex: do not support change AP interface to station mode
From: Kalle Valo @ 2017-12-07 13:30 UTC (permalink / raw)
To: Xinming Hu
Cc: Linux Wireless, Brian Norris, Dmitry Torokhov, rajatja,
Zhiyuan Yang, Tim Song, Cathy Luo, James Cao, Ganapathi Bhat,
Ellie Reeves, Xinming Hu
In-Reply-To: <1511333731-23474-1-git-send-email-huxm@marvell.com>
Xinming Hu <huxm@marvell.com> wrote:
> Firmware do not support change interface from micro-ap mode
> to station mode, forbid this operation
>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
71121e420d75 mwifiex: do not support change AP interface to station mode
--
https://patchwork.kernel.org/patch/10069839/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: mwifiex: cfg80211: do not change virtual interface during scan processing
From: Kalle Valo @ 2017-12-07 13:31 UTC (permalink / raw)
To: Xinming Hu
Cc: Linux Wireless, Brian Norris, Dmitry Torokhov, rajatja,
Zhiyuan Yang, Tim Song, Cathy Luo, James Cao, Ganapathi Bhat,
Ellie Reeves, Limin Zhu, Xinming Hu
In-Reply-To: <1512022954-10129-1-git-send-email-huxm@marvell.com>
Xinming Hu <huxm@marvell.com> wrote:
> From: Limin Zhu <liminzhu@marvell.com>
>
> (1) Change virtual interface operation in cfg80211 process reset and
> reinitilize private data structure.
> (2) Scan result event processed in main process will dereference private
> data structure concurrently, ocassionly crash the kernel.
>
> The cornel case could be trigger by below steps:
> (1) wpa_cli mlan0 scan
> (2) ./hostapd mlan0.conf
>
> Cfg80211 asynchronous scan procedure is not all the time operated
> under rtnl lock, here we add the protect to serialize the cfg80211
> scan and change_virtual interface operation.
>
> Signed-off-by: Limin Zhu <liminzhu@marvell.com>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
Patch applied to wireless-drivers-next.git, thanks.
c61cfe49f0f0 mwifiex: cfg80211: do not change virtual interface during scan processing
--
https://patchwork.kernel.org/patch/10084299/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v3] bcma: Adjust block comment
From: Kalle Valo @ 2017-12-07 13:35 UTC (permalink / raw)
To: Ashish Kalra
Cc: zajec5, himanshujha199640, linux-wireless, linux-kernel,
eashishkalra
In-Reply-To: <20171128155458.1036-1-eashishkalra@gmail.com>
Ashish Kalra <eashishkalra@gmail.com> wrote:
> use * for block comments in multiple lines according to kernel coding
> style
>
> Reported by: checkpatch.pl
>
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
a765c8fdc869 bcma: Adjust block comment
--
https://patchwork.kernel.org/patch/10080747/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v8,1/3] dt-bindings: net: add mt76 wireless device binding
From: Kalle Valo @ 2017-12-07 13:37 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless
In-Reply-To: <20171121095053.82673-2-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> wrote:
> Add documentation describing how device tree can be used to configure
> wireless chips supported by the mt76 driver.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
3 patches applied to wireless-drivers-next.git, thanks.
9402f8eb9bed dt-bindings: net: add mt76 wireless device binding
17f1de56df05 mt76: add common code shared between multiple chipsets
7bc04215a66b mt76: add driver code for MT76x2e
--
https://patchwork.kernel.org/patch/10067881/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] mt76: fix debugfs_simple_attr.cocci warnings
From: Kalle Valo @ 2017-12-07 13:42 UTC (permalink / raw)
To: kbuild test robot; +Cc: Felix Fietkau, kbuild-all, linux-wireless
In-Reply-To: <20171123072723.GA16326@lkp-ne02>
kbuild test robot <lkp@intel.com> writes:
> drivers/net/wireless/mediatek/mt76/debugfs.c:36:0-23: WARNING: fops_regval should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
>
> Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e")
> CC: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
I would like to apply this but the From field doesn't match the s-o-b
line. This patch is created automatically, right? I think the best is
that if you modify your script to add this to the beginning of the
commit log:
From: Fengguang Wu <fengguang.wu@intel.com>
That way From and s-o-b match and you can continue to submit it from the
lkp address.
--
Kalle Valo
^ permalink raw reply
* Re: [PATCH] mt76: fix returnvar.cocci warnings
From: Kalle Valo @ 2017-12-07 13:43 UTC (permalink / raw)
To: kbuild test robot; +Cc: Felix Fietkau, kbuild-all, linux-wireless
In-Reply-To: <20171123072724.GA16591@lkp-ne02>
kbuild test robot <lkp@intel.com> writes:
> drivers/net/wireless/mediatek/mt76/mt76x2_main.c:86:5-8: Unneeded variable: "ret". Return "0" on line 112
>
>
> Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> Fixes: a5f6039c8f9c ("mt76: add driver code for MT76x2e")
> CC: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Here als the same problem with mismatching From and s-o-b lines.
--
Kalle Valo
^ permalink raw reply
* Re: ssb: make SSB a menuconfig to ease disabling it all
From: Kalle Valo @ 2017-12-07 13:45 UTC (permalink / raw)
To: Vincent Legoll; +Cc: m, linux-wireless, linux-kernel, Vincent Legoll
In-Reply-To: <20171204222744.8817-2-vincent.legoll@gmail.com>
Vincent Legoll <vincent.legoll@gmail.com> wrote:
> No need to get into the submenu to disable all SSB-related
> config entries.
>
> This makes it easier to disable all SSB config options
> without entering the submenu. It will also enable one
> to see that en/dis-abled state from the outside menu.
>
> This is only intended to change menuconfig UI, not change
> the config dependencies.
>
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
8c9fdd7687d9 ssb: make SSB a menuconfig to ease disabling it all
--
https://patchwork.kernel.org/patch/10091683/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [v1] brcmfmac: Avoid build error with make W=1
From: Kalle Valo @ 2017-12-07 13:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng, brcm80211-dev-list.pdl, brcm80211-dev-list,
linux-wireless, netdev, Andy Shevchenko
In-Reply-To: <20171123155704.44878-1-andriy.shevchenko@linux.intel.com>
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for
> the first run, all next ones are okay.
>
> CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union!
> scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed
>
> Seems like something happened with W=1 and wrong kernel doc format.
> As a quick fix remove dubious /** in the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers.git, thanks.
51ef7925e106 brcmfmac: Avoid build error with make W=1
--
https://patchwork.kernel.org/patch/10073021/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: pull-request: iwlwifi 2017-12-05
From: Kalle Valo @ 2017-12-07 13:52 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless, linuxwifi
In-Reply-To: <1512484624.4827.187.camel@coelho.fi>
Luca Coelho <luca@coelho.fi> writes:
> Here is my third set of fixes for 4.15. The most important fixes are
> for the new 9000 series where we were not handling some offloads
> correctly and secure connections were totally broken. There is also 4
> new PCI IDs and an ROC fix on P2P. More details in the tag
> description.
>
> I have sent this out before and kbuildbot didn't find any issues.
> Please let me know if there are any issues.
>
> Cheers,
> Luca.
>
>
> The following changes since commit 5c3de777bdaf48bd0cfb43097c0d0fb85056cab7:
>
> brcmfmac: change driver unbind order of the sdio function devices (2017-12-02 17:22:47 +0200)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes.git tags/iwlwifi-for-kalle-2017-12-05
>
> for you to fetch changes up to bf19037074e770aad74b3b90f37b8b98db3f3748:
>
> iwlwifi: mvm: mark MIC stripped MPDUs (2017-12-05 16:23:30 +0200)
>
> ----------------------------------------------------------------
> Third batch of iwlwifi patches intended for 4.15.
>
> * Tell mac80211 when the MAC has been stripped (9000 series);
> * Tell mac80211 when the IVC has been stripped (9000 series);
> * Add 2 new PCI IDs, one for 9000 and one for 22000;
> * Fix a queue hang due during ROC.
>
> ----------------------------------------------------------------
Pulled, thanks.
--
Kalle Valo
^ permalink raw reply
* Re: ath6kl: remove redundant variable ies_len
From: Kalle Valo @ 2017-12-07 14:21 UTC (permalink / raw)
To: Kenneth Lu; +Cc: linux-wireless, ath6kl
In-Reply-To: <20171126053818.GA6602@blackstone>
Kenneth Lu <kuohsianglu@gmail.com> wrote:
> To get rid of W=1 warning: variable ‘ies_len’ set but not used.
> Variable ies_len is being assigned but never read.
>
> Signed-off-by: Kenneth Lu <kuohsianglu@gmail.com>
> Reviewed-by: Steve deRosier <derosier@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
d786ebb2f59b ath6kl: remove redundant variable ies_len
--
https://patchwork.kernel.org/patch/10075235/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: ath10k: use 64-bit crash dump timestamps
From: Kalle Valo @ 2017-12-07 14:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: y2038, Arnd Bergmann, Waldemar Rymarkiewicz, Erik Stromdahl,
Mohammed Shafi Shajakhan, Sarada Prasanna Garnayak,
Venkateswara Naralasetty, Marcin Rokicki, ath10k, linux-wireless,
netdev, linux-kernel
In-Reply-To: <20171127115113.2831506-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> The dump format uses 64-bit timestamps already, but calling
> getnstimeofday() only returns a 32-bit number on 32-bit architectures,
> so that will overflow in y2038.
>
> This changes it to use ktime_get_real_ts64() instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
dafa42036012 ath10k: use 64-bit crash dump timestamps
--
https://patchwork.kernel.org/patch/10076697/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile
From: Kalle Valo @ 2017-12-07 14:30 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Matthias Schiffer, ath9k-devel, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, nbd@nbd.name
In-Reply-To: <20171127193516.682827ea@cakuba.netronome.com>
Jakub Kicinski <kubakici@wp.pl> writes:
> On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote:
>> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
>> ---
>> drivers/net/wireless/ath/ath9k/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wirel=
ess/ath/ath9k/Makefile
>> index 36a40ffdce15..90e4a341076c 100644
>> --- a/drivers/net/wireless/ath/ath9k/Makefile
>> +++ b/drivers/net/wireless/ath/ath9k/Makefile
>> @@ -59,7 +59,7 @@ obj-$(CONFIG_ATH9K_HW) +=3D ath9k_hw.o
>> obj-$(CONFIG_ATH9K_COMMON) +=3D ath9k_common.o
>> ath9k_common-y:=3D common.o \
>> common-init.o \
>> - common-beacon.o \
>> + common-beacon.o
>> =20
>
> It's not necessarily stray, there is nothing on the next line so it's
> OK, and if you add \ at the end of all lines, you don't have to touch
> the last line every time you add/remove something. Sort of like
> putting a , after last enum value.
I agree with Jakub, I think the backslash is there on purpose so I
dropped this patch.
--=20
Kalle Valo=
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox