* Re: [PATCH 0/3] brcmfmac: keep wiphy during PCIe driver lifetime
From: Arend Van Spriel @ 2019-09-03 18:51 UTC (permalink / raw)
To: Rafał Miłecki, Kalle Valo
Cc: Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Winnie Chang, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, Rafał Miłecki
In-Reply-To: <20190903042928.18621-1-zajec5@gmail.com>
On 9/3/2019 6:29 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Driver's main init/attach function brcmf_attach() was handling both:
> wiphy allocation and driver initialization. It meant getting a new wiphy
> on every init (initial, resume, error recovery).
>
> For supplicants/authenticators and Linux users it's move convenient to
> have the same wiphy over driver's lifetime. It allows e.g. automatic
> recovery after a firmware crash.
Typo: 'move' should be 'more'.
Regards,
Arend
^ permalink raw reply
* Re: [PATCH 1/3] brcmfmac: move "cfg80211_ops" pointer to another struct
From: Arend Van Spriel @ 2019-09-03 18:59 UTC (permalink / raw)
To: Rafał Miłecki, Kalle Valo
Cc: Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Winnie Chang, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, Rafał Miłecki
In-Reply-To: <20190903042928.18621-2-zajec5@gmail.com>
On 9/3/2019 6:29 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This moves "ops" pointer from "struct brcmf_cfg80211_info" to the
> "struct brcmf_pub". This movement makes it possible to allocate wiphy
> without attaching cfg80211 (brcmf_cfg80211_attach()). It's required for
> later separation of wiphy allocation and driver initialization.
>
> While at it fix also an unlikely memory leak in the brcmf_attach().
Always good ;-)
I recall there is some fiddling with the callback ops in cfg80211.c. Is
that broken by this reorg. Need to look into that.
Regards,
Arend
^ permalink raw reply
* Re: [PATCH 2/3] brcmfmac: split brcmf_attach() and brcmf_detach() functions
From: Arend Van Spriel @ 2019-09-03 19:03 UTC (permalink / raw)
To: Rafał Miłecki, Kalle Valo
Cc: Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Winnie Chang, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, Rafał Miłecki
In-Reply-To: <20190903042928.18621-3-zajec5@gmail.com>
On 9/3/2019 6:29 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Move code allocating/freeing wiphy out of above functions. This will
> allow reinitializing the driver (e.g. on some error) without allocating
> a new wiphy.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../broadcom/brcm80211/brcmfmac/bus.h | 4 ++-
> .../broadcom/brcm80211/brcmfmac/core.c | 33 ++++++++++++++----
> .../broadcom/brcm80211/brcmfmac/pcie.c | 13 +++++--
> .../broadcom/brcm80211/brcmfmac/sdio.c | 15 ++++++--
> .../broadcom/brcm80211/brcmfmac/usb.c | 34 +++++++++++++++----
> 5 files changed, 80 insertions(+), 19 deletions(-)
^ permalink raw reply
* Re: [PATCH 3/3] brcmfmac: don't realloc wiphy during PCIe reset
From: Arend Van Spriel @ 2019-09-03 19:04 UTC (permalink / raw)
To: Rafał Miłecki, Kalle Valo
Cc: Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng,
Winnie Chang, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, Rafał Miłecki
In-Reply-To: <20190903042928.18621-4-zajec5@gmail.com>
On 9/3/2019 6:29 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Providing a new wiphy on every PCIe reset was confusing and was causing
> configuration problems for some users (supplicant and authenticators).
> Sticking to the existing wiphy should make error recovery much simpler
> and more reliable.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply
* RE: [PATCH 3/7] ath10k: add workqueue for RX path of sdio
From: Wen Gong @ 2019-09-04 2:31 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566302108-18219-4-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Tuesday, August 20, 2019 7:55 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH 3/7] ath10k: add workqueue for RX path of sdio
>
Patch v2 sent, https://patchwork.kernel.org/patch/11116671/
> --
> 1.9.1
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH 4/8] rtw88: 8822c: add FW IQK support
From: Tony Chuang @ 2019-09-04 2:31 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless@vger.kernel.org, briannorris@chromium.org,
sgruszka@redhat.com
In-Reply-To: <20190903125324.4CDC76085C@smtp.codeaurora.org>
>
> <yhchuang@realtek.com> wrote:
>
> > From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >
> > Add support for doing IQK in firmware
> >
> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> The commit log does not answer "Why?". What is IQK and how does it help?
>
> No need to resend, I can update the commit log but just let me know what to
> add.
>
Ideally the RF component's I/Q vectors should be orthogonal, but usually they are not.
So we need to calibrate for the RF components, ex. PA/LNA, ADC/DAC.
And if the I/Q vectors are more orthogonal, the mixed signal will have less deviation.
This helps with those rates with higher modulation (MCS8-9), because they have more
strict EVM/SNR requirement. Also the better of the quality of the signal, the longer it
can propagate, and the better throughput performance we can get.
Yan-Hsuan
^ permalink raw reply
* RE: [PATCH 4/7] ath10k: disable TX complete indication of htt for sdio
From: Wen Gong @ 2019-09-04 2:33 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566302108-18219-5-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Tuesday, August 20, 2019 7:55 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH 4/7] ath10k: disable TX complete indication of htt for
> sdio
>
Patch v2 sent, https://patchwork.kernel.org/patch/11116685/
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH 5/7] ath10k: add htt TX bundle for sdio
From: Wen Gong @ 2019-09-04 2:34 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566302108-18219-6-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Tuesday, August 20, 2019 7:55 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH 5/7] ath10k: add htt TX bundle for sdio
>
Patch v2 sent, https://patchwork.kernel.org/patch/11116687/
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH 6/7] ath10k: enable alt data of TX path for sdio
From: Wen Gong @ 2019-09-04 2:36 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566302108-18219-7-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Tuesday, August 20, 2019 7:55 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH 6/7] ath10k: enable alt data of TX path for sdio
>
Patch v2 sent, https://patchwork.kernel.org/patch/11116683/
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH 7/7] ath10k: enable napi on RX path for sdio
From: Wen Gong @ 2019-09-04 2:37 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566302108-18219-8-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Tuesday, August 20, 2019 7:55 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH 7/7] ath10k: enable napi on RX path for sdio
>
Patch v2 sent, https://patchwork.kernel.org/patch/11116669/
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet
From: Wen Gong @ 2019-09-04 2:42 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-2-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 1/8] ath10k: adjust skb length in
> ath10k_sdio_mbox_rx_packet
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126221/
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 2/8] ath10k: enable RX bundle receive for sdio
From: Wen Gong @ 2019-09-04 2:43 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-3-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 2/8] ath10k: enable RX bundle receive for sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126223/
> 1.9.1
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 2/8] ath10k: enable RX bundle receive for sdio
From: Wen Gong @ 2019-09-04 2:48 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-3-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 2/8] ath10k: enable RX bundle receive for sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126223/
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v4 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio
From: Wen Gong @ 2019-09-04 2:50 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1567416146-14403-4-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Monday, September 2, 2019 5:22 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v4 3/8] ath10k: change max RX bundle size from 8 to
> 32 for sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126225/
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio
From: Wen Gong @ 2019-09-04 2:52 UTC (permalink / raw)
To: Nicolas Boichat, Wen Gong
Cc: open list:NETWORKING DRIVERS (WIRELESS),
ath10k@lists.infradead.org
In-Reply-To: <CANMq1KDLXsar1AqU=mfce-2LGD7SRDmC5phkKtz92D3BG35Eog@mail.gmail.com>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Nicolas
> Boichat
> Sent: Friday, August 30, 2019 11:11 AM
> To: Wen Gong <wgong@codeaurora.org>
> Cc: open list:NETWORKING DRIVERS (WIRELESS) <linux-
> wireless@vger.kernel.org>; ath10k@lists.infradead.org
> Subject: [EXT] Re: [PATCH v3 3/8] ath10k: change max RX bundle size from 8
> to 32 for sdio
Patch v4 sent, https://patchwork.kernel.org/patch/11126225/
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 4/8] ath10k: add workqueue for RX path of sdio
From: Wen Gong @ 2019-09-04 2:53 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-5-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 4/8] ath10k: add workqueue for RX path of sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126229/
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 5/8] ath10k: disable TX complete indication of htt for sdio
From: Wen Gong @ 2019-09-04 2:54 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-6-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 5/8] ath10k: disable TX complete indication of htt
> for sdio
Patch v4 sent, https://patchwork.kernel.org/patch/11126231/
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 6/8] ath10k: add htt TX bundle for sdio
From: Wen Gong @ 2019-09-04 2:56 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-7-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 6/8] ath10k: add htt TX bundle for sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126233/
> 1.9.1
>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 7/8] ath10k: enable alt data of TX path for sdio
From: Wen Gong @ 2019-09-04 2:58 UTC (permalink / raw)
To: Wen Gong, ath10k@lists.infradead.org; +Cc: linux-wireless@vger.kernel.org
In-Reply-To: <1566998177-2658-8-git-send-email-wgong@codeaurora.org>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Wen Gong
> Sent: Wednesday, August 28, 2019 9:16 PM
> To: ath10k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: [EXT] [PATCH v3 7/8] ath10k: enable alt data of TX path for sdio
>
Patch v4 sent, https://patchwork.kernel.org/patch/11126235/
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH v3 8/8] ath10k: enable napi on RX path for sdio
From: Wen Gong @ 2019-09-04 2:59 UTC (permalink / raw)
To: Nicolas Boichat, Wen Gong
Cc: open list:NETWORKING DRIVERS (WIRELESS),
ath10k@lists.infradead.org
In-Reply-To: <CANMq1KBXWydTR50fVqF7ks5gBTpUAS8Ga-8_MzeMGAknnyoVzg@mail.gmail.com>
> -----Original Message-----
> From: ath10k <ath10k-bounces@lists.infradead.org> On Behalf Of Nicolas
> Boichat
> Sent: Friday, August 30, 2019 11:20 AM
> To: Wen Gong <wgong@codeaurora.org>
> Cc: open list:NETWORKING DRIVERS (WIRELESS) <linux-
> wireless@vger.kernel.org>; ath10k@lists.infradead.org
> Subject: [EXT] Re: [PATCH v3 8/8] ath10k: enable napi on RX path for sdio
>
> On Fri, Aug 30, 2019 at 1:50 AM Wen Gong <wgong@codeaurora.org> wrote:
Patch v4 sent, https://patchwork.kernel.org/patch/11126239/
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply
* RE: [PATCH 2/7] ath10k: change max RX bundle size from 8 to 32 for sdio
From: Wen Gong @ 2019-09-04 4:43 UTC (permalink / raw)
To: Dave Taht, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
In-Reply-To: <87k1apnyyo.fsf@taht.net>
> -----Original Message-----
> From: Dave Taht <dave@taht.net>
> Sent: Wednesday, September 4, 2019 12:10 AM
> To: Wen Gong <wgong@qti.qualcomm.com>; ath10k@lists.infradead.org;
> linux-wireless@vger.kernel.org
> Subject: [EXT] Re: [PATCH 2/7] ath10k: change max RX bundle size from 8 to
> 32 for sdio
>
>
> In terms of deeply grokking what increasing buffering to achieve high
> bandwidth on a testbench, vs what it can do to clobber latency in the
> real world at low bandwidths, I tend to point folk at:
>
> https://www.youtube.com/watch?v=Rb-UnHDw02o&t=25m40s
>
> where I got a whole bunch of hackers to stand up and act like packets
> in an aggregating FIFO wifi queue.
>
> This key section is only 8 minutes long, and I promise, y'all laugh
> at least 3 times at the demonstration.
>
> At the time, also, the ath10k was so overbuffered that on one test
> I could try to start 100 flows, and only get five.
>
> https://lwn.net/Articles/705884/
>
> and on my slides:
>
> https://blog.linuxplumbersconf.org/2016/ocw//system/presentations/3963/
> original/linuxplumbers_wifi_latency-3Nov.pdf
>
Hi Dave,
So your mean is change 8 to 32 will impact latency? It will increase latency of rx?
>
> 0xFFFEFFFF
^ permalink raw reply
* Re: [PATCH][next] wil6210: fix wil_cid_valid with negative cid values
From: Kalle Valo @ 2019-09-04 6:05 UTC (permalink / raw)
To: Colin King
Cc: Maya Erez, David S . Miller, linux-wireless, wil6210, netdev,
kernel-janitors, linux-kernel
In-Reply-To: <20190702144026.13013-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> There are several occasions where a negative cid value is passed
> into wil_cid_valid and this is converted into a u8 causing the
> range check of cid >= 0 to always succeed. Fix this by making
> the cid argument an int to handle any -ve error value of cid.
>
> An example of this behaviour is in wil_cfg80211_dump_station,
> where cid is assigned -ENOENT if the call to wil_find_cid_by_idx
> fails, and this -ve value is passed to wil_cid_valid. I believe
> that the conversion of -ENOENT to the u8 value 254 which is
> greater than wil->max_assoc_sta causes wil_find_cid_by_idx to
> currently work fine, but I think is by luck and not the
> intended behaviour.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
23bb9f692b66 wil6210: fix wil_cid_valid with negative cid values
--
https://patchwork.kernel.org/patch/11027989/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH v8 2/2] wil6210: Add EDMG channel support
From: Kalle Valo @ 2019-09-04 6:06 UTC (permalink / raw)
To: Alexei Avshalom Lazar
Cc: Johannes Berg, Alexei Avshalom Lazar, linux-wireless, wil6210
In-Reply-To: <1566138918-3823-3-git-send-email-ailizaro@codeaurora.org>
Alexei Avshalom Lazar <ailizaro@codeaurora.org> wrote:
> Add support for Enhanced Directional Multi-Gigabit (EDMG) channels 9-11.
> wil6210 reports it's EDMG capabilities (that are also based on FW
> capability) to cfg80211 by filling
> wiphy->bands[NL80211_BAND_60GHZ]->edmg_cap.
> wil6210 handles edmg.channels and edmg.bw_config requested in connect
> and start_ap operations.
>
> Signed-off-by: Alexei Avshalom Lazar <ailizaro@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
9abe3e306ecc wil6210: Add EDMG channel support
--
https://patchwork.kernel.org/patch/11099621/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH] wil6210: Delete an unnecessary kfree() call in wil_tid_ampdu_rx_alloc()
From: Kalle Valo @ 2019-09-04 6:08 UTC (permalink / raw)
To: Markus Elfring
Cc: linux-wireless, netdev, wil6210, David S. Miller, Maya Erez, LKML,
kernel-janitors
In-Reply-To: <b9620e49-618d-b392-6456-17de5807df75@web.de>
Markus Elfring <Markus.Elfring@web.de> wrote:
> A null pointer would be passed to a call of the function “kfree”
> directly after a call of the function “kcalloc” failed at one place.
> Remove this superfluous function call.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> Reviewed-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
d20b1e6c8307 wil6210: Delete an unnecessary kfree() call in wil_tid_ampdu_rx_alloc()
--
https://patchwork.kernel.org/patch/11117119/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
* Re: [PATCH -next] carl9170: remove set but not used variable 'udev'
From: Kalle Valo @ 2019-09-04 6:10 UTC (permalink / raw)
To: YueHaibing
Cc: chunkeey, linux-kernel, netdev, linux-wireless, davem, YueHaibing
In-Reply-To: <20190702141207.47552-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/ath/carl9170/usb.c: In function carl9170_usb_disconnect:
> drivers/net/wireless/ath/carl9170/usb.c:1110:21:
> warning: variable udev set but not used [-Wunused-but-set-variable]
>
> It is not use since commit feb09b293327 ("carl9170:
> fix misuse of device driver API")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
68092f9cf932 carl9170: remove set but not used variable 'udev'
--
https://patchwork.kernel.org/patch/11027909/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox