* [PATCH] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create()
@ 2026-06-10 9:22 wuyankun
2026-06-10 11:00 ` Tetsuo Handa
0 siblings, 1 reply; 5+ messages in thread
From: wuyankun @ 2026-06-10 9:22 UTC (permalink / raw)
To: linux-wireless
Cc: jeff.johnson, johan, kees, wuyankun, sumanth.gavini, linux-kernel,
syzkaller-bugs, syzbot+f80c62f371ba6a1e7d79, stable
ath6kl_usb_create() currently creates ath6kl_wq with flags set to 0:
alloc_workqueue("ath6kl_wq", 0, 0)
This triggers a runtime warning in __alloc_workqueue() because the queue is
created with neither WQ_PERCPU nor WQ_UNBOUND set:
workqueue: ath6kl_wq is using neither WQ_PERCPU or WQ_UNBOUND.
Setting WQ_PERCPU.
Set WQ_PERCPU explicitly to match the actual execution model and remove the
warning during device probe. No functional change intended.
Fixes: 62ebaf2f9261 ("ath6kl: avoid flush_scheduled_work() usage")
Reported-by: syzbot+f80c62f371ba6a1e7d79@syzkaller.appspotmail.com
Link: https://lore.kernel.org/all/6a289c01.39669fcc.33b062.00aa.GAE@google.com/T/
Cc: stable@vger.kernel.org
Signed-off-by: wuyankun <wuyankun@uniontech.com>
---
drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 79c18f5ee02b..945984c3dbe6 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -636,7 +636,7 @@ static struct ath6kl_usb *ath6kl_usb_create(struct usb_interface *interface)
ar_usb = kzalloc_obj(struct ath6kl_usb);
if (ar_usb == NULL)
return NULL;
- ar_usb->wq = alloc_workqueue("ath6kl_wq", 0, 0);
+ ar_usb->wq = alloc_workqueue("ath6kl_wq", WQ_PERCPU, 0);
if (!ar_usb->wq) {
kfree(ar_usb);
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create()
2026-06-10 9:22 [PATCH] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create() wuyankun
@ 2026-06-10 11:00 ` Tetsuo Handa
2026-06-11 1:55 ` [PATCH v2] " wuyankun
0 siblings, 1 reply; 5+ messages in thread
From: Tetsuo Handa @ 2026-06-10 11:00 UTC (permalink / raw)
To: wuyankun, linux-wireless
Cc: jeff.johnson, johan, kees, sumanth.gavini, linux-kernel,
syzkaller-bugs, syzbot+f80c62f371ba6a1e7d79, stable
On 2026/06/10 18:22, wuyankun wrote:
> ath6kl_usb_create() currently creates ath6kl_wq with flags set to 0:
>
> alloc_workqueue("ath6kl_wq", 0, 0)
>
> This triggers a runtime warning in __alloc_workqueue() because the queue is
> created with neither WQ_PERCPU nor WQ_UNBOUND set:
>
> workqueue: ath6kl_wq is using neither WQ_PERCPU or WQ_UNBOUND.
> Setting WQ_PERCPU.
>
> Set WQ_PERCPU explicitly to match the actual execution model and remove the
> warning during device probe. No functional change intended.
>
> Fixes: 62ebaf2f9261 ("ath6kl: avoid flush_scheduled_work() usage")
Please use
Fixes: 21c05ca88a54 ("workqueue: Add warnings and ensure one among WQ_PERCPU or WQ_UNBOUND is present")
for this problem because this problem is caused by
WQ subsystem is about to start requiring WQ_PERCPU unless WQ_UNBOUND,
without updating all in-tree users before start emitting WARNING: message
. Also, you don't need to send to stable, but please try to send to linux.git before
7.1-final is released (because this fix should be applied before 21c05ca88a54 is
applied in order to avoid flooding of WARNING: messages).
> Reported-by: syzbot+f80c62f371ba6a1e7d79@syzkaller.appspotmail.com
> Link: https://lore.kernel.org/all/6a289c01.39669fcc.33b062.00aa.GAE@google.com/T/
> Cc: stable@vger.kernel.org
> Signed-off-by: wuyankun <wuyankun@uniontech.com>
> ---
> drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
> index 79c18f5ee02b..945984c3dbe6 100644
> --- a/drivers/net/wireless/ath/ath6kl/usb.c
> +++ b/drivers/net/wireless/ath/ath6kl/usb.c
> @@ -636,7 +636,7 @@ static struct ath6kl_usb *ath6kl_usb_create(struct usb_interface *interface)
> ar_usb = kzalloc_obj(struct ath6kl_usb);
> if (ar_usb == NULL)
> return NULL;
> - ar_usb->wq = alloc_workqueue("ath6kl_wq", 0, 0);
> + ar_usb->wq = alloc_workqueue("ath6kl_wq", WQ_PERCPU, 0);
> if (!ar_usb->wq) {
> kfree(ar_usb);
> return NULL;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create()
2026-06-10 11:00 ` Tetsuo Handa
@ 2026-06-11 1:55 ` wuyankun
2026-06-14 22:31 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: wuyankun @ 2026-06-11 1:55 UTC (permalink / raw)
To: penguin-kernel
Cc: jeff.johnson, johan, kees, linux-kernel, linux-wireless,
sumanth.gavini, syzbot+f80c62f371ba6a1e7d79, syzkaller-bugs,
wuyankun
ath6kl_usb_create() currently creates ath6kl_wq with flags set to 0:
alloc_workqueue("ath6kl_wq", 0, 0)
This triggers a runtime warning in __alloc_workqueue() because the queue is
created with neither WQ_PERCPU nor WQ_UNBOUND set:
workqueue: ath6kl_wq is using neither WQ_PERCPU or WQ_UNBOUND.
Setting WQ_PERCPU.
Set WQ_PERCPU explicitly to match the actual execution model and remove the
warning during device probe. No functional change intended.
Fixes: 21c05ca88a54 ("workqueue: Add warnings and ensure one among WQ_PERCPU or WQ_UNBOUND is present")
Reported-by: syzbot+f80c62f371ba6a1e7d79@syzkaller.appspotmail.com
Link: https://lore.kernel.org/all/6a289c01.39669fcc.33b062.00aa.GAE@google.com/T/
Signed-off-by: wuyankun <wuyankun@uniontech.com>
---
drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 79c18f5ee02b..945984c3dbe6 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -636,7 +636,7 @@ static struct ath6kl_usb *ath6kl_usb_create(struct usb_interface *interface)
ar_usb = kzalloc_obj(struct ath6kl_usb);
if (ar_usb == NULL)
return NULL;
- ar_usb->wq = alloc_workqueue("ath6kl_wq", 0, 0);
+ ar_usb->wq = alloc_workqueue("ath6kl_wq", WQ_PERCPU, 0);
if (!ar_usb->wq) {
kfree(ar_usb);
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create()
@ 2026-06-12 6:05 wuyankun
0 siblings, 0 replies; 5+ messages in thread
From: wuyankun @ 2026-06-12 6:05 UTC (permalink / raw)
To: linux-wireless
Cc: penguin-kernel, jeff.johnson, johan, kees, linux-kernel,
sumanth.gavini, syzbot+f80c62f371ba6a1e7d79, syzkaller-bugs,
wuyankun
ath6kl_usb_create() currently creates ath6kl_wq with flags set to 0:
alloc_workqueue("ath6kl_wq", 0, 0)
This triggers a runtime warning in __alloc_workqueue() because the queue is
created with neither WQ_PERCPU nor WQ_UNBOUND set:
workqueue: ath6kl_wq is using neither WQ_PERCPU or WQ_UNBOUND.
Setting WQ_PERCPU.
Set WQ_PERCPU explicitly to match the actual execution model and remove the
warning during device probe. No functional change intended.
Fixes: 21c05ca88a54 ("workqueue: Add warnings and ensure one among WQ_PERCPU or WQ_UNBOUND is present")
Reported-by: syzbot+f80c62f371ba6a1e7d79@syzkaller.appspotmail.com
Link: https://lore.kernel.org/all/6a289c01.39669fcc.33b062.00aa.GAE@google.com/T/
Signed-off-by: wuyankun <wuyankun@uniontech.com>
---
drivers/net/wireless/ath/ath6kl/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath6kl/usb.c b/drivers/net/wireless/ath/ath6kl/usb.c
index 79c18f5ee02b..945984c3dbe6 100644
--- a/drivers/net/wireless/ath/ath6kl/usb.c
+++ b/drivers/net/wireless/ath/ath6kl/usb.c
@@ -636,7 +636,7 @@ static struct ath6kl_usb *ath6kl_usb_create(struct usb_interface *interface)
ar_usb = kzalloc_obj(struct ath6kl_usb);
if (ar_usb == NULL)
return NULL;
- ar_usb->wq = alloc_workqueue("ath6kl_wq", 0, 0);
+ ar_usb->wq = alloc_workqueue("ath6kl_wq", WQ_PERCPU, 0);
if (!ar_usb->wq) {
kfree(ar_usb);
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create()
2026-06-11 1:55 ` [PATCH v2] " wuyankun
@ 2026-06-14 22:31 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2026-06-14 22:31 UTC (permalink / raw)
To: wuyankun, Tetsuo Handa, Jeff Johnson
Cc: johan, kees, linux-kernel, linux-wireless, sumanth.gavini,
syzbot+f80c62f371ba6a1e7d79, syzkaller-bugs
Applied to wq/for-7.2, thanks.
Holler if there are any concerns.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-06-14 22:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-10 9:22 [PATCH] wifi: ath6kl: fix invalid workqueue flags in ath6kl_usb_create() wuyankun
2026-06-10 11:00 ` Tetsuo Handa
2026-06-11 1:55 ` [PATCH v2] " wuyankun
2026-06-14 22:31 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2026-06-12 6:05 wuyankun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox