From: Christoffer Holmstedt <christoffer@christofferholmstedt.se>
To: linux-wpan@vger.kernel.org
Subject: [PATCH wpan-tools] info: add frequency output to current channel
Date: Wed, 3 Jun 2015 13:47:27 +0200 [thread overview]
Message-ID: <20150603114722.GA7329@probook-6560b> (raw)
Signed-off-by: Christoffer Holmstedt <christoffer@christofferholmstedt.se>
---
Not much to say here but I realised that the formatting done by
print_freq_handler() add extra whitespaces when not needed e.g. when used for
the current_channel output. I'm thinking about refactoring print_freq_handler()
to get_freq() and return the float which in the end will let the caller do the
formatting.
As an example to this problem default channel of 13 for channel page 0 with the
openlabs SPI board for RPi will print 2 whitespaces instead of one which would
look better.
current_channel: 13, 2415 MHz
It's not a big deal but I've put it on my todo list.
src/info.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/info.c b/src/info.c
index cd6b2b74172e..9e27176f53e6 100644
--- a/src/info.c
+++ b/src/info.c
@@ -193,8 +193,13 @@ static int print_phy_handler(struct nl_msg *msg, void *arg)
if (tb_msg[NL802154_ATTR_PAGE])
printf("current_page: %d\n", nla_get_u8(tb_msg[NL802154_ATTR_PAGE]));
- if (tb_msg[NL802154_ATTR_CHANNEL])
- printf("current_channel: %d\n", nla_get_u8(tb_msg[NL802154_ATTR_CHANNEL]));
+ if (tb_msg[NL802154_ATTR_CHANNEL] &&
+ tb_msg[NL802154_ATTR_PAGE]) {
+ printf("current_channel: %d, ", nla_get_u8(tb_msg[NL802154_ATTR_CHANNEL]));
+ print_freq_handler(nla_get_u8(tb_msg[NL802154_ATTR_PAGE]),
+ nla_get_u8(tb_msg[NL802154_ATTR_CHANNEL]));
+ printf(" MHz\n");
+ }
if (tb_msg[NL802154_ATTR_CCA_MODE]) {
cca_mode = nla_get_u32(tb_msg[NL802154_ATTR_CCA_MODE]);
--
1.9.1
--
Christoffer Holmstedt
next reply other threads:[~2015-06-03 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:47 Christoffer Holmstedt [this message]
2015-06-04 7:09 ` [PATCH wpan-tools] info: add frequency output to current channel Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603114722.GA7329@probook-6560b \
--to=christoffer@christofferholmstedt.se \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox