From: Alexander Aring <alex.aring@gmail.com>
To: Christoffer Holmstedt <christoffer@christofferholmstedt.se>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [PATCH wpan-tools] info: add frequency output to current channel
Date: Thu, 4 Jun 2015 09:09:44 +0200 [thread overview]
Message-ID: <20150604070940.GB1232@omega> (raw)
In-Reply-To: <20150603114722.GA7329@probook-6560b>
On Wed, Jun 03, 2015 at 01:47:27PM +0200, Christoffer Holmstedt wrote:
> Signed-off-by: Christoffer Holmstedt <christoffer@christofferholmstedt.se>
> ---
> Not much to say here but I realised that the formatting done by
> print_freq_handler() add extra whitespaces when not needed e.g. when used for
> the current_channel output. I'm thinking about refactoring print_freq_handler()
> to get_freq() and return the float which in the end will let the caller do the
> formatting.
>
> As an example to this problem default channel of 13 for channel page 0 with the
> openlabs SPI board for RPi will print 2 whitespaces instead of one which would
> look better.
>
> current_channel: 13, 2415 MHz
>
> It's not a big deal but I've put it on my todo list.
>
ok. Applied thanks.
- Alex
prev parent reply other threads:[~2015-06-04 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 11:47 [PATCH wpan-tools] info: add frequency output to current channel Christoffer Holmstedt
2015-06-04 7:09 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150604070940.GB1232@omega \
--to=alex.aring@gmail.com \
--cc=christoffer@christofferholmstedt.se \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox