[PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands

[PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands

[Miquel Raynal]

Allow running:
iwpan phy <phy> scan trigger ...
iwpan phy <phy> scan abort ...

Aside with the existing:
iwpan dev <dev> scan trigger ...
iwpan dev <dev> scan abort ...

This change does not apply easily to the TOPLEVEL(scan) command, so we
keep this one more constrained for simplicity.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 src/scan.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/scan.c b/src/scan.c
index e92702d..8bc21ca 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -541,11 +541,15 @@ TOPLEVEL(scan, "type <type> [page <page>] [channels <bitfield>] [duration <durat
 	SCAN_TYPES);
 COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_NETDEV, scan_abort_handler,
 	"Abort ongoing scanning on this virtual interface");
+COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_PHY, scan_abort_handler, NULL);
 COMMAND(scan, trigger,
 	"type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
 	NL802154_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, scan_trigger_handler,
 	"Launch scanning on this virtual interface with the given configuration.\n"
 	SCAN_TYPES);
+COMMAND(scan, trigger,
+	"type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
+	NL802154_CMD_TRIGGER_SCAN, 0, CIB_PHY, scan_trigger_handler, NULL);
 
 SECTION(beacons);
 
-- 
2.34.1

Re: [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands

[Miquel Raynal]

Hi Stefan,

miquel.raynal@bootlin.com wrote on Mon, 13 Feb 2023 18:47:03 +0100:

> Allow running:
> iwpan phy <phy> scan trigger ...
> iwpan phy <phy> scan abort ...
> 
> Aside with the existing:
> iwpan dev <dev> scan trigger ...
> iwpan dev <dev> scan abort ...
> 
> This change does not apply easily to the TOPLEVEL(scan) command, so we
> keep this one more constrained for simplicity.

I believe this patch felt into the cracks, I think I remember it came
from a request from Alex, maybe you will want to consider it for merge
despite its "age"? Or maybe I missed some feedback in the SPAMS /o\

> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  src/scan.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/scan.c b/src/scan.c
> index e92702d..8bc21ca 100644
> --- a/src/scan.c
> +++ b/src/scan.c
> @@ -541,11 +541,15 @@ TOPLEVEL(scan, "type <type> [page <page>] [channels <bitfield>] [duration <durat
>  	SCAN_TYPES);
>  COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_NETDEV, scan_abort_handler,
>  	"Abort ongoing scanning on this virtual interface");
> +COMMAND(scan, abort, NULL, NL802154_CMD_ABORT_SCAN, 0, CIB_PHY, scan_abort_handler, NULL);
>  COMMAND(scan, trigger,
>  	"type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
>  	NL802154_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, scan_trigger_handler,
>  	"Launch scanning on this virtual interface with the given configuration.\n"
>  	SCAN_TYPES);
> +COMMAND(scan, trigger,
> +	"type <type> [page <page>] [channels <bitfield>] [duration <duration-order>]",
> +	NL802154_CMD_TRIGGER_SCAN, 0, CIB_PHY, scan_trigger_handler, NULL);
>  
>  SECTION(beacons);
>  

Thanks,
Miquèl

Re: [PATCH wpan-tools] iwpan: Allow the phy shortcut for scanning commands

[Stefan Schmidt]

Hello.

On 28.11.23 12:27, Miquel Raynal wrote:
> Hi Stefan,
> 
> miquel.raynal@bootlin.com wrote on Mon, 13 Feb 2023 18:47:03 +0100:
> 
>> Allow running:
>> iwpan phy <phy> scan trigger ...
>> iwpan phy <phy> scan abort ...
>>
>> Aside with the existing:
>> iwpan dev <dev> scan trigger ...
>> iwpan dev <dev> scan abort ...
>>
>> This change does not apply easily to the TOPLEVEL(scan) command, so we
>> keep this one more constrained for simplicity.
> 
> I believe this patch felt into the cracks, I think I remember it came
> from a request from Alex, maybe you will want to consider it for merge
> despite its "age"? Or maybe I missed some feedback in the SPAMS /o\

Nope, just fallen through the cracks. Applied now:

https://github.com/linux-wpan/wpan-tools/commit/3036dc0533abd6a89d5d0df0f3d9013aa294cbb3

regards
Stefan Schmidt