From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <aar@pengutronix.de>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, marcel@holtmann.org,
jukka.rissanen@linux.intel.com, hannes@stressinduktion.org,
mcr@sandelman.ca, werner@almesberger.net,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request
Date: Tue, 3 May 2016 20:16:53 +0200 [thread overview]
Message-ID: <5728EB15.7060801@osg.samsung.com> (raw)
In-Reply-To: <1461140382-4784-4-git-send-email-aar@pengutronix.de>
Hello.
On 20/04/16 10:19, Alexander Aring wrote:
> Since we use exported function from ipv6 kernel module we don't need to
> request the module anymore to have ipv6 functionality.
>
> Signed-off-by: Alexander Aring<aar@pengutronix.de>
> ---
> net/6lowpan/core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/6lowpan/core.c b/net/6lowpan/core.c
> index fbae31e..824d1bc 100644
> --- a/net/6lowpan/core.c
> +++ b/net/6lowpan/core.c
> @@ -158,8 +158,6 @@ static int __init lowpan_module_init(void)
> return ret;
> }
>
> - request_module_nowait("ipv6");
> -
> request_module_nowait("nhc_dest");
> request_module_nowait("nhc_fragment");
> request_module_nowait("nhc_hop");
Good point.
Reviewed-by: Stefan Schmidt<stefan@osg.samsung.com>
regards
Stefan Schmidt
next prev parent reply other threads:[~2016-05-03 18:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 8:19 [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd Alexander Aring
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 01/10] 6lowpan: add private neighbour data Alexander Aring
2016-05-02 18:59 ` Hannes Frederic Sowa
2016-05-04 10:43 ` Alexander Aring
2016-05-03 18:16 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 02/10] 6lowpan: add 802.15.4 short addr slaac Alexander Aring
2016-05-02 19:06 ` Hannes Frederic Sowa
2016-05-03 18:16 ` Stefan Schmidt
2016-05-06 9:26 ` Alexander Aring
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 03/10] 6lowpan: remove ipv6 module request Alexander Aring
2016-05-02 19:06 ` Hannes Frederic Sowa
2016-05-03 18:16 ` Stefan Schmidt [this message]
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 04/10] ndisc: add addr_len parameter to ndisc_opt_addr_space Alexander Aring
2016-05-02 19:37 ` Hannes Frederic Sowa
2016-05-04 12:30 ` Alexander Aring
2016-05-06 22:23 ` Hannes Frederic Sowa
2016-05-08 10:39 ` Alexander Aring
2016-05-03 18:17 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 05/10] ndisc: add addr_len parameter to ndisc_opt_addr_data Alexander Aring
2016-05-03 18:17 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 06/10] ndisc: add addr_len parameter to ndisc_fill_addr_option Alexander Aring
2016-05-03 18:17 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 07/10] ipv6: introduce neighbour discovery ops Alexander Aring
2016-05-02 19:36 ` Hannes Frederic Sowa
2016-05-03 18:17 ` Stefan Schmidt
2016-05-06 9:36 ` Alexander Aring
2016-05-04 12:23 ` Stefan Schmidt
2016-05-06 9:47 ` Alexander Aring
2016-05-06 10:19 ` Alexander Aring
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 08/10] ipv6: export ndisc functions Alexander Aring
2016-05-02 19:39 ` Hannes Frederic Sowa
2016-05-08 10:46 ` Alexander Aring
2016-05-04 12:23 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 09/10] 6lowpan: introduce 6lowpan-nd Alexander Aring
2016-05-04 12:23 ` Stefan Schmidt
2016-04-20 8:19 ` [PATCHv2 bluetooth-next 10/10] 6lowpan: add support for 802.15.4 short addr handling Alexander Aring
2016-05-04 12:23 ` Stefan Schmidt
2016-04-28 11:36 ` [PATCHv2 bluetooth-next 00/10] 6lowpan: introduce basic 6lowpan-nd Alexander Aring
2016-05-02 17:25 ` Marcel Holtmann
2016-05-02 19:52 ` Hannes Frederic Sowa
2016-05-02 23:17 ` Marcel Holtmann
2016-05-03 20:07 ` David Miller
2016-05-13 2:59 ` YOSHIFUJI Hideaki
2016-05-13 12:33 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728EB15.7060801@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=aar@pengutronix.de \
--cc=hannes@stressinduktion.org \
--cc=jukka.rissanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mcr@sandelman.ca \
--cc=netdev@vger.kernel.org \
--cc=werner@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox