Re: [PATCH bluetooth-next 1/3] nl802154: move PAD to right position

[Stefan Schmidt <stefan@osg.samsung.com>]

Hello.

On 11/05/16 11:44, Alexander Aring wrote:
> The PAD define should be above the experimental support. We don't care
> about if we break userspace in experimental stuff but PAD is part of the
> existing UAPI.
>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Signed-off-by: Alexander Aring <aar@pengutronix.de>
> ---
>   include/net/nl802154.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/nl802154.h b/include/net/nl802154.h
> index fcab4de..7aad2fd 100644
> --- a/include/net/nl802154.h
> +++ b/include/net/nl802154.h
> @@ -124,6 +124,8 @@ enum nl802154_attrs {
>   
>   	NL802154_ATTR_ACKREQ_DEFAULT,
>   
> +	NL802154_ATTR_PAD,
> +
>   	/* add attributes here, update the policy in nl802154.c */
>   
>   #ifdef CONFIG_IEEE802154_NL802154_EXPERIMENTAL
> @@ -138,8 +140,6 @@ enum nl802154_attrs {
>   	NL802154_ATTR_SEC_KEY,
>   #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */
>   
> -	NL802154_ATTR_PAD,
> -
>   	__NL802154_ATTR_AFTER_LAST,
>   	NL802154_ATTR_MAX = __NL802154_ATTR_AFTER_LAST - 1
>   };

Reviewed-by: Stefan Schmidt<stefan@osg.samsung.com>

regards
Stefan Schmidt