From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <aar@pengutronix.de>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH bluetooth-next 3/3] ieee802154: allow netns create of lowpan interface
Date: Wed, 11 May 2016 17:19:29 +0200 [thread overview]
Message-ID: <57334D81.8040302@osg.samsung.com> (raw)
In-Reply-To: <1462959859-6669-3-git-send-email-aar@pengutronix.de>
Hello.
On 11/05/16 11:44, Alexander Aring wrote:
> This patch reverts commit f9d1ce8f81eb ("ieee802154: fix netns settings").
> The lowpan interface need to be created inside the net namespace where
> the wpan interface is available. The wpan namespace can be changed only
> by nl802154 before. Without this patch it's not possible to create a
> lowpan interface for a wpan interface which isn't inside init_net
> namespace.
>
> Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> Signed-off-by: Alexander Aring <aar@pengutronix.de>
> ---
> net/ieee802154/6lowpan/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c
> index dd085db..096e3db 100644
> --- a/net/ieee802154/6lowpan/core.c
> +++ b/net/ieee802154/6lowpan/core.c
> @@ -131,8 +131,7 @@ static int lowpan_newlink(struct net *src_net, struct net_device *ldev,
>
> pr_debug("adding new link\n");
>
> - if (!tb[IFLA_LINK] ||
> - !net_eq(dev_net(ldev), &init_net))
> + if (!tb[IFLA_LINK])
> return -EINVAL;
> /* find and hold wpan device */
> wdev = dev_get_by_index(dev_net(ldev), nla_get_u32(tb[IFLA_LINK]));
Reviewed-by: Stefan Schmidt<stefan@osg.samsung.com>
regards
Stefan Schmidt
next prev parent reply other threads:[~2016-05-11 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 9:44 [PATCH bluetooth-next 1/3] nl802154: move PAD to right position Alexander Aring
2016-05-11 9:44 ` [PATCH bluetooth-next 2/3] ieee802154: add netns support Alexander Aring
2016-05-11 15:28 ` Stefan Schmidt
2016-05-12 0:14 ` Alexander Aring
2016-05-11 9:44 ` [PATCH bluetooth-next 3/3] ieee802154: allow netns create of lowpan interface Alexander Aring
2016-05-11 15:19 ` Stefan Schmidt [this message]
2016-05-11 17:14 ` Michael Richardson
2016-05-11 23:34 ` Alexander Aring
2016-05-12 7:28 ` Nicolas Dichtel
2016-05-13 12:27 ` Alexander Aring
2016-05-17 21:50 ` Alexander Aring
2016-05-11 14:32 ` [PATCH bluetooth-next 1/3] nl802154: move PAD to right position Nicolas Dichtel
2016-05-11 15:18 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57334D81.8040302@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=aar@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox