A "fixed" version of Stéphane Fillod's xotd for Linux

A "fixed" version of Stéphane Fillod's xotd for Linux

[John Hughes]

I've been playing around with xotd-0.04 for a while and have come up
with a version that I think fixes some serious bugs, notably some
problems with lost outbound calls.  (I append my earlier message
describing this problem).

It also allows configuration of multiple remote XOT devices.

---

I said: 

> I'm having a little problem making Linux xotd work with my 
> home grown implementation, but I think I've tracked it down 
> to a difference of opinion about when the TCP call should be 
> cleared. 

The way xotd works is that it clears the TCP call if it 
recieves an X.25 CLEAR CONFIRMATION: 

        void *tap_writer(void *arg) 
        { 
        ... 
            while (1) { 

                nread = readn(sockfd,(unsigned char*)&header, 
                              sizeof(struct xot_header)); 
                if (nread != sizeof(struct xot_header)) { 
        ... 
                     break;  /* abort */ 
                } 
        ... 

            } 

            if (isVerbose) 
                printd("TCP connection closed (tap writer), 
                       lci=%d.",curr_lci); 

            hash_remove(&hash_table, sockfd, lci); 

            close(sockfd);      /* TODO: add to a spare list, 
                                   for use by tap_reader */ 

This seems reasonable.  *BUT* if xotd SENDS a CLEAR CONFIRMATION, 
in the other direction it does not clear the call, it keeps it 
open and will re-use it for new connections.  (It used to clear 
the call, but as of version 0.04 this is commented out). 

Now imagine what happens when two of these xotd's are talking 
together - 

xotd#1                            xotd#2         
send clear conf >----\ 
                      \----------> Get clear conf 
                                           | 
                        /--------< Clear TCP call 
Send new call >----\   / 
                    \ / 
                     X 
                    / 
Eurgh          <---/ 

Whoops! the new call has been sent on a socket that has been 
closed by the other side. 

PVCs on X.25?

[Ricardo Dias Cassali]

Hi,
I'm using the Generic HDLC layer, with X.25 protocol support enabled, 
and my intention is to run IP over X.25.
Is there a way to configure PVCs in this case?

Thanks in advance,
Ricardo Cassali.

Re: PVCs on X.25?

[Arnaldo Carvalho de Melo]

Em Wed, Dec 18, 2002 at 05:12:13PM -0200, Ricardo Dias Cassali escreveu:
> Hi,
> I'm using the Generic HDLC layer, with X.25 protocol support enabled, 
> and my intention is to run IP over X.25.
> Is there a way to configure PVCs in this case?

Not that I'm aware, only setup I know that allows IP over X.25 on Linux is
using Cyclades Cyclom 2X board with the driver I wrote several years ago
and is present in the kernel.

- Arnaldo

RE : A "fixed" version of Stéphane Fillod's xotd for Linux

[John Hughes]

I said:

> I've been playing around with xotd-0.04 for a while and have come up
> with a version that I think fixes some serious bugs ...

And I forgot to say that you can get it from:

	http://www.atlantech.com/~john/xotd.c

if you want.

Re: A "fixed" version of Stéphane Fillod's xotd for Linux

[Ian Cass]

> > I've been playing around with xotd-0.04 for a while and have come up
> > with a version that I think fixes some serious bugs ...

I recognise some of those bugs from when we were using Linux XOTD with a
Cisco 1600. We're now letting a Cisco 2600 terminate the X25 call & forward
it with TCP, so we don't use XOT at all now.

--
Ian Cass