* [PATCH 2/2] NET: wan/x25, fix ldisc->open retval
[not found] <4CED9498.9080900@suse.cz>
@ 2010-11-24 23:27 ` Jiri Slaby
2010-11-25 23:13 ` Sergey Lapin
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2010-11-24 23:27 UTC (permalink / raw)
To: gregkh; +Cc: slapin, linux-kernel, jirislaby, Alan Cox, Andrew Hendry,
linux-x25
We should never return positive values from ldisc->open, tty layer
doesn't (and never did) expect that.
If we do that, weird things like warnings in tty_ldisc_close happen.
Not sure if dev->base_addr is used somehow now.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Andrew Hendry <andrew.hendry@gmail.com>
Cc: linux-x25@vger.kernel.org
---
drivers/net/wan/x25_asy.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
index d81ad83..66cda25 100644
--- a/drivers/net/wan/x25_asy.c
+++ b/drivers/net/wan/x25_asy.c
@@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty)
if (err)
return err;
/* Done. We have linked the TTY line to a channel. */
- return sl->dev->base_addr;
+ return 0;
}
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] NET: wan/x25, fix ldisc->open retval
2010-11-24 23:27 ` [PATCH 2/2] NET: wan/x25, fix ldisc->open retval Jiri Slaby
@ 2010-11-25 23:13 ` Sergey Lapin
0 siblings, 0 replies; 2+ messages in thread
From: Sergey Lapin @ 2010-11-25 23:13 UTC (permalink / raw)
To: Jiri Slaby
Cc: gregkh, linux-kernel, jirislaby, Alan Cox, Andrew Hendry,
linux-x25
On Thu, Nov 25, 2010 at 12:27:55AM +0100, Jiri Slaby wrote:
> We should never return positive values from ldisc->open, tty layer
> doesn't (and never did) expect that.
>
> If we do that, weird things like warnings in tty_ldisc_close happen.
>
> Not sure if dev->base_addr is used somehow now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Andrew Hendry <andrew.hendry@gmail.com>
> Cc: linux-x25@vger.kernel.org
Tested-by: Sergey Lapin <slapin@ossfans.org>
> ---
> drivers/net/wan/x25_asy.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c
> index d81ad83..66cda25 100644
> --- a/drivers/net/wan/x25_asy.c
> +++ b/drivers/net/wan/x25_asy.c
> @@ -582,7 +582,7 @@ static int x25_asy_open_tty(struct tty_struct *tty)
> if (err)
> return err;
> /* Done. We have linked the TTY line to a channel. */
> - return sl->dev->base_addr;
> + return 0;
> }
>
>
> --
> 1.7.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-25 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4CED9498.9080900@suse.cz>
2010-11-24 23:27 ` [PATCH 2/2] NET: wan/x25, fix ldisc->open retval Jiri Slaby
2010-11-25 23:13 ` Sergey Lapin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox