* [PATCH 4/4] Hold RTNL while calling dev_close() [not found] <20080506182654.GF2217@solarflare.com> @ 2008-05-06 18:41 ` Ben Hutchings 2008-05-08 9:54 ` David Miller 2008-06-27 5:32 ` Jeff Garzik 0 siblings, 2 replies; 4+ messages in thread From: Ben Hutchings @ 2008-05-06 18:41 UTC (permalink / raw) To: Jeff Garzik, linux-x25; +Cc: David Miller, netdev dev_close() must be called holding the RTNL. Compile-tested only. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/wan/x25_asy.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index 249e180..069f8bb 100644 --- a/drivers/net/wan/x25_asy.c +++ b/drivers/net/wan/x25_asy.c @@ -32,6 +32,7 @@ #include <linux/x25.h> #include <linux/lapb.h> #include <linux/init.h> +#include <linux/rtnetlink.h> #include "x25_asy.h" #include <net/x25device.h> @@ -601,8 +602,10 @@ static void x25_asy_close_tty(struct tty_struct *tty) if (!sl || sl->magic != X25_ASY_MAGIC) return; + rtnl_lock(); if (sl->dev->flags & IFF_UP) dev_close(sl->dev); + rtnl_unlock(); tty->disc_data = NULL; sl->tty = NULL; -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] Hold RTNL while calling dev_close() 2008-05-06 18:41 ` [PATCH 4/4] Hold RTNL while calling dev_close() Ben Hutchings @ 2008-05-08 9:54 ` David Miller 2008-05-31 16:01 ` Ben Hutchings 2008-06-27 5:32 ` Jeff Garzik 1 sibling, 1 reply; 4+ messages in thread From: David Miller @ 2008-05-08 9:54 UTC (permalink / raw) To: bhutchings; +Cc: jgarzik, linux-x25, netdev From: Ben Hutchings <bhutchings@solarflare.com> Date: Tue, 6 May 2008 19:41:48 +0100 > dev_close() must be called holding the RTNL. Compile-tested only. > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Acked-by: David S. Miller <davem@davemloft.net> Jeff, please grab this one too. Thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] Hold RTNL while calling dev_close() 2008-05-08 9:54 ` David Miller @ 2008-05-31 16:01 ` Ben Hutchings 0 siblings, 0 replies; 4+ messages in thread From: Ben Hutchings @ 2008-05-31 16:01 UTC (permalink / raw) To: linux-x25; +Cc: davem, jgarzik David Miller wrote: > From: Ben Hutchings <bhutchings@solarflare.com> > Date: Tue, 6 May 2008 19:41:48 +0100 > > > dev_close() must be called holding the RTNL. Compile-tested only. > > > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> > > Acked-by: David S. Miller <davem@davemloft.net> > > Jeff, please grab this one too. I don't see any sign that this has been applied. Could maybe do with an ACK or NAK from linux-x25? Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] Hold RTNL while calling dev_close() 2008-05-06 18:41 ` [PATCH 4/4] Hold RTNL while calling dev_close() Ben Hutchings 2008-05-08 9:54 ` David Miller @ 2008-06-27 5:32 ` Jeff Garzik 1 sibling, 0 replies; 4+ messages in thread From: Jeff Garzik @ 2008-06-27 5:32 UTC (permalink / raw) To: Ben Hutchings; +Cc: linux-x25, David Miller, netdev Ben Hutchings wrote: > dev_close() must be called holding the RTNL. Compile-tested only. > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> > --- > drivers/net/wan/x25_asy.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) applied ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-27 5:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080506182654.GF2217@solarflare.com>
2008-05-06 18:41 ` [PATCH 4/4] Hold RTNL while calling dev_close() Ben Hutchings
2008-05-08 9:54 ` David Miller
2008-05-31 16:01 ` Ben Hutchings
2008-06-27 5:32 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox