Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
	djwong@kernel.org, john.g.garry@oracle.com, tytso@mit.edu,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ext4@vger.kernel.org
Subject: [PATCH v6 03/12] common/rc: Add a helper to run fsx on a given file
Date: Thu, 11 Sep 2025 22:43:34 +0530	[thread overview]
Message-ID: <18c7546ebcb6dbf72d591f3c6f6b29101aa48b95.1757610403.git.ojaswin@linux.ibm.com> (raw)
In-Reply-To: <cover.1757610403.git.ojaswin@linux.ibm.com>

Currently run_fsx is hardcoded to run on a file in $TEST_DIR.
Add a helper _run_fsx_on_file so that we can run fsx on any
given file including in $SCRATCH_MNT. Also, refactor _run_fsx
to use this helper.

No functional change is intended in this patch.

Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
---
 common/rc | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/common/rc b/common/rc
index 8a023b9d..ac77a650 100644
--- a/common/rc
+++ b/common/rc
@@ -5203,13 +5203,24 @@ _require_hugepage_fsx()
 		_notrun "fsx binary does not support MADV_COLLAPSE"
 }
 
-_run_fsx()
+_run_fsx_on_file()
 {
+	local testfile=$1
+	shift
+
+	if ! [ -f $testfile ]
+	then
+		echo "_run_fsx_on_file: $testfile doesn't exist. Creating" >> $seqres.full
+		touch $testfile
+	fi
+
 	echo "fsx $*"
 	local args=`echo $@ | sed -e "s/ BSIZE / $bsize /g" -e "s/ PSIZE / $psize /g"`
-	set -- $FSX_PROG $args $FSX_AVOID $TEST_DIR/junk
+
+	set -- $FSX_PROG $args $FSX_AVOID $testfile
+
 	echo "$@" >>$seqres.full
-	rm -f $TEST_DIR/junk
+	rm -f $testfile
 	"$@" 2>&1 | tee -a $seqres.full >$tmp.fsx
 	local res=${PIPESTATUS[0]}
 	if [ $res -ne 0 ]; then
@@ -5221,6 +5232,12 @@ _run_fsx()
 	return 0
 }
 
+_run_fsx()
+{
+	_run_fsx_on_file $TEST_DIR/junk $@
+	return $?
+}
+
 # Run fsx with -h(ugepage buffers).  If we can't set up a hugepage then skip
 # the test, but if any other error occurs then exit the test.
 _run_hugepage_fsx() {
-- 
2.49.0


  parent reply	other threads:[~2025-09-11 17:14 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 17:13 [PATCH v6 00/11] Add more tests for multi fs block atomic writes Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 01/12] common/rc: Add _min() and _max() helpers Ojaswin Mujoo
2025-09-12 16:53   ` John Garry
2025-09-15 11:19     ` Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 02/12] common/rc: Add fio atomic write helpers Ojaswin Mujoo
2025-09-15 13:11   ` John Garry
2025-09-11 17:13 ` Ojaswin Mujoo [this message]
2025-09-15 13:12   ` [PATCH v6 03/12] common/rc: Add a helper to run fsx on a given file John Garry
2025-09-11 17:13 ` [PATCH v6 04/12] ltp/fsx.c: Add atomic writes support to fsx Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 05/12] generic: Add atomic write test using fio crc check verifier Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 06/12] generic: Add atomic write test using fio verify on file mixed mappings Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 07/12] generic: Add atomic write multi-fsblock O_[D]SYNC tests Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 08/12] generic: Stress fsx with atomic writes enabled Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 09/12] generic: Add sudden shutdown tests for multi block atomic writes Ojaswin Mujoo
2025-09-15 13:26   ` John Garry
2025-09-17  8:09     ` Ojaswin Mujoo
2025-09-18  7:29       ` John Garry
2025-09-11 17:13 ` [PATCH v6 10/12] ext4: Test atomic write and ioend codepaths with bigalloc Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 11/12] ext4: Test atomic writes allocation and write " Ojaswin Mujoo
2025-09-11 17:13 ` [PATCH v6 12/12] ext4: Atomic write test for extent split across leaf nodes Ojaswin Mujoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18c7546ebcb6dbf72d591f3c6f6b29101aa48b95.1757610403.git.ojaswin@linux.ibm.com \
    --to=ojaswin@linux.ibm.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=john.g.garry@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ritesh.list@gmail.com \
    --cc=tytso@mit.edu \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox