From: Dave Chinner <david@fromorbit.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: xfs@oss.sgi.com
Subject: Re: [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY
Date: Wed, 16 Apr 2014 10:31:05 +1000 [thread overview]
Message-ID: <20140416003105.GX15995@dastard> (raw)
In-Reply-To: <20140414104953.GE10187@tucsk.piliscsaba.szeredi.hu>
On Mon, Apr 14, 2014 at 12:49:53PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> XFS is returning EEXIST rather than ENOTEMPTY for several of
> these rename tests. The rename man page says this about the errors:
>
> ENOTEMPTY or EEXIST
> newpath is a nonempty directory, that is, contains
> entries other than "." and "..".
>
> Which implies that both errors are valid and so the test should pass
> in either case.
>
> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-04-16 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 10:49 [xfstests PATCH] renameat2 syscall: turn EEXIST into ENOTEMPTY Miklos Szeredi
2014-04-16 0:31 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416003105.GX15995@dastard \
--to=david@fromorbit.com \
--cc=miklos@szeredi.hu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox