From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs <linux-xfs@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] xfs: don't set DAX flag for v2 inodes
Date: Wed, 30 Aug 2017 09:22:05 -0700 [thread overview]
Message-ID: <20170830162205.GO4757@magnolia> (raw)
In-Reply-To: <20170830161500.GA1755@infradead.org>
On Wed, Aug 30, 2017 at 09:15:00AM -0700, Christoph Hellwig wrote:
> How about returning an error from xfs_set_diflags for
> anything that would go into di_flags2 for v2 inodes?
I had also thought about refactoring all those xfs_ioctl_setattr_xflags
validity checks into a single separate checking function, how about that?
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-30 16:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 15:55 [PATCH] xfs: don't set DAX flag for v2 inodes Darrick J. Wong
2017-08-30 16:15 ` Christoph Hellwig
2017-08-30 16:22 ` Darrick J. Wong [this message]
2017-08-30 16:38 ` [PATCH v2] xfs: don't set v3 xflags " Darrick J. Wong
2017-08-31 13:17 ` Christoph Hellwig
2017-08-31 13:34 ` Brian Foster
2017-08-31 14:06 ` Christoph Hellwig
2017-08-31 14:09 ` Christoph Hellwig
2017-08-31 14:17 ` Brian Foster
2017-08-31 19:57 ` Darrick J. Wong
2017-09-01 7:21 ` Christoph Hellwig
2017-09-01 17:52 ` Darrick J. Wong
2017-09-01 19:29 ` Christoph Hellwig
2017-09-01 19:40 ` Darrick J. Wong
2017-09-01 20:06 ` Darrick J. Wong
2017-09-01 20:08 ` Christoph Hellwig
2017-08-31 13:35 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830162205.GO4757@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox