* [PATCH] xfs: fix u32 type usage in sb validation function
@ 2018-01-30 3:36 Darrick J. Wong
2018-01-30 19:57 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-01-30 3:36 UTC (permalink / raw)
To: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't use u32, use uint32_t, because this won't work in xfsprogs.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/libxfs/xfs_sb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index 46af6aa..a55f7a4 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -118,8 +118,8 @@ xfs_mount_validate_sb(
bool check_inprogress,
bool check_version)
{
- u32 agcount = 0;
- u32 rem;
+ uint32_t agcount = 0;
+ uint32_t rem;
if (sbp->sb_magicnum != XFS_SB_MAGIC) {
xfs_warn(mp, "bad magic number");
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs: fix u32 type usage in sb validation function
2018-01-30 3:36 [PATCH] xfs: fix u32 type usage in sb validation function Darrick J. Wong
@ 2018-01-30 19:57 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2018-01-30 19:57 UTC (permalink / raw)
To: Darrick J. Wong, xfs
On 1/29/18 9:36 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Don't use u32, use uint32_t, because this won't work in xfsprogs.
mmkay :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_sb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index 46af6aa..a55f7a4 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -118,8 +118,8 @@ xfs_mount_validate_sb(
> bool check_inprogress,
> bool check_version)
> {
> - u32 agcount = 0;
> - u32 rem;
> + uint32_t agcount = 0;
> + uint32_t rem;
>
> if (sbp->sb_magicnum != XFS_SB_MAGIC) {
> xfs_warn(mp, "bad magic number");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-30 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-30 3:36 [PATCH] xfs: fix u32 type usage in sb validation function Darrick J. Wong
2018-01-30 19:57 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox