* [PATCH] xfs/500: fix review comments
@ 2019-02-19 5:29 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2019-02-19 5:29 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, xfs, Dave Chinner
From: Darrick J. Wong <darrick.wong@oracle.com>
Fix some problems detecting reflink support in the test.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/500 | 5 ++---
tests/xfs/group | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/xfs/500 b/tests/xfs/500
index 7a965c69..370c78ec 100755
--- a/tests/xfs/500
+++ b/tests/xfs/500
@@ -36,10 +36,9 @@ _scratch_mkfs -d extszinherit=8388608 >> $seqres.full 2>&1
test $? -eq 1 || echo "should have failed extszinherit"
# Try cow extent size hint if supported
-$MKFS_XFS_PROG -N -f $SCRATCH_DEV > $tmp.mkfs
-if grep -q 'reflink=' $tmp.mkfs ; then
+if _scratch_mkfs_xfs_supported -m crc=1,reflink=1 >> $seqres.full 2>&1; then
echo cowextsize >> $seqres.full
- _scratch_mkfs -m reflink=1 -d cowextsize=8388608 >> $seqres.full 2>&1
+ _scratch_mkfs -m reflink=1,crc=1 -d cowextsize=8388608 >> $seqres.full 2>&1
test $? -eq 1 || echo "should have failed cowextsize"
fi
diff --git a/tests/xfs/group b/tests/xfs/group
index 76b8a413..0047fb5c 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -497,6 +497,6 @@
497 dangerous_fuzzers dangerous_scrub dangerous_online_repair
498 dangerous_fuzzers dangerous_norepair
499 auto quick
-500 auto quick mkfs
+500 auto quick mkfs prealloc mkfs
501 auto quick unlink
502 auto quick unlink
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-19 5:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-19 5:29 [PATCH] xfs/500: fix review comments Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox