From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: sandeen@sandeen.net, bfoster@redhat.com, david@fromorbit.com,
linux-xfs@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify'
Date: Mon, 26 Aug 2019 12:14:40 -0700 [thread overview]
Message-ID: <20190826191440.GT1037350@magnolia> (raw)
In-Reply-To: <1566825695-90533-1-git-send-email-zhengbin13@huawei.com>
On Mon, Aug 26, 2019 at 09:21:35PM +0800, zhengbin wrote:
> Fixes gcc warning:
>
> fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'max_recs' description in 'xfs_btree_sblock_v5hdr_verify'
> fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'pag_max_level' description in 'xfs_btree_sblock_v5hdr_verify'
>
> Fixes: c5ab131ba0df ("libxfs: refactor short btree block verification")
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_btree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index f1048ef..802eb53 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4466,8 +4466,6 @@ xfs_btree_lblock_verify(
> * btree block
> *
> * @bp: buffer containing the btree block
> - * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
> - * @pag_max_level: pointer to the per-ag max level field
> */
> xfs_failaddr_t
> xfs_btree_sblock_v5hdr_verify(
> --
> 2.7.4
>
prev parent reply other threads:[~2019-08-26 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 13:21 [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify' zhengbin
2019-08-26 19:14 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826191440.GT1037350@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox