Linux XFS filesystem development
 help / color / mirror / Atom feed
* [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify'
@ 2019-08-26 13:21 zhengbin
  2019-08-26 19:14 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: zhengbin @ 2019-08-26 13:21 UTC (permalink / raw)
  To: darrick.wong, sandeen, bfoster, david, linux-xfs; +Cc: yi.zhang, zhengbin13

Fixes gcc warning:

fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'max_recs' description in 'xfs_btree_sblock_v5hdr_verify'
fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'pag_max_level' description in 'xfs_btree_sblock_v5hdr_verify'

Fixes: c5ab131ba0df ("libxfs: refactor short btree block verification")
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/xfs/libxfs/xfs_btree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
index f1048ef..802eb53 100644
--- a/fs/xfs/libxfs/xfs_btree.c
+++ b/fs/xfs/libxfs/xfs_btree.c
@@ -4466,8 +4466,6 @@ xfs_btree_lblock_verify(
  *				      btree block
  *
  * @bp: buffer containing the btree block
- * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
- * @pag_max_level: pointer to the per-ag max level field
  */
 xfs_failaddr_t
 xfs_btree_sblock_v5hdr_verify(
--
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify'
  2019-08-26 13:21 [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify' zhengbin
@ 2019-08-26 19:14 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-08-26 19:14 UTC (permalink / raw)
  To: zhengbin; +Cc: sandeen, bfoster, david, linux-xfs, yi.zhang

On Mon, Aug 26, 2019 at 09:21:35PM +0800, zhengbin wrote:
> Fixes gcc warning:
> 
> fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'max_recs' description in 'xfs_btree_sblock_v5hdr_verify'
> fs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter 'pag_max_level' description in 'xfs_btree_sblock_v5hdr_verify'
> 
> Fixes: c5ab131ba0df ("libxfs: refactor short btree block verification")
> Signed-off-by: zhengbin <zhengbin13@huawei.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/libxfs/xfs_btree.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index f1048ef..802eb53 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4466,8 +4466,6 @@ xfs_btree_lblock_verify(
>   *				      btree block
>   *
>   * @bp: buffer containing the btree block
> - * @max_recs: pointer to the m_*_mxr max records field in the xfs mount
> - * @pag_max_level: pointer to the per-ag max level field
>   */
>  xfs_failaddr_t
>  xfs_btree_sblock_v5hdr_verify(
> --
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-26 19:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-26 13:21 [PATCH] xfs: remove excess function parameter description in 'xfs_btree_sblock_v5hdr_verify' zhengbin
2019-08-26 19:14 ` Darrick J. Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox