* [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation
@ 2019-08-30 0:30 Austin Kim
2019-08-30 0:33 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Austin Kim @ 2019-08-30 0:30 UTC (permalink / raw)
To: darrick.wong; +Cc: linux-xfs, linux-kernel, austindh.kim
If the CONFIG_BUG is enabled, BUG is executed and then system is crashed.
However, the bailout for mount is no longer proceeding.
For this reason, using WARN_ON_ONCE rather than BUG can prevent this situation.
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
fs/xfs/xfs_mount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 322da69..c0d0b72 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -213,8 +213,7 @@ xfs_initialize_perag(
goto out_hash_destroy;
spin_lock(&mp->m_perag_lock);
- if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
- BUG();
+ if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree, index, pag))) {
spin_unlock(&mp->m_perag_lock);
radix_tree_preload_end();
error = -EEXIST;
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation
2019-08-30 0:30 [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation Austin Kim
@ 2019-08-30 0:33 ` Darrick J. Wong
2019-08-30 1:37 ` Austin Kim
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2019-08-30 0:33 UTC (permalink / raw)
To: Austin Kim; +Cc: linux-xfs, linux-kernel
On Fri, Aug 30, 2019 at 09:30:22AM +0900, Austin Kim wrote:
> If the CONFIG_BUG is enabled, BUG is executed and then system is crashed.
> However, the bailout for mount is no longer proceeding.
>
> For this reason, using WARN_ON_ONCE rather than BUG can prevent this situation.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
> fs/xfs/xfs_mount.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index 322da69..c0d0b72 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -213,8 +213,7 @@ xfs_initialize_perag(
> goto out_hash_destroy;
>
> spin_lock(&mp->m_perag_lock);
> - if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> - BUG();
> + if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree, index, pag))) {
Er... please wrap the line at 80 columns.
--D
> spin_unlock(&mp->m_perag_lock);
> radix_tree_preload_end();
> error = -EEXIST;
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation
2019-08-30 0:33 ` Darrick J. Wong
@ 2019-08-30 1:37 ` Austin Kim
0 siblings, 0 replies; 3+ messages in thread
From: Austin Kim @ 2019-08-30 1:37 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, linux-kernel
2019년 8월 30일 (금) 오전 9:33, Darrick J. Wong <darrick.wong@oracle.com>님이 작성:
>
> On Fri, Aug 30, 2019 at 09:30:22AM +0900, Austin Kim wrote:
> > If the CONFIG_BUG is enabled, BUG is executed and then system is crashed.
> > However, the bailout for mount is no longer proceeding.
> >
> > For this reason, using WARN_ON_ONCE rather than BUG can prevent this situation.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> > fs/xfs/xfs_mount.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> > index 322da69..c0d0b72 100644
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -213,8 +213,7 @@ xfs_initialize_perag(
> > goto out_hash_destroy;
> >
> > spin_lock(&mp->m_perag_lock);
> > - if (radix_tree_insert(&mp->m_perag_tree, index, pag)) {
> > - BUG();
> > + if (WARN_ON_ONCE(radix_tree_insert(&mp->m_perag_tree, index, pag))) {
>
> Er... please wrap the line at 80 columns.
Oh..
Let me resend patch soon after wrapping 80 column lines.
>
> --D
>
> > spin_unlock(&mp->m_perag_lock);
> > radix_tree_preload_end();
> > error = -EEXIST;
> > --
> > 2.6.2
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-30 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-30 0:30 [PATCH] xfs: Use WARN_ON_ONCE rather than BUG for bailout mount-operation Austin Kim
2019-08-30 0:33 ` Darrick J. Wong
2019-08-30 1:37 ` Austin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox