From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, Ian Kent <raven@themaw.net>
Subject: Re: [PATCH 04/12] xfs: don't use a different allocsice for -o wsync mounts
Date: Mon, 28 Oct 2019 10:05:21 -0700 [thread overview]
Message-ID: <20191028170521.GM15222@magnolia> (raw)
In-Reply-To: <20191027145547.25157-5-hch@lst.de>
On Sun, Oct 27, 2019 at 03:55:39PM +0100, Christoph Hellwig wrote:
> The -o wsync allocsize overwrite overwrite was part of a special hack
> for NFSv2 servers in IRIX and has no real purpose in modern Linux, so
> remove it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
/me not being around to absorb any of the context of how the 15/16
shift values were arrived at notwithstanding,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_mount.c | 9 ++-------
> fs/xfs/xfs_mount.h | 7 -------
> 2 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
> index ba5b6f3b2b88..b423033e14f4 100644
> --- a/fs/xfs/xfs_mount.c
> +++ b/fs/xfs/xfs_mount.c
> @@ -438,13 +438,8 @@ xfs_set_rw_sizes(xfs_mount_t *mp)
> int readio_log, writeio_log;
>
> if (!(mp->m_flags & XFS_MOUNT_DFLT_IOSIZE)) {
> - if (mp->m_flags & XFS_MOUNT_WSYNC) {
> - readio_log = XFS_WSYNC_READIO_LOG;
> - writeio_log = XFS_WSYNC_WRITEIO_LOG;
> - } else {
> - readio_log = XFS_READIO_LOG_LARGE;
> - writeio_log = XFS_WRITEIO_LOG_LARGE;
> - }
> + readio_log = XFS_READIO_LOG_LARGE;
> + writeio_log = XFS_WRITEIO_LOG_LARGE;
> } else {
> readio_log = mp->m_readio_log;
> writeio_log = mp->m_writeio_log;
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index f69e370db341..dc81e5c264ce 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -260,13 +260,6 @@ typedef struct xfs_mount {
> #define XFS_MAX_IO_LOG 30 /* 1G */
> #define XFS_MIN_IO_LOG PAGE_SHIFT
>
> -/*
> - * Synchronous read and write sizes. This should be
> - * better for NFSv2 wsync filesystems.
> - */
> -#define XFS_WSYNC_READIO_LOG 15 /* 32k */
> -#define XFS_WSYNC_WRITEIO_LOG 14 /* 16k */
> -
> #define XFS_LAST_UNMOUNT_WAS_CLEAN(mp) \
> ((mp)->m_flags & XFS_MOUNT_WAS_CLEAN)
> #define XFS_FORCED_SHUTDOWN(mp) ((mp)->m_flags & XFS_MOUNT_FS_SHUTDOWN)
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-10-28 17:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 14:55 decruft misc mount related code v2 Christoph Hellwig
2019-10-27 14:55 ` [PATCH 01/12] xfs: remove the biosize mount option Christoph Hellwig
2019-10-27 14:55 ` [PATCH 02/12] xfs: remove the dsunit and dswidth variables in xfs_parseargs Christoph Hellwig
2019-10-28 16:50 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 03/12] xfs: cleanup calculating the stat optimal I/O size Christoph Hellwig
2019-10-28 16:50 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 04/12] xfs: don't use a different allocsice for -o wsync mounts Christoph Hellwig
2019-10-28 17:05 ` Darrick J. Wong [this message]
2019-10-27 14:55 ` [PATCH 05/12] xfs: remove the m_readio_* fields in struct xfs_mount Christoph Hellwig
2019-10-28 17:06 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 06/12] xfs: rename the m_writeio_* " Christoph Hellwig
2019-10-28 17:07 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 07/12] xfs: simplify parsing of allocsize mount option Christoph Hellwig
2019-10-28 17:11 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 08/12] xfs: rename the XFS_MOUNT_DFLT_IOSIZE option to XFS_MOUNT_ALLOCISZE Christoph Hellwig
2019-10-28 17:12 ` Darrick J. Wong
2019-10-29 7:50 ` Christoph Hellwig
2019-10-27 14:55 ` [PATCH 09/12] xfs: reverse the polarity of XFS_MOUNT_COMPAT_IOSIZE Christoph Hellwig
2019-10-28 17:13 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 10/12] xfs: clean up printing the allocsize option in xfs_showargs Christoph Hellwig
2019-10-28 17:13 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 11/12] xfs: clean up printing inode32/64 " Christoph Hellwig
2019-10-28 17:14 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 12/12] xfs: merge xfs_showargs into xfs_fs_show_options Christoph Hellwig
2019-10-28 17:14 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028170521.GM15222@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox