From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, Ian Kent <raven@themaw.net>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH 09/12] xfs: reverse the polarity of XFS_MOUNT_COMPAT_IOSIZE
Date: Mon, 28 Oct 2019 10:13:04 -0700 [thread overview]
Message-ID: <20191028171304.GR15222@magnolia> (raw)
In-Reply-To: <20191027145547.25157-10-hch@lst.de>
On Sun, Oct 27, 2019 at 03:55:44PM +0100, Christoph Hellwig wrote:
> Replace XFS_MOUNT_COMPAT_IOSIZE with an inverted XFS_MOUNT_LARGEIO flag
> that makes the usage more clear.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Makes much more sense,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_iops.c | 2 +-
> fs/xfs/xfs_mount.h | 2 +-
> fs/xfs/xfs_super.c | 12 +++---------
> 3 files changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 9e1f89cdcc82..18e45e3a3f9f 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -510,7 +510,7 @@ xfs_stat_blksize(
> * default buffered I/O size, return that, otherwise return the compat
> * default.
> */
> - if (!(mp->m_flags & XFS_MOUNT_COMPAT_IOSIZE)) {
> + if (mp->m_flags & XFS_MOUNT_LARGEIO) {
> if (mp->m_swidth)
> return mp->m_swidth << mp->m_sb.sb_blocklog;
> if (mp->m_flags & XFS_MOUNT_ALLOCSIZE)
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index e5c364f1605e..a46cb3fd24b1 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -236,7 +236,7 @@ typedef struct xfs_mount {
> * allocation */
> #define XFS_MOUNT_RDONLY (1ULL << 20) /* read-only fs */
> #define XFS_MOUNT_DIRSYNC (1ULL << 21) /* synchronous directory ops */
> -#define XFS_MOUNT_COMPAT_IOSIZE (1ULL << 22) /* don't report large preferred
> +#define XFS_MOUNT_LARGEIO (1ULL << 22) /* report large preferred
> * I/O size in stat() */
> #define XFS_MOUNT_FILESTREAMS (1ULL << 24) /* enable the filestreams
> allocator */
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index a7d89b87ed22..f21c59822a38 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -180,12 +180,6 @@ xfs_parseargs(
> if (sb->s_flags & SB_SYNCHRONOUS)
> mp->m_flags |= XFS_MOUNT_WSYNC;
>
> - /*
> - * Set some default flags that could be cleared by the mount option
> - * parsing.
> - */
> - mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
> -
> /*
> * These can be overridden by the mount option parsing.
> */
> @@ -274,10 +268,10 @@ xfs_parseargs(
> mp->m_flags &= ~XFS_MOUNT_IKEEP;
> break;
> case Opt_largeio:
> - mp->m_flags &= ~XFS_MOUNT_COMPAT_IOSIZE;
> + mp->m_flags |= XFS_MOUNT_LARGEIO;
> break;
> case Opt_nolargeio:
> - mp->m_flags |= XFS_MOUNT_COMPAT_IOSIZE;
> + mp->m_flags &= ~XFS_MOUNT_LARGEIO;
> break;
> case Opt_attr2:
> mp->m_flags |= XFS_MOUNT_ATTR2;
> @@ -430,12 +424,12 @@ xfs_showargs(
> { XFS_MOUNT_GRPID, ",grpid" },
> { XFS_MOUNT_DISCARD, ",discard" },
> { XFS_MOUNT_SMALL_INUMS, ",inode32" },
> + { XFS_MOUNT_LARGEIO, ",largeio" },
> { XFS_MOUNT_DAX, ",dax" },
> { 0, NULL }
> };
> static struct proc_xfs_info xfs_info_unset[] = {
> /* the few simple ones we can get from the mount struct */
> - { XFS_MOUNT_COMPAT_IOSIZE, ",largeio" },
> { XFS_MOUNT_SMALL_INUMS, ",inode64" },
> { 0, NULL }
> };
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-10-28 17:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 14:55 decruft misc mount related code v2 Christoph Hellwig
2019-10-27 14:55 ` [PATCH 01/12] xfs: remove the biosize mount option Christoph Hellwig
2019-10-27 14:55 ` [PATCH 02/12] xfs: remove the dsunit and dswidth variables in xfs_parseargs Christoph Hellwig
2019-10-28 16:50 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 03/12] xfs: cleanup calculating the stat optimal I/O size Christoph Hellwig
2019-10-28 16:50 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 04/12] xfs: don't use a different allocsice for -o wsync mounts Christoph Hellwig
2019-10-28 17:05 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 05/12] xfs: remove the m_readio_* fields in struct xfs_mount Christoph Hellwig
2019-10-28 17:06 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 06/12] xfs: rename the m_writeio_* " Christoph Hellwig
2019-10-28 17:07 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 07/12] xfs: simplify parsing of allocsize mount option Christoph Hellwig
2019-10-28 17:11 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 08/12] xfs: rename the XFS_MOUNT_DFLT_IOSIZE option to XFS_MOUNT_ALLOCISZE Christoph Hellwig
2019-10-28 17:12 ` Darrick J. Wong
2019-10-29 7:50 ` Christoph Hellwig
2019-10-27 14:55 ` [PATCH 09/12] xfs: reverse the polarity of XFS_MOUNT_COMPAT_IOSIZE Christoph Hellwig
2019-10-28 17:13 ` Darrick J. Wong [this message]
2019-10-27 14:55 ` [PATCH 10/12] xfs: clean up printing the allocsize option in xfs_showargs Christoph Hellwig
2019-10-28 17:13 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 11/12] xfs: clean up printing inode32/64 " Christoph Hellwig
2019-10-28 17:14 ` Darrick J. Wong
2019-10-27 14:55 ` [PATCH 12/12] xfs: merge xfs_showargs into xfs_fs_show_options Christoph Hellwig
2019-10-28 17:14 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028171304.GR15222@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox