From: Dave Chinner <david@fromorbit.com>
To: Alex Lyakas <alex@zadara.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele
Date: Mon, 4 Nov 2019 08:11:25 +1100 [thread overview]
Message-ID: <20191103211125.GZ4614@dread.disaster.area> (raw)
In-Reply-To: <CAE4254A1B4C4A2895049EE040022942@alyakaslap>
On Sun, Nov 03, 2019 at 08:24:21PM +0200, Alex Lyakas wrote:
> Hi Dave,
>
> This commit
> [37fd1678245f7a5898c1b05128bc481fb403c290 xfs: fix use-after-free race in
> xfs_buf_rele]
> fixes a use-after-free issue.
>
> We are looking at XFS buffer cache + LRU code in kernel 4.14, while the
> above fix arrived in kernel 4.19. Do you think this fix should be backported
> to stable kernels?
IIRC it was pretty difficult to exercise the bug in the first place,
and it was hit because of another bug that was fixed (referenced in
the above commit). There's no real point in fixing this without
fixing the referenced bug, as the referenced bug was the one that
caused all the actual problems...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-11-03 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 18:24 xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele Alex Lyakas
2019-11-03 21:11 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103211125.GZ4614@dread.disaster.area \
--to=david@fromorbit.com \
--cc=alex@zadara.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox