* xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele
@ 2019-11-03 18:24 Alex Lyakas
2019-11-03 21:11 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Alex Lyakas @ 2019-11-03 18:24 UTC (permalink / raw)
To: david, linux-xfs
Hi Dave,
This commit
[37fd1678245f7a5898c1b05128bc481fb403c290 xfs: fix use-after-free race in
xfs_buf_rele]
fixes a use-after-free issue.
We are looking at XFS buffer cache + LRU code in kernel 4.14, while the
above fix arrived in kernel 4.19. Do you think this fix should be backported
to stable kernels?
Thanks,
Alex.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele
2019-11-03 18:24 xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele Alex Lyakas
@ 2019-11-03 21:11 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2019-11-03 21:11 UTC (permalink / raw)
To: Alex Lyakas; +Cc: linux-xfs
On Sun, Nov 03, 2019 at 08:24:21PM +0200, Alex Lyakas wrote:
> Hi Dave,
>
> This commit
> [37fd1678245f7a5898c1b05128bc481fb403c290 xfs: fix use-after-free race in
> xfs_buf_rele]
> fixes a use-after-free issue.
>
> We are looking at XFS buffer cache + LRU code in kernel 4.14, while the
> above fix arrived in kernel 4.19. Do you think this fix should be backported
> to stable kernels?
IIRC it was pretty difficult to exercise the bug in the first place,
and it was hit because of another bug that was fixed (referenced in
the above commit). There's no real point in fixing this without
fixing the referenced bug, as the referenced bug was the one that
caused all the actual problems...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-03 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-03 18:24 xfs_buf_rele(): xfs: fix use-after-free race in xfs_buf_rele Alex Lyakas
2019-11-03 21:11 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox