From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH RFC] xfs: allow adjusting individual quota grace times
Date: Tue, 12 May 2020 16:27:37 -0700 [thread overview]
Message-ID: <20200512232737.GN6714@magnolia> (raw)
In-Reply-To: <20200511153532.GB11320@infradead.org>
On Mon, May 11, 2020 at 08:35:32AM -0700, Christoph Hellwig wrote:
> On Sat, May 09, 2020 at 02:47:02PM -0500, Eric Sandeen wrote:
> > So there's no real way to know that the grace period adjustment failed
> > on an older kernel. We could consider that a bug and fix it, or
> > consider it a change in behavior that we can't just make without
> > at least some form of versioning. Thoughts?
Well you /could/ roll this new functionality into a new revision of the
ioctl that supports 64bit time values...
> I'd consider a bug, as applications are very unlikely to rely on
> these ignored calls (famous last words..).
...but OTOH that might be a better discussion to have when we start
reviewing the bigtime series. In the meantime, seeing as xfs_quota
never really let you push out soft grace period expiration anyway, I
guess you could just teach userspace to try to make the change and
declare success if an immediate re-query shows the value changed.
--D
next prev parent reply other threads:[~2020-05-12 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 19:47 [PATCH RFC] xfs: allow adjusting individual quota grace times Eric Sandeen
2020-05-09 19:51 ` Eric Sandeen
2020-05-11 15:35 ` Christoph Hellwig
2020-05-12 23:27 ` Darrick J. Wong [this message]
2020-05-12 23:29 ` Darrick J. Wong
2020-05-12 23:34 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512232737.GN6714@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox