Re: [PATCH RFC] xfs: allow adjusting individual quota grace times

[Eric Sandeen <sandeen@sandeen.net>]

On 5/12/20 6:29 PM, Darrick J. Wong wrote:
> On Sat, May 09, 2020 at 02:47:02PM -0500, Eric Sandeen wrote:
>> vfs/ext3/4 quota allows the administrator to push out the grace time
>> for soft quota with the setquota -T command:
>>
>> setquota -T [ -u | -g ] [ -F quotaformat ] name block-grace inode-grace -a | filesystem...
>>
>>        -T, --edit-times
>>               Alter times for individual user/group when softlimit is enforced.
>>               Times block-grace and inode-grace are specified in seconds or can
>>               be string 'unset'.
>>
>> Essentially, if you do "setquota -T -u username 1d 1d" and "username" is
>> over their soft quotas and into their grace time, it will extend the
>> grace time expiry to 1d from now.
>>
>> xfs can't do this, today.  The patch below is a first cut at allowing us
>> to do this, and userspace updates are needed as well (I have those in a
>> patch stack.)
>>
>> I'm not looking so much for patch review right now, though, what I'm
>> wondering is if this is a change we can make from the ABI perspective?

...

>> +	 * For other IDs, userspace can bump out the grace period if over
>> +	 * the soft limit.
>> +	 */
>> +	if (newlim->d_fieldmask & QC_SPC_TIMER) {
>> +		if (!id)
>> +			defq->btimelimit = newlim->d_spc_timer;
>> +		ddq->d_btimer = cpu_to_be32(newlim->d_spc_timer);
>> +	}
>> +	if (newlim->d_fieldmask & QC_INO_TIMER) {
>> +		printk("setting inode timer to %d\n", newlim->d_ino_timer);
> 
> Stray printk here.
> 
>> +		if (!id)
>> +			defq->itimelimit = newlim->d_ino_timer;
>> +		ddq->d_itimer = cpu_to_be32(newlim->d_ino_timer);
>> +	}
>> +	if (newlim->d_fieldmask & QC_RT_SPC_TIMER) {
>> +		if (!id)
>> +			defq->rtbtimelimit = newlim->d_rt_spc_timer;
>> +		ddq->d_rtbtimer = cpu_to_be32(newlim->d_rt_spc_timer);
>> +	}
> 
> Otherwise I guess this looks reasonable.  It might help to patchbomb all
> the kernel/userspace/fstests changes together so I don't have to go
> scurrying around to find the pieces(?)

yeah I will do that, this was more akin to pseudocode fo the larger
"can I even change this behavior?" question.

Thanks,
-Eric